Merge pull request #536 from Drachenkaetzchen/wsl-color-warning

Inform users about 16 color limit with WSL
This commit is contained in:
Eugene 2018-12-05 01:33:36 +01:00 committed by GitHub
commit 6e5ce8e0b1
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 0 deletions

View File

@ -14,6 +14,10 @@ h3.mb-3 Shell
[ngValue]='shell.id'
) {{shell.name}}
.alert.alert-info.d-flex.align-items-center(*ngIf='config.store.terminal.shell.startsWith("wsl")')
.mr-auto WSL terminal only supports 16 colors until ConPTY is implemented in node-pty
button.btn.btn-secondary((click)='openConPtyInfo()') More Information
.form-line(*ngIf='config.store.terminal.shell == "custom"')
.header
.title Custom shell

View File

@ -30,6 +30,10 @@ export class ShellSettingsTabComponent {
this.shells = (await Promise.all(this.config.enabledServices(this.shellProviders).map(x => x.provide()))).reduce((a, b) => a.concat(b))
}
openConPtyInfo() {
this.electron.shell.openExternal('https://github.com/Microsoft/node-pty/issues/216')
}
ngOnDestroy () {
this.configSubscription.unsubscribe()
}