From 403bafe0a20a19d3a3f7ccb982e55bbac11d0a8f Mon Sep 17 00:00:00 2001 From: Eugene Pankov Date: Tue, 6 Jul 2021 21:47:15 +0200 Subject: [PATCH] lint --- tabby-core/src/components/tabBody.component.ts | 8 +++----- .../src/components/pluginsSettingsTab.component.ts | 2 +- tabby-terminal/src/api/baseTerminalTab.component.ts | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/tabby-core/src/components/tabBody.component.ts b/tabby-core/src/components/tabBody.component.ts index aa50521e..6afc2b41 100644 --- a/tabby-core/src/components/tabBody.component.ts +++ b/tabby-core/src/components/tabBody.component.ts @@ -19,15 +19,13 @@ import { BaseTabComponent } from '../components/baseTab.component' export class TabBodyComponent implements OnChanges { @Input() @HostBinding('class.active') active: boolean @Input() tab: BaseTabComponent - @ViewChild('placeholder', { read: ViewContainerRef }) placeholder: ViewContainerRef + @ViewChild('placeholder', { read: ViewContainerRef }) placeholder?: ViewContainerRef ngOnChanges (changes) { if (changes.tab) { - if (this.placeholder) { - this.placeholder.detach() - } + this.placeholder?.detach() setImmediate(() => { - this.placeholder.insert(this.tab.hostView) + this.placeholder?.insert(this.tab.hostView) }) } } diff --git a/tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts b/tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts index 2f08c150..045a8439 100644 --- a/tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts +++ b/tabby-plugin-manager/src/components/pluginsSettingsTab.component.ts @@ -50,7 +50,7 @@ export class PluginsSettingsTabComponent { return plugins })).subscribe(available => { for (const plugin of this.pluginManager.installedPlugins) { - this.knownUpgrades[plugin.name] = available.find(x => x.name === plugin.name && semverGt(x.version, plugin.version)) || null + this.knownUpgrades[plugin.name] = available.find(x => x.name === plugin.name && semverGt(x.version, plugin.version)) ?? null } }) } diff --git a/tabby-terminal/src/api/baseTerminalTab.component.ts b/tabby-terminal/src/api/baseTerminalTab.component.ts index 2557be65..5e531b7b 100644 --- a/tabby-terminal/src/api/baseTerminalTab.component.ts +++ b/tabby-terminal/src/api/baseTerminalTab.component.ts @@ -497,7 +497,7 @@ export class BaseTerminalTabComponent extends BaseTabComponent implements OnInit return } if (this.parent instanceof SplitTabComponent) { - this.allFocusModeSubscription?.unsubscribe?.() + this.allFocusModeSubscription.unsubscribe() this.allFocusModeSubscription = null this.parent._allFocusMode = false this.parent.layout()