mirror/sunmao-ui
2
0
Fork 0
mirror of https://github.com/smartxworks/sunmao-ui.git synced 2025-04-18 22:00:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #209 from webzard-io/fix/slot-component-bug

Browse Source 
fix component slot will not update after property change bug
This commit is contained in:
yz-yu 2022-01-12 10:49:43 +08:00 committed by GitHub
commit b28fbce8ab
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
packages/runtime/src/components/_internal/ImplWrapper.tsx
View File

@ -2,10 +2,7 @@ import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react'
import { merge } from 'lodash-es';
import { RuntimeComponentSchema, RuntimeTraitSchema } from '@sunmao-ui/core';
import { watch } from '../../utils/watchReactivity';
import {
ImplWrapperProps,
TraitResult,
} from '../../types';
import { ImplWrapperProps, TraitResult } from '../../types';
import { shallowCompareArray } from '../../utils/shallowCompareArray';
const _ImplWrapper = React.forwardRef<HTMLDivElement, ImplWrapperProps>((props, ref) => {
@ -227,12 +224,13 @@ export const ImplWrapper = React.memo<ImplWrapperProps>(
(prevProps, nextProps) => {
const prevChildren = prevProps.childrenMap[prevProps.component.id]?._grandChildren;
const nextChildren = nextProps.childrenMap[nextProps.component.id]?._grandChildren;
if (!prevChildren || !nextProps) return false;
const prevComponent = prevProps.component;
const nextComponent = nextProps.component;
let isEqual = false;
if (prevChildren && nextChildren) {
isEqual = shallowCompareArray(prevChildren, nextChildren);
}
return isEqual;
return isEqual && prevComponent === nextComponent;
}
);