mirror/qBittorrent
2
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-12-27 08:19:30 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix wrong QString::arg() usage that leads to crash

Browse Source 
We need to be careful when using the multi-arg version of
QString::arg() and passing as 2nd, 3rd etc parameter an int.
It doesn't do the same as passing multiple QStrings.
This commit is contained in:
sledgehammer999 2018-04-11 01:42:46 +03:00
parent 38837db8de
commit ddba79ef3d
No known key found for this signature in database
GPG Key ID: 6E4A2D025B7CC9A2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/base/net/proxyconfigurationmanager.cpp
View File

@ -139,10 +139,10 @@ void ProxyConfigurationManager::configureProxy()
, m_config.password, m_config.ip, QString::number(m_config.port)); , m_config.password, m_config.ip, QString::number(m_config.port));
break; break;
case ProxyType::HTTP: case ProxyType::HTTP:
proxyStrHTTP = QString("http://%1:%2").arg(m_config.ip, m_config.port); proxyStrHTTP = QString("http://%1:%2").arg(m_config.ip, QString::number(m_config.port));
break; break;
case ProxyType::SOCKS5: case ProxyType::SOCKS5:
proxyStrSOCK = QString("%1:%2").arg(m_config.ip, m_config.port); proxyStrSOCK = QString("%1:%2").arg(m_config.ip, QString::number(m_config.port));
break; break;
case ProxyType::SOCKS5_PW: case ProxyType::SOCKS5_PW:
proxyStrSOCK = QString("%1:%2@%3:%4").arg(m_config.username proxyStrSOCK = QString("%1:%2@%3:%4").arg(m_config.username