mirror/qBittorrent
2
0
Fork 0
mirror of https://github.com/qbittorrent/qBittorrent.git synced 2024-12-21 08:09:35 +08:00
Code Issues Packages Projects Releases Wiki Activity

Mention lack of HTTPS in WebUI magnet link warning

Browse Source 
According to Mozilla docs, registerProtocolHandler() is only
available when using secure contexts (i.e. HTTPS for everything
outside localhost).
https://developer.mozilla.org/en-US/docs/Web/API/Navigator/registerProtocolHandler

The message "Your browser does not support this feature" does not
make this obvious and can lead to confusion if the user is using a
modern browser.
This commit is contained in:
nl6720 2019-12-08 10:32:19 +02:00
parent a7bd68a2c7
commit c1ef846c3d
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/webui/www/private/scripts/client.js
View File

@ -967,7 +967,10 @@ window.addEvent('load', function() {
function registerMagnetHandler() { function registerMagnetHandler() {
if (typeof navigator.registerProtocolHandler !== 'function') { if (typeof navigator.registerProtocolHandler !== 'function') {
alert("Your browser does not support this feature"); if (window.location.protocol !== 'https:')
alert(QBT_TR("To use this feature, the WebUI needs to be accessed over HTTPS")QBT_TR[CONTEXT=MainWindow]);
else
alert(QBT_TR("Your browser does not support this feature")QBT_TR[CONTEXT=MainWindow]);
return; return;
} }