From 705d7730dc050429f821533770492b8ceae7d64e Mon Sep 17 00:00:00 2001 From: Chocobo1 Date: Tue, 21 Jun 2016 14:28:01 +0800 Subject: [PATCH] Fix upper-bound limit of command line for "Run External Program" in Windows. Closes #5399. --- src/app/application.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/app/application.cpp b/src/app/application.cpp index 622f6b307..aab9a9aed 100644 --- a/src/app/application.cpp +++ b/src/app/application.cpp @@ -262,8 +262,9 @@ void Application::runExternalProgram(BitTorrent::TorrentHandle *const torrent) c QProcess::startDetached(QLatin1String("/bin/sh"), {QLatin1String("-c"), program}); #elif defined(Q_OS_WIN) // test cmd: `echo "%F" > "c:\ab ba.txt"` program.prepend(QLatin1String("cmd.exe /C ")); - if (program.size() >= MAX_PATH) { - logger->addMessage(tr("Torrent: %1, run external program command too long (length > %2), execution failed.").arg(torrent->name()).arg(MAX_PATH), Log::CRITICAL); + const uint cmdMaxLength = 32768; // max length (incl. terminate char) for `lpCommandLine` in `CreateProcessW()` + if ((program.size() + 1) > cmdMaxLength) { + logger->addMessage(tr("Torrent: %1, run external program command too long (length > %2), execution failed.").arg(torrent->name()).arg(cmdMaxLength), Log::CRITICAL); return; }