diff --git a/src/gui/previewselectdialog.cpp b/src/gui/previewselectdialog.cpp index 753d10576..d02b20189 100644 --- a/src/gui/previewselectdialog.cpp +++ b/src/gui/previewselectdialog.cpp @@ -37,7 +37,6 @@ #include #include #include -#include #include "base/bittorrent/torrent.h" #include "base/preferences.h" @@ -77,13 +76,6 @@ PreviewSelectDialog::PreviewSelectDialog(QWidget *parent, const BitTorrent::Torr m_previewListModel->setHeaderData(SIZE, Qt::Horizontal, tr("Size")); m_previewListModel->setHeaderData(PROGRESS, Qt::Horizontal, tr("Progress")); - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(m_ui->previewList->header()); - m_ui->previewList->header()->setParent(m_ui->previewList); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); - m_ui->previewList->setAlternatingRowColors(pref->useAlternatingRowColors()); m_ui->previewList->setModel(m_previewListModel); m_ui->previewList->hideColumn(FILE_INDEX); @@ -107,6 +99,7 @@ PreviewSelectDialog::PreviewSelectDialog(QWidget *parent, const BitTorrent::Torr m_previewListModel->sort(NAME); m_ui->previewList->header()->setContextMenuPolicy(Qt::CustomContextMenu); + m_ui->previewList->header()->setFirstSectionMovable(true); m_ui->previewList->header()->setSortIndicator(0, Qt::AscendingOrder); m_ui->previewList->selectionModel()->select(m_previewListModel->index(0, NAME), QItemSelectionModel::Select | QItemSelectionModel::Rows); diff --git a/src/gui/properties/peerlistwidget.cpp b/src/gui/properties/peerlistwidget.cpp index ff1cbd128..276fda56a 100644 --- a/src/gui/properties/peerlistwidget.cpp +++ b/src/gui/properties/peerlistwidget.cpp @@ -40,7 +40,6 @@ #include #include #include -#include #include #include @@ -89,6 +88,7 @@ PeerListWidget::PeerListWidget(PropertiesWidget *parent) setAllColumnsShowFocus(true); setEditTriggers(QAbstractItemView::NoEditTriggers); setSelectionMode(QAbstractItemView::ExtendedSelection); + header()->setFirstSectionMovable(true); header()->setStretchLastSection(false); header()->setTextElideMode(Qt::ElideRight); @@ -163,13 +163,6 @@ PeerListWidget::PeerListWidget(PropertiesWidget *parent) handleSortColumnChanged(header()->sortIndicatorSection()); const auto *copyHotkey = new QShortcut(QKeySequence::Copy, this, nullptr, nullptr, Qt::WidgetShortcut); connect(copyHotkey, &QShortcut::activated, this, &PeerListWidget::copySelectedPeers); - - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(this->header()); - this->header()->setParent(this); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); } PeerListWidget::~PeerListWidget() diff --git a/src/gui/properties/trackerlistwidget.cpp b/src/gui/properties/trackerlistwidget.cpp index e700da7dc..a56b456b0 100644 --- a/src/gui/properties/trackerlistwidget.cpp +++ b/src/gui/properties/trackerlistwidget.cpp @@ -38,7 +38,6 @@ #include #include #include -#include #include #include #include @@ -70,6 +69,7 @@ TrackerListWidget::TrackerListWidget(PropertiesWidget *properties) setAllColumnsShowFocus(true); setItemsExpandable(false); setSelectionMode(QAbstractItemView::ExtendedSelection); + header()->setFirstSectionMovable(true); header()->setStretchLastSection(false); // Must be set after loadSettings() in order to work header()->setTextElideMode(Qt::ElideRight); // Ensure that at least one column is visible at all times @@ -133,13 +133,6 @@ TrackerListWidget::TrackerListWidget(PropertiesWidget *properties) connect(copyHotkey, &QShortcut::activated, this, &TrackerListWidget::copyTrackerUrl); connect(this, &QAbstractItemView::doubleClicked, this, &TrackerListWidget::editSelectedTracker); - - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(header()); - header()->setParent(this); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); } TrackerListWidget::~TrackerListWidget() diff --git a/src/gui/search/pluginselectdialog.cpp b/src/gui/search/pluginselectdialog.cpp index 64d5e6187..0f1e1ea06 100644 --- a/src/gui/search/pluginselectdialog.cpp +++ b/src/gui/search/pluginselectdialog.cpp @@ -37,7 +37,6 @@ #include #include #include -#include #include "base/global.h" #include "base/net/downloadmanager.h" @@ -69,15 +68,9 @@ PluginSelectDialog::PluginSelectDialog(SearchPluginManager *pluginManager, QWidg m_ui->setupUi(this); setAttribute(Qt::WA_DeleteOnClose); - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(m_ui->pluginsTree->header()); - m_ui->pluginsTree->header()->setParent(m_ui->pluginsTree); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); - m_ui->pluginsTree->setRootIsDecorated(false); m_ui->pluginsTree->hideColumn(PLUGIN_ID); + m_ui->pluginsTree->header()->setFirstSectionMovable(true); m_ui->pluginsTree->header()->setSortIndicator(0, Qt::AscendingOrder); m_ui->actionUninstall->setIcon(UIThemeManager::instance()->getIcon("list-remove")); diff --git a/src/gui/search/searchjobwidget.cpp b/src/gui/search/searchjobwidget.cpp index d65689ab0..dbd05dfef 100644 --- a/src/gui/search/searchjobwidget.cpp +++ b/src/gui/search/searchjobwidget.cpp @@ -37,7 +37,6 @@ #include #include #include -#include #include #include "base/bittorrent/session.h" @@ -61,15 +60,9 @@ SearchJobWidget::SearchJobWidget(SearchHandler *searchHandler, QWidget *parent) { m_ui->setupUi(this); - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(m_ui->resultsBrowser->header()); - m_ui->resultsBrowser->header()->setParent(m_ui->resultsBrowser); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); - loadSettings(); + header()->setFirstSectionMovable(true); header()->setStretchLastSection(false); header()->setTextElideMode(Qt::ElideRight); diff --git a/src/gui/torrentcontenttreeview.cpp b/src/gui/torrentcontenttreeview.cpp index 96bbaa7ef..20437d044 100644 --- a/src/gui/torrentcontenttreeview.cpp +++ b/src/gui/torrentcontenttreeview.cpp @@ -34,7 +34,6 @@ #include #include #include -#include #include #include "base/bittorrent/abstractfilestorage.h" @@ -66,15 +65,7 @@ TorrentContentTreeView::TorrentContentTreeView(QWidget *parent) : QTreeView(parent) { setExpandsOnDoubleClick(false); - - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(header()); - header()->setParent(this); - header()->setStretchLastSection(false); - header()->setTextElideMode(Qt::ElideRight); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); + header()->setFirstSectionMovable(true); } void TorrentContentTreeView::keyPressEvent(QKeyEvent *event) diff --git a/src/gui/transferlistwidget.cpp b/src/gui/transferlistwidget.cpp index d1bf854db..d03c0be0e 100644 --- a/src/gui/transferlistwidget.cpp +++ b/src/gui/transferlistwidget.cpp @@ -39,7 +39,6 @@ #include #include #include -#include #include #include @@ -152,6 +151,7 @@ TransferListWidget::TransferListWidget(QWidget *parent, MainWindow *mainWindow) #if defined(Q_OS_MACOS) setAttribute(Qt::WA_MacShowFocusRect, false); #endif + header()->setFirstSectionMovable(true); header()->setStretchLastSection(false); header()->setTextElideMode(Qt::ElideRight); @@ -222,13 +222,6 @@ TransferListWidget::TransferListWidget(QWidget *parent, MainWindow *mainWindow) connect(doubleClickHotkeyEnter, &QShortcut::activated, this, &TransferListWidget::torrentDoubleClicked); const auto *recheckHotkey = new QShortcut(Qt::CTRL + Qt::Key_R, this, nullptr, nullptr, Qt::WidgetShortcut); connect(recheckHotkey, &QShortcut::activated, this, &TransferListWidget::recheckSelectedTorrents); - - // This hack fixes reordering of first column with Qt5. - // https://github.com/qtproject/qtbase/commit/e0fc088c0c8bc61dbcaf5928b24986cd61a22777 - QTableView unused; - unused.setVerticalHeader(header()); - header()->setParent(this); - unused.setVerticalHeader(new QHeaderView(Qt::Horizontal)); } TransferListWidget::~TransferListWidget()