Initialize class variable in initializer list

This commit is contained in:
Chocobo1 2022-01-24 13:44:49 +08:00
parent ff99e5ac9a
commit 53992bf0d5
No known key found for this signature in database
GPG Key ID: 210D9C873253A68C
2 changed files with 5 additions and 8 deletions

View File

@ -39,8 +39,8 @@ using namespace BitTorrent;
PeerInfo::PeerInfo(const Torrent *torrent, const lt::peer_info &nativeInfo)
: m_nativeInfo(nativeInfo)
, m_relevance(calcRelevance(torrent))
{
calcRelevance(torrent);
determineFlags();
}
@ -226,19 +226,16 @@ QString PeerInfo::connectionType() const
: QLatin1String {"Web"};
}
void PeerInfo::calcRelevance(const Torrent *torrent)
qreal PeerInfo::calcRelevance(const Torrent *torrent) const
{
const QBitArray allPieces = torrent->pieces();
const int localMissing = allPieces.count(false);
if (localMissing <= 0)
{
m_relevance = 0;
return;
}
return 0;
const QBitArray peerPieces = pieces();
const int remoteHaves = (peerPieces & (~allPieces)).count(true);
m_relevance = static_cast<qreal>(remoteHaves) / localMissing;
return static_cast<qreal>(remoteHaves) / localMissing;
}
qreal PeerInfo::relevance() const

View File

@ -92,7 +92,7 @@ namespace BitTorrent
int downloadingPieceIndex() const;
private:
void calcRelevance(const Torrent *torrent);
qreal calcRelevance(const Torrent *torrent) const;
void determineFlags();
lt::peer_info m_nativeInfo = {};