From 35ebd9a0957bf466cb09a0b5b9fa30d8bc2a1fae Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Mon, 22 Jul 2019 23:24:58 -0700
Subject: [PATCH 1/2] Default WebUI search tab to enabled

Search plugins and categories are now retrieved when the Search tab is first switched to. This prevents possible unnecessary instantiation of the SearchPluginManager.
---
 src/webui/www/private/scripts/client.js | 8 +++++++-
 src/webui/www/private/search.html       | 2 --
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/src/webui/www/private/scripts/client.js b/src/webui/www/private/scripts/client.js
index f1dba3980..f2531e481 100644
--- a/src/webui/www/private/scripts/client.js
+++ b/src/webui/www/private/scripts/client.js
@@ -44,6 +44,7 @@ let alternativeSpeedLimits = false;
 let queueing_enabled = true;
 let serverSyncMainDataInterval = 1500;
 let customSyncMainDataInterval = null;
+let searchTabInitialized = false;
 
 let clipboardEvent;
 
@@ -254,7 +255,7 @@ window.addEvent('load', function() {
         $('speedInBrowserTitleBarLink').firstChild.style.opacity = '0';
 
     // After showing/hiding the toolbar + status bar
-    let showSearchEngine = localStorage.getItem('show_search_engine') === "true";
+    let showSearchEngine = localStorage.getItem('show_search_engine') !== "false";
     if (!showSearchEngine) {
         // uncheck menu option
         $('showSearchEngineLink').firstChild.style.opacity = '0';
@@ -788,6 +789,11 @@ window.addEvent('load', function() {
     };
 
     const showSearchTab = function() {
+        if (!searchTabInitialized) {
+            initSearchTab();
+            searchTabInitialized = true;
+        }
+
         $("searchTabColumn").removeClass("invisible");
         customSyncMainDataInterval = 30000;
         hideTransfersTab();
diff --git a/src/webui/www/private/search.html b/src/webui/www/private/search.html
index 2ff92d075..bf3569fdf 100644
--- a/src/webui/www/private/search.html
+++ b/src/webui/www/private/search.html
@@ -639,6 +639,4 @@
         clearTimeout(loadSearchResultsTimer);
         loadSearchResultsTimer = loadSearchResultsData.delay(500);
     };
-
-    initSearchTab();
 </script>

From 6ea6e52d9920ed5c1b7c42fe5256ba6e09357407 Mon Sep 17 00:00:00 2001
From: Thomas Piccirello <thomas@piccirello.com>
Date: Fri, 26 Jul 2019 02:54:11 -0700
Subject: [PATCH 2/2] Add context menu to Web UI search table

Web UI implementation of #10852.
---
 src/webui/www/private/scripts/client.js |  2 -
 src/webui/www/private/search.html       | 83 ++++++++++++++++++-------
 2 files changed, 60 insertions(+), 25 deletions(-)

diff --git a/src/webui/www/private/scripts/client.js b/src/webui/www/private/scripts/client.js
index f2531e481..645e165a8 100644
--- a/src/webui/www/private/scripts/client.js
+++ b/src/webui/www/private/scripts/client.js
@@ -1010,8 +1010,6 @@ function setupCopyEventHandler() {
                     return copyMagnetLinkFN();
                 case "copyHash":
                     return copyHashFN();
-                case "copyDescriptionPageUrl":
-                    return copySearchTorrentUrl();
                 default:
                     return "";
             }
diff --git a/src/webui/www/private/search.html b/src/webui/www/private/search.html
index bf3569fdf..d1c986cd0 100644
--- a/src/webui/www/private/search.html
+++ b/src/webui/www/private/search.html
@@ -48,10 +48,6 @@
         width: 4em;
     }
 
-    #downloadSearchTorrent, #openSearchTorrentDescription, #copyDescriptionPageUrl {
-        line-height: 1.5em;
-    }
-
     #manageSearchPlugins {
         line-height: 1.5em;
         float: right;
@@ -143,13 +139,23 @@
     </div>
 
     <div style="height: 30px; padding-top: 10px;">
-        <button id="downloadSearchTorrent" onclick="downloadSearchTorrent()">QBT_TR(Download)QBT_TR[CONTEXT=SearchEngineWidget]</button>
-        <button id="openSearchTorrentDescription" onclick="openSearchTorrentDescription()">QBT_TR(Go to description page)QBT_TR[CONTEXT=SearchEngineWidget]</button>
-        <button class="copyToClipboard" id="copyDescriptionPageUrl">QBT_TR(Copy description page URL)QBT_TR[CONTEXT=SearchEngineWidget]</button>
         <button id="manageSearchPlugins" onclick="manageSearchPlugins()">QBT_TR(Search plugins...)QBT_TR[CONTEXT=SearchEngineWidget]</button>
     </div>
 </div>
 
+<ul id="searchResultsTableMenu" class="contextMenu">
+    <li><a href="#Download"><img src="images/qbt-theme/download.svg" alt="QBT_TR(Download)QBT_TR[CONTEXT=SearchJobWidget]"/> QBT_TR(Download)QBT_TR[CONTEXT=SearchJobWidget]</a></li>
+    <li class="separator"><a href="#OpenDescriptionUrl"><img src="images/qbt-theme/application-x-mswinurl.svg" alt="QBT_TR(Open description page)QBT_TR[CONTEXT=SearchJobWidget]"/> QBT_TR(Open description page)QBT_TR[CONTEXT=SearchJobWidget]</a></li>
+    <li>
+        <a href="#" class="arrow-right"><img src="images/qbt-theme/edit-copy.svg" alt="QBT_TR(Copy)QBT_TR[CONTEXT=SearchJobWidget]"/> QBT_TR(Copy)QBT_TR[CONTEXT=SearchJobWidget]</a>
+        <ul>
+            <li><a href="#" id="copySearchTorrentName" class="copySearchDataToClipboard"><img src="images/qbt-theme/edit-copy.svg" alt="QBT_TR(Name)QBT_TR[CONTEXT=SearchJobWidget]"/>  QBT_TR(Name)QBT_TR[CONTEXT=SearchJobWidget]</a></li>
+            <li><a href="#" id="copySearchTorrentDownloadLink" class="copySearchDataToClipboard"><img src="images/qbt-theme/edit-copy.svg" alt="QBT_TR(Download link)QBT_TR[CONTEXT=SearchJobWidget]"/>  QBT_TR(Download link)QBT_TR[CONTEXT=SearchJobWidget]</a></li>
+            <li><a href="#" id="copySearchTorrentDescriptionUrl" class="copySearchDataToClipboard"><img src="images/qbt-theme/edit-copy.svg" alt="QBT_TR(Description page URL)QBT_TR[CONTEXT=SearchJobWidget]"/>  QBT_TR(Description page URL)QBT_TR[CONTEXT=SearchJobWidget]</a></li>
+        </ul>
+    </li>
+</ul>
+
 <script>
     'use strict';
 
@@ -181,8 +187,19 @@
     const initSearchTab = function() {
         // load "Search in" preference from local storage
         $('searchInTorrentName').set('value', (localStorage.getItem('search_in_filter') === "names") ? "names" : "everywhere");
-
-        searchResultsTable.setup('searchResultsTableDiv', 'searchResultsTableFixedHeaderDiv', null);
+        const searchResultsTableContextMenu = new ContextMenu({
+            targets: '.searchTableRow',
+            menu: 'searchResultsTableMenu',
+            actions: {
+                Download: downloadSearchTorrent,
+                OpenDescriptionUrl: openSearchTorrentDescriptionUrl
+            },
+            offsets: {
+                x: -15,
+                y: -53
+            }
+        });
+        searchResultsTable.setup('searchResultsTableDiv', 'searchResultsTableFixedHeaderDiv', searchResultsTableContextMenu);
         getPlugins();
 
         let searchInNameFilterTimer = null;
@@ -213,15 +230,6 @@
                     }
 
                     switch (elem.id) {
-                        case "downloadSearchTorrent":
-                            downloadSearchTorrent();
-                            break;
-                        case "openSearchTorrentDescription":
-                            openSearchTorrentDescription();
-                            break;
-                        case "copyDescriptionPageUrl":
-                            copySearchTorrentUrl();
-                            break;
                         case "manageSearchPlugins":
                             manageSearchPlugins();
                             break;
@@ -293,13 +301,29 @@
         }
     };
 
-    const openSearchTorrentDescription = function() {
+    const openSearchTorrentDescriptionUrl = function() {
         searchResultsTable.selectedRowsIds().each(function(rowId) {
             window.open(searchResultsTable.rows.get(rowId).full_data.descrLink, "_blank");
         });
     };
 
-    const copySearchTorrentUrl = function() {
+    const copySearchTorrentName = function() {
+        const names = [];
+        searchResultsTable.selectedRowsIds().each(function(rowId) {
+            names.push(searchResultsTable.rows.get(rowId).full_data.fileName);
+        });
+        return names.join("\n");
+    };
+
+    const copySearchTorrentDownloadLink = function() {
+        const urls = [];
+        searchResultsTable.selectedRowsIds().each(function(rowId) {
+            urls.push(searchResultsTable.rows.get(rowId).full_data.fileUrl);
+        });
+        return urls.join("\n");
+    };
+
+    const copySearchTorrentDescriptionUrl = function() {
         const urls = [];
         searchResultsTable.selectedRowsIds().each(function(rowId) {
             urls.push(searchResultsTable.rows.get(rowId).full_data.descrLink);
@@ -476,9 +500,6 @@
                     $('categorySelect').setProperty('disabled', searchPluginsEmpty);
                     $('pluginsSelect').setProperty('disabled', searchPluginsEmpty);
                     $('startSearchButton').setProperty('disabled', searchPluginsEmpty);
-                    $('downloadSearchTorrent').setProperty('disabled', searchPluginsEmpty);
-                    $('openSearchTorrentDescription').setProperty('disabled', searchPluginsEmpty);
-                    $('copyDescriptionPageUrl').setProperty('disabled', searchPluginsEmpty);
 
                     if (typeof updateSearchPluginsTable === "function")
                         updateSearchPluginsTable();
@@ -639,4 +660,20 @@
         clearTimeout(loadSearchResultsTimer);
         loadSearchResultsTimer = loadSearchResultsData.delay(500);
     };
+
+    new ClipboardJS('.copySearchDataToClipboard', {
+        text: function(trigger) {
+            switch (trigger.id) {
+                case "copySearchTorrentName":
+                    return copySearchTorrentName();
+                case "copySearchTorrentDownloadLink":
+                    return copySearchTorrentDownloadLink();
+                case "copySearchTorrentDescriptionUrl":
+                    return copySearchTorrentDescriptionUrl();
+                default:
+                    return "";
+            }
+        }
+    });
+
 </script>