Merge pull request #4772 from glassez/fix_crash

Fix crash caused by AdvancedSettings::addRow()
This commit is contained in:
sledgehammer999 2016-02-08 14:29:37 -06:00
commit 09d3f73154

View File

@ -312,14 +312,12 @@ void AdvancedSettings::addRow(int row, const QString &rowText, T* widget)
setItem(row, PROPERTY, new QTableWidgetItem(rowText));
setCellWidget(row, VALUE, widget);
bool ok;
if (std::is_same<T, QCheckBox>::value)
ok = connect(widget, SIGNAL(stateChanged(int)), SIGNAL(settingsChanged()));
connect(widget, SIGNAL(stateChanged(int)), SIGNAL(settingsChanged()));
else if (std::is_same<T, QSpinBox>::value)
ok = connect(widget, SIGNAL(valueChanged(int)), SIGNAL(settingsChanged()));
connect(widget, SIGNAL(valueChanged(int)), SIGNAL(settingsChanged()));
else if (std::is_same<T, QComboBox>::value)
ok = connect(widget, SIGNAL(currentIndexChanged(int)), SIGNAL(settingsChanged()));
connect(widget, SIGNAL(currentIndexChanged(int)), SIGNAL(settingsChanged()));
else if (std::is_same<T, QLineEdit>::value)
ok = connect(widget, SIGNAL(textChanged(QString)), SIGNAL(settingsChanged()));
Q_ASSERT(ok);
connect(widget, SIGNAL(textChanged(QString)), SIGNAL(settingsChanged()));
}