Andres Freund e9edc1ba0b Fix logical decoding error when system table w/ toast is repeatedly rewritten. ... Repeatedly rewriting a mapped catalog table with VACUUM FULL or CLUSTER could cause logical decoding to fail with: ERROR, "could not map filenode \"%s\" to relation OID" To trigger the problem the rewritten catalog had to have live tuples with toasted columns. The problem was triggered as during catalog table rewrites the heap_insert() check that prevents logical decoding information to be emitted for system catalogs, failed to treat the new heap's toast table as a system catalog (because the new heap is not recognized as a catalog table via RelationIsLogicallyLogged()). The relmapper, in contrast to the normal catalog contents, does not contain historical information. After a single rewrite of a mapped table the new relation is known to the relmapper, but if the table is rewritten twice before logical decoding occurs, the relfilenode cannot be mapped to a relation anymore. Which then leads us to error out. This only happens for toast tables, because the main table contents aren't re-inserted with heap_insert(). The fix is simple, add a new heap_insert() flag that prevents logical decoding information from being emitted, and accept during decoding that there might not be tuple data for toast tables. Unfortunately that does not fix pre-existing logical decoding errors. Doing so would require not throwing an error when a filenode cannot be mapped to a relation during decoding, and that seems too likely to hide bugs. If it's crucial to fix decoding for an existing slot, temporarily changing the ERROR in ReorderBufferCommit() to a WARNING appears to be the best fix. Author: Andres Freund Discussion: https://postgr.es/m/20180914021046.oi7dm4ra3ot2g2kt@alap3.anarazel.de Backpatch: 9.4-, where logical decoding was introduced		2018-10-10 13:53:02 -07:00
..
binary.sql
ddl.sql	Revert MERGE patch	2018-04-12 11:22:56 +01:00
decoding_in_xact.sql
decoding_into_rel.sql	Fix crash when logical decoding is invoked from a PL function.	2017-10-06 19:18:58 -04:00
messages.sql
permissions.sql
prepared.sql
replorigin.sql	Fix more user-visible elog() calls.	2017-10-05 07:58:02 -04:00
rewrite.sql	Fix logical decoding error when system table w/ toast is repeatedly rewritten.	2018-10-10 13:53:02 -07:00
slot.sql	Fix logical replication slot initialization	2018-08-01 17:47:15 -04:00
spill.sql
time.sql
toast.sql	Add regression test for wide REPLICA IDENTITY FULL updates.	2017-08-05 14:43:11 -07:00
truncate.sql	Force synchronous commit to be enabled for all test_decoding tests.	2018-10-10 13:53:02 -07:00
xact.sql