postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-21 03:13:05 +08:00

Go to file

Tom Lane cb8962ce8e Further fix ALTER COLUMN TYPE's handling of indexes and index constraints. This patch reverts all the code changes of commit `e76de8861`, which turns out to have been seriously misguided. We can't wait till later to compute the definition string for an index; we must capture that before applying the data type change for any column it depends on, else ruleutils.c will deliverr wrong/misleading results. (This fine point was documented nowhere, of course.) I'd also managed to forget that ATExecAlterColumnType executes once per ALTER COLUMN TYPE clause, not once per statement; which resulted in the code being basically completely broken for any case in which multiple ALTER COLUMN TYPE clauses are applied to a table having non-constraint indexes that must be rebuilt. Through very bad luck, none of the existing test cases nor the ones added by `e76de8861` caught that, but of course it was soon found in the field. The previous patch also had an implicit assumption that if a constraint's index had a dependency on a table column, so would the constraint --- but that isn't actually true, so it didn't fix such cases. Instead of trying to delete unneeded index dependencies later, do the is-there-a-constraint lookup immediately on seeing an index dependency, and switch to remembering the constraint if so. In the unusual case of multiple column dependencies for a constraint index, this will result in duplicate constraint lookups, but that's not that horrible compared to all the other work that happens here. Besides, such cases did not work at all before, so it's hard to argue that they're performance-critical for anyone. Per bug #15865 from Keith Fiske. As before, back-patch to all supported branches. Discussion: https://postgr.es/m/15865-17940eacc8f8b081@postgresql.org		2019-06-24 16:43:05 -04:00
config	configure: Update python search order	2019-01-13 10:25:23 +01:00
contrib	postgres_fdw: Account for triggers in non-direct remote UPDATE planning.	2019-06-13 17:59:12 +09:00
doc	Stamp 10.9.	2019-06-17 17:18:49 -04:00
src	Further fix ALTER COLUMN TYPE's handling of indexes and index constraints.	2019-06-24 16:43:05 -04:00
.dir-locals.el
.gitattributes
.gitignore
aclocal.m4
configure	Stamp 10.9.	2019-06-17 17:18:49 -04:00
configure.in	Stamp 10.9.	2019-06-17 17:18:49 -04:00
COPYRIGHT	Update copyright for 2019	2019-01-02 12:44:25 -05:00
GNUmakefile.in	Process EXTRA_INSTALL serially, during the first temp-install.	2018-12-31 13:57:57 -08:00
HISTORY
Makefile
README
README.git

README

PostgreSQL Database Management System
=====================================

This directory contains the source code distribution of the PostgreSQL
database management system.

PostgreSQL is an advanced object-relational database management system
that supports an extended subset of the SQL standard, including
transactions, foreign keys, subqueries, triggers, user-defined types
and functions.  This distribution also contains C language bindings.

PostgreSQL has many language interfaces, many of which are listed here:

	https://www.postgresql.org/download

See the file INSTALL for instructions on how to build and install
PostgreSQL.  That file also lists supported operating systems and
hardware platforms and contains information regarding any other
software packages that are required to build or run the PostgreSQL
system.  Copyright and license information can be found in the
file COPYRIGHT.  A comprehensive documentation set is included in this
distribution; it can be read as described in the installation
instructions.

The latest version of this software may be obtained at
https://www.postgresql.org/download/.  For more information look at our
web site located at https://www.postgresql.org/.