postgresql

mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-15 08:20:16 +08:00

Go to file

Tom Lane b853eb9718 Improve handling of ereport(ERROR) and elog(ERROR). In commit `71450d7fd6`, we added code to inform suitably-intelligent compilers that ereport() doesn't return if the elevel is ERROR or higher. This patch extends that to elog(), and also fixes a double-evaluation hazard that the previous commit created in ereport(), as well as reducing the emitted code size. The elog() improvement requires the compiler to support __VA_ARGS__, which should be available in just about anything nowadays since it's required by C99. But our minimum language baseline is still C89, so add a configure test for that. The previous commit assumed that ereport's elevel could be evaluated twice, which isn't terribly safe --- there are already counterexamples in xlog.c. On compilers that have __builtin_constant_p, we can use that to protect the second test, since there's no possible optimization gain if the compiler doesn't know the value of elevel. Otherwise, use a local variable inside the macros to prevent double evaluation. The local-variable solution is inferior because (a) it leads to useless code being emitted when elevel isn't constant, and (b) it increases the optimization level needed for the compiler to recognize that subsequent code is unreachable. But it seems better than not teaching non-gcc compilers about unreachability at all. Lastly, if the compiler has __builtin_unreachable(), we can use that instead of abort(), resulting in a noticeable code savings since no function call is actually emitted. However, it seems wise to do this only in non-assert builds. In an assert build, continue to use abort(), so that the behavior will be predictable and debuggable if the "impossible" happens. These changes involve making the ereport and elog macros emit do-while statement blocks not just expressions, which forces small changes in a few call sites. Andres Freund, Tom Lane, Heikki Linnakangas		2013-01-13 18:40:09 -05:00
config	Improve handling of ereport(ERROR) and elog(ERROR).	2013-01-13 18:40:09 -05:00
contrib	Improve handling of ereport(ERROR) and elog(ERROR).	2013-01-13 18:40:09 -05:00
doc	Allow parallel copy/link in pg_upgrade	2013-01-09 08:57:47 -05:00
src	Improve handling of ereport(ERROR) and elog(ERROR).	2013-01-13 18:40:09 -05:00
.gitignore
aclocal.m4
configure	Improve handling of ereport(ERROR) and elog(ERROR).	2013-01-13 18:40:09 -05:00
configure.in	Improve handling of ereport(ERROR) and elog(ERROR).	2013-01-13 18:40:09 -05:00
COPYRIGHT	Update copyrights for 2013	2013-01-01 17:15:01 -05:00
GNUmakefile.in
Makefile
README
README.git

README

PostgreSQL Database Management System
=====================================

This directory contains the source code distribution of the PostgreSQL
database management system.

PostgreSQL is an advanced object-relational database management system
that supports an extended subset of the SQL standard, including
transactions, foreign keys, subqueries, triggers, user-defined types
and functions.  This distribution also contains C language bindings.

PostgreSQL has many language interfaces, many of which are listed here:

	http://www.postgresql.org/download

See the file INSTALL for instructions on how to build and install
PostgreSQL.  That file also lists supported operating systems and
hardware platforms and contains information regarding any other
software packages that are required to build or run the PostgreSQL
system.  Changes between all PostgreSQL releases are recorded in the
file HISTORY.  Copyright and license information can be found in the
file COPYRIGHT.  A comprehensive documentation set is included in this
distribution; it can be read as described in the installation
instructions.

The latest version of this software may be obtained at
http://www.postgresql.org/download/.  For more information look at our
web site located at http://www.postgresql.org/.