Tom Lane fedc97cdfd Remove ruleutils.c's special case for BIT [VARYING] literals. ... Up to now, get_const_expr() insisted on prefixing BIT and VARBIT literals with 'B'. That's not really necessary, because we always append explicit-cast syntax to identify the constant's type. Moreover, it's subtly wrong for VARBIT, because the parser will interpret B'...' as '...'::"bit"; see make_const() which explicitly assigns type BITOID for a T_BitString literal. So what had been a simple VARBIT literal is reconstructed as ('...'::"bit")::varbit, which is not the same thing, at least not before constant folding. This results in odd differences after dump/restore, as complained of by the patch submitter, and it could result in actual failures in partitioning or inheritance DDL operations (see commit 542320c2b, which repaired similar misbehaviors for some other data types). Fixing it is pretty easy: just remove the special case and let the default code path handle these types. We could have kept the special case for BIT only, but there seems little point in that. Like the previous patch, I judge that back-patching this into stable branches wouldn't be a good idea. However, it seems not quite too late for v11, so let's fix it there. Paul Guo, reviewed by Davy Machado and John Naylor, minor adjustments by me Discussion: https://postgr.es/m/CABQrizdTra=2JEqA6+Ms1D1k1Kqw+aiBBhC9TreuZRX2JzxLAA@mail.gmail.com		2018-09-11 16:32:25 -04:00
..
bit.out	Remove ruleutils.c's special case for BIT [VARYING] literals.	2018-09-11 16:32:25 -04:00
bytea.out
cash.out
char_1.out
char.out
cidr.out
date.out
enum.out	Add btree_gist support for enum types.	2017-03-21 10:43:27 -04:00
float4.out
float8.out
inet.out	Fix IOS planning when only some index columns can return an attribute.	2018-03-01 15:35:03 -05:00
init.out	Test all contrib-created operator classes with amvalidate.	2016-11-29 15:05:22 -05:00
int2.out
int4.out
int8.out
interval.out
macaddr8.out	Add support for EUI-64 MAC addresses as macaddr8	2017-03-15 11:16:25 -04:00
macaddr.out
not_equal.out
numeric.out
oid.out
text_1.out
text.out
time.out
timestamp.out
timestamptz.out
timetz.out
uuid.out	Add uuid to the set of types supported by contrib/btree_gist.	2016-11-29 14:08:34 -05:00
varbit.out	Remove ruleutils.c's special case for BIT [VARYING] literals.	2018-09-11 16:32:25 -04:00
varchar_1.out
varchar.out