postgresql/contrib/dblink
Tom Lane f6f75539d2 Prevent accidental linking of system-supplied copies of libpq.so etc.
Back-patch commit dddfc4cb2, which broke LDFLAGS and related Makefile
variables into two parts, one for within-build-tree library references and
one for external libraries, to ensure that the order of -L flags has all
of the former before all of the latter.  This turns out to fix a problem
recently noted on buildfarm member peripatus, that we attempted to
incorporate code from libpgport.a into a shared library.  That will fail on
platforms that are sticky about putting non-PIC code into shared libraries.
(It's quite surprising we hadn't seen such failures before, since the code
in question has been like that for a long time.)

I think that peripatus' problem could have been fixed with just a subset
of this patch; but since the previous issue of accidentally linking to the
wrong copy of a Postgres shlib seems likely to bite people in the field,
let's just back-patch the whole change.  Now that commit dddfc4cb2 has
survived some beta testing, I'm less afraid to back-patch it than I was
at the time.

This also fixes undesired inclusion of "-DFRONTEND" in pg_config's CPPFLAGS
output (in 9.6 and up) and undesired inclusion of "-L../../src/common" in
its LDFLAGS output (in all supported branches).

Back-patch to v10 and older branches; this is already in v11.

Discussion: https://postgr.es/m/20180704234304.bq2dxispefl65odz@ler-imac.local
2018-07-09 17:23:32 -04:00
..
expected Lock down regression testing temporary clusters on Windows. 2014-12-17 22:48:46 -05:00
input Diagnose incompatible OpenLDAP versions during build and test. 2014-07-22 11:01:41 -04:00
output Diagnose incompatible OpenLDAP versions during build and test. 2014-07-22 11:01:41 -04:00
sql Lock down regression testing temporary clusters on Windows. 2014-12-17 22:48:46 -05:00
.gitignore Support "make check" in contrib 2011-04-25 22:27:11 +03:00
dblink--1.0--1.1.sql Backpatch: Fix typo in update scripts for some contrib modules. 2014-08-25 18:30:46 +02:00
dblink--1.1.sql Create an improved FDW option validator function for contrib/dblink. 2012-10-10 16:53:08 -04:00
dblink--unpackaged--1.0.sql Fix typos in some error messages thrown by extension scripts when fed to psql. 2014-08-25 18:30:46 +02:00
dblink.c Fix ancient connection leak in dblink 2017-03-11 13:33:22 -08:00
dblink.control Create an improved FDW option validator function for contrib/dblink. 2012-10-10 16:53:08 -04:00
dblink.h Update copyrights for 2013 2013-01-01 17:15:01 -05:00
Makefile Prevent accidental linking of system-supplied copies of libpq.so etc. 2018-07-09 17:23:32 -04:00
pg_service.conf Diagnose incompatible OpenLDAP versions during build and test. 2014-07-22 11:01:41 -04:00