mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-27 07:21:09 +08:00
Code Issues Packages Projects Releases Wiki Activity
9352d5cf12
postgresql/contrib/pg_walinspect
History
Jeff Davis d9fbb88629 Use correct LSN for error reporting in pg_walinspect 
Usage of ReadNextXLogRecord()'s first_record parameter for error
reporting isn't always correct. For instance, in GetWALRecordsInfo()
and GetWalStats(), we're reading multiple records, and first_record
is always passed as the LSN of the first record which is then used
for error reporting for later WAL record read failures. This isn't
correct.

The correct parameter to use for error reports in case of WAL
reading failures is xlogreader->EndRecPtr. This change fixes it.

While on it, removed an unnecessary Assert in pg_walinspect code.

Reported-by: Robert Haas
Author: Bharath Rupireddy
Reviewed-by: Robert Haas
Discussion: https://www.postgresql.org/message-id/CA%2BTgmoZAOGzPUifrcZRjFZ2vbtcw3mp-mN6UgEoEcQg6bY3OVg%40mail.gmail.com
Backpatch-through: 15
2022-08-18 14:23:30 -07:00
..
expected Fix buildfarm failures in pg_walinspect tests. 2022-04-08 03:21:12 -07:00
sql Fix buildfarm failures in pg_walinspect tests. 2022-04-08 03:21:12 -07:00
.gitignore
Makefile Fix buildfarm failures in pg_walinspect tests. 2022-04-08 03:21:12 -07:00
pg_walinspect--1.0.sql
pg_walinspect.c Use correct LSN for error reporting in pg_walinspect 2022-08-18 14:23:30 -07:00
pg_walinspect.control
walinspect.conf Fix buildfarm failures in pg_walinspect tests. 2022-04-08 03:21:12 -07:00