Go to file
David Rowley 6c3b697b19 Fix List memory issue in transformColumnDefinition
When calling generateSerialExtraStmts(), we would pass in the
constraint->options.  In some cases, generateSerialExtraStmts() would
modify the referenced List to remove elements from it, but doing so is
invalid without assigning the list back to all variables that point to it.
In the particular reported problem case, the List became empty, in which
cases it became NIL, but the passed in constraint->options didn't get to
find out about that and was left pointing to free'd memory.

To fix this, just perform a list_copy() inside generateSerialExtraStmts().
We could just do a list_copy() just before we perform the delete from the
list, however, that seems less robust.  Let's make sure the generated
CreateSeqStmt gets a completely different copy of the list to be safe.

Bug: #17879
Reported-by: Fei Changhong
Diagnosed-by: Fei Changhong
Discussion: https://postgr.es/m/17879-b7dfb5debee58ff5@postgresql.org
Backpatch-through: 11, all supported versions
2023-03-31 12:13:05 +13:00
config
contrib Show record information in pg_get_wal_block_info. 2023-03-30 12:26:12 -07:00
doc Show record information in pg_get_wal_block_info. 2023-03-30 12:26:12 -07:00
src Fix List memory issue in transformColumnDefinition 2023-03-31 12:13:05 +13:00
.cirrus.yml Support connection load balancing in libpq 2023-03-29 21:53:38 +02:00
.dir-locals.el
.editorconfig
.git-blame-ignore-revs Add b6dfee28 to .git-blame-ignore-revs 2023-03-09 19:26:03 +09:00
.gitattributes gitattributes: Ignore imported pg_bsd_indent code for whitespace checks 2023-02-22 09:00:28 +01:00
.gitignore
aclocal.m4
configure libpq: Add sslcertmode option to control client certificates 2023-03-24 13:34:26 +09:00
configure.ac libpq: Add sslcertmode option to control client certificates 2023-03-24 13:34:26 +09:00
COPYRIGHT
GNUmakefile.in
HISTORY
Makefile
meson_options.txt meson: Make auto the default of the ssl option 2023-03-13 07:04:11 +01:00
meson.build meson: Change default buildtype to debugoptimized 2023-03-29 09:48:18 +02:00
README
README.git

PostgreSQL Database Management System
=====================================

This directory contains the source code distribution of the PostgreSQL
database management system.

PostgreSQL is an advanced object-relational database management system
that supports an extended subset of the SQL standard, including
transactions, foreign keys, subqueries, triggers, user-defined types
and functions.  This distribution also contains C language bindings.

PostgreSQL has many language interfaces, many of which are listed here:

	https://www.postgresql.org/download/

See the file INSTALL for instructions on how to build and install
PostgreSQL.  That file also lists supported operating systems and
hardware platforms and contains information regarding any other
software packages that are required to build or run the PostgreSQL
system.  Copyright and license information can be found in the
file COPYRIGHT.  A comprehensive documentation set is included in this
distribution; it can be read as described in the installation
instructions.

The latest version of this software may be obtained at
https://www.postgresql.org/download/.  For more information look at our
web site located at https://www.postgresql.org/.