Fujii Masao 5fedf7417b Improve HINT message that FDW reports when there are no valid options. ... The foreign data wrapper's validator function provides a HINT message with list of valid options for the object specified in CREATE or ALTER command, when the option given in the command is invalid. Previously postgresql_fdw_validator() and the validator functions for postgres_fdw and dblink_fdw worked in that way even there were no valid options in the object, which could lead to the HINT message with empty list (because there were no valid options). For example, ALTER FOREIGN DATA WRAPPER postgres_fdw OPTIONS (format 'csv') reported the following ERROR and HINT messages. This behavior was confusing. ERROR: invalid option "format" HINT: Valid options in this context are: There is no such issue in file_fdw. The validator function for file_fdw reports the HINT message "There are no valid options in this context." instead in that case. This commit improves postgresql_fdw_validator() and the validator functions for postgres_fdw and dblink_fdw so that they do likewise. For example, this change causes the above ALTER FOREIGN DATA WRAPPER command to report the following messages. ERROR: invalid option "nonexistent" HINT: There are no valid options in this context. Author: Kosei Masumura Reviewed-by: Bharath Rupireddy, Fujii Masao Discussion: https://postgr.es/m/557d06cebe19081bfcc83ee2affc98d3@oss.nttdata.com		2021-10-27 00:46:52 +09:00
..
expected	Improve HINT message that FDW reports when there are no valid options.	2021-10-27 00:46:52 +09:00
input
output
sql	Improve HINT message that FDW reports when there are no valid options.	2021-10-27 00:46:52 +09:00
.gitignore
dblink--1.0--1.1.sql
dblink--1.1--1.2.sql
dblink--1.2.sql
dblink.c	Improve HINT message that FDW reports when there are no valid options.	2021-10-27 00:46:52 +09:00
dblink.control
Makefile
pg_service.conf