postgresql/contrib
Tom Lane fedc97cdfd Remove ruleutils.c's special case for BIT [VARYING] literals.
Up to now, get_const_expr() insisted on prefixing BIT and VARBIT
literals with 'B'.  That's not really necessary, because we always
append explicit-cast syntax to identify the constant's type.
Moreover, it's subtly wrong for VARBIT, because the parser will
interpret B'...' as '...'::"bit"; see make_const() which explicitly
assigns type BITOID for a T_BitString literal.  So what had been
a simple VARBIT literal is reconstructed as ('...'::"bit")::varbit,
which is not the same thing, at least not before constant folding.
This results in odd differences after dump/restore, as complained
of by the patch submitter, and it could result in actual failures in
partitioning or inheritance DDL operations (see commit 542320c2b,
which repaired similar misbehaviors for some other data types).

Fixing it is pretty easy: just remove the special case and let the
default code path handle these types.  We could have kept the special
case for BIT only, but there seems little point in that.

Like the previous patch, I judge that back-patching this into stable
branches wouldn't be a good idea.  However, it seems not quite too
late for v11, so let's fix it there.

Paul Guo, reviewed by Davy Machado and John Naylor, minor adjustments
by me

Discussion: https://postgr.es/m/CABQrizdTra=2JEqA6+Ms1D1k1Kqw+aiBBhC9TreuZRX2JzxLAA@mail.gmail.com
2018-09-11 16:32:25 -04:00
..
adminpack
amcheck
auth_delay
auto_explain Provide a log_level setting for auto_explain 2018-07-31 08:03:57 -04:00
bloom Avoid using potentially-under-aligned page buffers. 2018-09-01 15:27:17 -04:00
btree_gin Provide separate header file for built-in float types 2018-07-29 03:30:48 +02:00
btree_gist Remove ruleutils.c's special case for BIT [VARYING] literals. 2018-09-11 16:32:25 -04:00
citext Fix hashjoin costing mistake introduced with inner_unique optimization. 2018-07-14 11:59:12 -04:00
cube Enforce cube dimension limit in all cube construction functions 2018-08-31 20:24:48 +03:00
dblink Deduplicate "invalid input syntax" messages for various types. 2018-07-22 14:58:01 -07:00
dict_int
dict_xsyn
earthdistance Fix earthdistance test suite function name typo. 2018-07-29 12:02:07 -07:00
file_fdw
fuzzystrmatch Replace search.cpan.org with metacpan.org 2018-06-29 22:02:20 +09:00
hstore Provide for contrib and pgxs modules to install include files. 2018-07-31 20:07:39 +01:00
hstore_plperl
hstore_plpython
intagg
intarray Fix yet more problems with incorrectly-constructed zero-length arrays. 2018-07-09 14:28:04 -04:00
isn Provide for contrib and pgxs modules to install include files. 2018-07-31 20:07:39 +01:00
jsonb_plperl Rethink how to get float.h in old Windows API for isnan/isinf 2018-07-11 09:11:48 -04:00
jsonb_plpython
lo
ltree Provide for contrib and pgxs modules to install include files. 2018-07-31 20:07:39 +01:00
ltree_plpython
oid2name Clean up after TAP tests in oid2name and vacuumlo. 2018-09-04 10:52:01 -04:00
pageinspect Make error message of pageinspect more consistent for raw page inputs 2018-07-29 23:50:35 +09:00
passwordcheck
pg_buffercache
pg_freespacemap
pg_prewarm Improve some error message strings and errcodes 2018-09-04 11:06:04 -07:00
pg_standby Avoid using potentially-under-aligned page buffers. 2018-09-01 15:27:17 -04:00
pg_stat_statements Make more consistent some error messages for file-related operations 2018-07-23 09:19:12 +09:00
pg_trgm
pg_visibility
pgcrypto Make capitalization of term "OpenSSL" more consistent 2018-06-29 09:45:44 +09:00
pgrowlocks
pgstattuple
postgres_fdw Disable support for partitionwise joins in problematic cases. 2018-08-31 20:34:06 +09:00
seg Provide for contrib and pgxs modules to install include files. 2018-07-31 20:07:39 +01:00
sepgsql
spi Hand code string to integer conversion for performance. 2018-07-22 14:58:23 -07:00
sslinfo
start-scripts
tablefunc
tcn
test_decoding Fix logical replication slot initialization 2018-08-01 17:47:15 -04:00
tsm_system_rows
tsm_system_time Rethink how to get float.h in old Windows API for isnan/isinf 2018-07-11 09:11:48 -04:00
unaccent Make contrib/unaccent's unaccent() function work when not in search path. 2018-09-06 10:49:45 -04:00
uuid-ossp
vacuumlo Clean up after TAP tests in oid2name and vacuumlo. 2018-09-04 10:52:01 -04:00
xml2
contrib-global.mk
Makefile
README

The PostgreSQL contrib tree
---------------------------

This subtree contains porting tools, analysis utilities, and plug-in
features that are not part of the core PostgreSQL system, mainly
because they address a limited audience or are too experimental to be
part of the main source tree.  This does not preclude their
usefulness.

User documentation for each module appears in the main SGML
documentation.

When building from the source distribution, these modules are not
built automatically, unless you build the "world" target.  You can
also build and install them all by running "make all" and "make
install" in this directory; or to build and install just one selected
module, do the same in that module's subdirectory.

Some directories supply new user-defined functions, operators, or
types.  To make use of one of these modules, after you have installed
the code you need to register the new SQL objects in the database
system by executing a CREATE EXTENSION command.  In a fresh database,
you can simply do

    CREATE EXTENSION module_name;

See the PostgreSQL documentation for more information about this
procedure.