mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-12-21 08:29:39 +08:00
37507962c3
connectby() didn't adequately check that the constructed SQL query returns
what it's expected to; in fact, since commit 08c33c426b it wasn't
checking that at all. This could result in a null-pointer-dereference
crash if the constructed query returns only one column instead of the
expected two. Less excitingly, it could also result in surprising data
conversion failures if the constructed query returned values that were
not I/O-conversion-compatible with the types specified by the query
calling connectby().
In all branches, insist that the query return at least two columns;
this seems like a minimal sanity check that can't break any reasonable
use-cases.
In HEAD, insist that the constructed query return the types specified by
the outer query, including checking for typmod incompatibility, which the
code never did even before it got broken. This is to hide the fact that
the implementation does a conversion to text and back; someday we might
want to improve that.
In back branches, leave that alone, since adding a type check in a minor
release is more likely to break things than make people happy. Type
inconsistencies will continue to work so long as the actual type and
declared type are I/O representation compatible, and otherwise will fail
the same way they used to.
Also, in all branches, be on guard for NULL results from the constructed
query, which formerly would cause null-pointer dereference crashes.
We now print the row with the NULL but don't recurse down from it.
In passing, get rid of the rather pointless idea that
build_tuplestore_recursively() should return the same tuplestore that's
passed to it.
Michael Paquier, adjusted somewhat by me
207 lines
11 KiB
SQL
207 lines
11 KiB
SQL
CREATE EXTENSION tablefunc;
|
|
|
|
--
|
|
-- normal_rand()
|
|
-- no easy way to do this for regression testing
|
|
--
|
|
SELECT avg(normal_rand)::int FROM normal_rand(100, 250, 0.2);
|
|
|
|
--
|
|
-- crosstab()
|
|
--
|
|
CREATE TABLE ct(id int, rowclass text, rowid text, attribute text, val text);
|
|
\copy ct from 'data/ct.data'
|
|
|
|
SELECT * FROM crosstab2('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' and (attribute = ''att2'' or attribute = ''att3'') ORDER BY 1,2;');
|
|
SELECT * FROM crosstab3('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' and (attribute = ''att2'' or attribute = ''att3'') ORDER BY 1,2;');
|
|
SELECT * FROM crosstab4('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' and (attribute = ''att2'' or attribute = ''att3'') ORDER BY 1,2;');
|
|
|
|
SELECT * FROM crosstab2('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;');
|
|
SELECT * FROM crosstab3('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;');
|
|
SELECT * FROM crosstab4('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;');
|
|
|
|
SELECT * FROM crosstab2('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' and (attribute = ''att1'' or attribute = ''att2'') ORDER BY 1,2;');
|
|
SELECT * FROM crosstab3('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' and (attribute = ''att1'' or attribute = ''att2'') ORDER BY 1,2;');
|
|
SELECT * FROM crosstab4('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' and (attribute = ''att1'' or attribute = ''att2'') ORDER BY 1,2;');
|
|
|
|
SELECT * FROM crosstab2('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' ORDER BY 1,2;');
|
|
SELECT * FROM crosstab3('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' ORDER BY 1,2;');
|
|
SELECT * FROM crosstab4('SELECT rowid, attribute, val FROM ct where rowclass = ''group2'' ORDER BY 1,2;');
|
|
|
|
SELECT * FROM crosstab('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;') AS c(rowid text, att1 text, att2 text);
|
|
SELECT * FROM crosstab('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;') AS c(rowid text, att1 text, att2 text, att3 text);
|
|
SELECT * FROM crosstab('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;') AS c(rowid text, att1 text, att2 text, att3 text, att4 text);
|
|
|
|
-- check it works with OUT parameters, too
|
|
|
|
CREATE FUNCTION crosstab_out(text,
|
|
OUT rowid text, OUT att1 text, OUT att2 text, OUT att3 text)
|
|
RETURNS setof record
|
|
AS '$libdir/tablefunc','crosstab'
|
|
LANGUAGE C STABLE STRICT;
|
|
|
|
SELECT * FROM crosstab_out('SELECT rowid, attribute, val FROM ct where rowclass = ''group1'' ORDER BY 1,2;');
|
|
|
|
--
|
|
-- hash based crosstab
|
|
--
|
|
create table cth(id serial, rowid text, rowdt timestamp, attribute text, val text);
|
|
insert into cth values(DEFAULT,'test1','01 March 2003','temperature','42');
|
|
insert into cth values(DEFAULT,'test1','01 March 2003','test_result','PASS');
|
|
-- the next line is intentionally left commented and is therefore a "missing" attribute
|
|
-- insert into cth values(DEFAULT,'test1','01 March 2003','test_startdate','28 February 2003');
|
|
insert into cth values(DEFAULT,'test1','01 March 2003','volts','2.6987');
|
|
insert into cth values(DEFAULT,'test2','02 March 2003','temperature','53');
|
|
insert into cth values(DEFAULT,'test2','02 March 2003','test_result','FAIL');
|
|
insert into cth values(DEFAULT,'test2','02 March 2003','test_startdate','01 March 2003');
|
|
insert into cth values(DEFAULT,'test2','02 March 2003','volts','3.1234');
|
|
-- next group tests for NULL rowids
|
|
insert into cth values(DEFAULT,NULL,'25 October 2007','temperature','57');
|
|
insert into cth values(DEFAULT,NULL,'25 October 2007','test_result','PASS');
|
|
insert into cth values(DEFAULT,NULL,'25 October 2007','test_startdate','24 October 2007');
|
|
insert into cth values(DEFAULT,NULL,'25 October 2007','volts','1.41234');
|
|
|
|
-- return attributes as plain text
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature text, test_result text, test_startdate text, volts text);
|
|
|
|
-- this time without rowdt
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1')
|
|
AS c(rowid text, temperature text, test_result text, test_startdate text, volts text);
|
|
|
|
-- convert attributes to specific datatypes
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature int4, test_result text, test_startdate timestamp, volts float8);
|
|
|
|
-- source query and category query out of sync
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth WHERE attribute IN (''temperature'',''test_result'',''test_startdate'') ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature int4, test_result text, test_startdate timestamp);
|
|
|
|
-- if category query generates no rows, get expected error
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth WHERE attribute = ''a'' ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature int4, test_result text, test_startdate timestamp, volts float8);
|
|
|
|
-- if category query generates more than one column, get expected error
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT rowdt, attribute FROM cth ORDER BY 2')
|
|
AS c(rowid text, rowdt timestamp, temperature int4, test_result text, test_startdate timestamp, volts float8);
|
|
|
|
-- if source query returns zero rows, get zero rows returned
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth WHERE false ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature text, test_result text, test_startdate text, volts text);
|
|
|
|
-- if source query returns zero rows, get zero rows returned even if category query generates no rows
|
|
SELECT * FROM crosstab(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth WHERE false ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth WHERE false ORDER BY 1')
|
|
AS c(rowid text, rowdt timestamp, temperature text, test_result text, test_startdate text, volts text);
|
|
|
|
-- check it works with a named result rowtype
|
|
|
|
create type my_crosstab_result as (
|
|
rowid text, rowdt timestamp,
|
|
temperature int4, test_result text, test_startdate timestamp, volts float8);
|
|
|
|
CREATE FUNCTION crosstab_named(text, text)
|
|
RETURNS setof my_crosstab_result
|
|
AS '$libdir/tablefunc','crosstab_hash'
|
|
LANGUAGE C STABLE STRICT;
|
|
|
|
SELECT * FROM crosstab_named(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1');
|
|
|
|
-- check it works with OUT parameters
|
|
|
|
CREATE FUNCTION crosstab_out(text, text,
|
|
OUT rowid text, OUT rowdt timestamp,
|
|
OUT temperature int4, OUT test_result text,
|
|
OUT test_startdate timestamp, OUT volts float8)
|
|
RETURNS setof record
|
|
AS '$libdir/tablefunc','crosstab_hash'
|
|
LANGUAGE C STABLE STRICT;
|
|
|
|
SELECT * FROM crosstab_out(
|
|
'SELECT rowid, rowdt, attribute, val FROM cth ORDER BY 1',
|
|
'SELECT DISTINCT attribute FROM cth ORDER BY 1');
|
|
|
|
--
|
|
-- connectby
|
|
--
|
|
|
|
-- test connectby with text based hierarchy
|
|
CREATE TABLE connectby_text(keyid text, parent_keyid text, pos int);
|
|
\copy connectby_text from 'data/connectby_text.data'
|
|
|
|
-- with branch, without orderby
|
|
SELECT * FROM connectby('connectby_text', 'keyid', 'parent_keyid', 'row2', 0, '~') AS t(keyid text, parent_keyid text, level int, branch text);
|
|
|
|
-- without branch, without orderby
|
|
SELECT * FROM connectby('connectby_text', 'keyid', 'parent_keyid', 'row2', 0) AS t(keyid text, parent_keyid text, level int);
|
|
|
|
-- with branch, with orderby
|
|
SELECT * FROM connectby('connectby_text', 'keyid', 'parent_keyid', 'pos', 'row2', 0, '~') AS t(keyid text, parent_keyid text, level int, branch text, pos int) ORDER BY t.pos;
|
|
|
|
-- without branch, with orderby
|
|
SELECT * FROM connectby('connectby_text', 'keyid', 'parent_keyid', 'pos', 'row2', 0) AS t(keyid text, parent_keyid text, level int, pos int) ORDER BY t.pos;
|
|
|
|
-- test connectby with int based hierarchy
|
|
CREATE TABLE connectby_int(keyid int, parent_keyid int);
|
|
\copy connectby_int from 'data/connectby_int.data'
|
|
|
|
-- with branch
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~') AS t(keyid int, parent_keyid int, level int, branch text);
|
|
|
|
-- without branch
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0) AS t(keyid int, parent_keyid int, level int);
|
|
|
|
-- recursion detection
|
|
INSERT INTO connectby_int VALUES(10,9);
|
|
INSERT INTO connectby_int VALUES(11,10);
|
|
INSERT INTO connectby_int VALUES(9,11);
|
|
|
|
-- should fail due to infinite recursion
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~') AS t(keyid int, parent_keyid int, level int, branch text);
|
|
|
|
-- infinite recursion failure avoided by depth limit
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 4, '~') AS t(keyid int, parent_keyid int, level int, branch text);
|
|
|
|
-- should fail as first two columns must have the same type
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~') AS t(keyid text, parent_keyid int, level int, branch text);
|
|
|
|
-- should fail as key field datatype should match return datatype
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '2', 0, '~') AS t(keyid float8, parent_keyid float8, level int, branch text);
|
|
|
|
-- tests for values using custom queries
|
|
-- query with one column - failed
|
|
SELECT * FROM connectby('connectby_int', '1; --', 'parent_keyid', '2', 0) AS t(keyid int, parent_keyid int, level int);
|
|
-- query with two columns first value as NULL
|
|
SELECT * FROM connectby('connectby_int', 'NULL::int, 1::int; --', 'parent_keyid', '2', 0) AS t(keyid int, parent_keyid int, level int);
|
|
-- query with two columns second value as NULL
|
|
SELECT * FROM connectby('connectby_int', '1::int, NULL::int; --', 'parent_keyid', '2', 0) AS t(keyid int, parent_keyid int, level int);
|
|
-- query with two columns, both values as NULL
|
|
SELECT * FROM connectby('connectby_int', 'NULL::int, NULL::int; --', 'parent_keyid', '2', 0) AS t(keyid int, parent_keyid int, level int);
|
|
|
|
-- test for falsely detected recursion
|
|
DROP TABLE connectby_int;
|
|
CREATE TABLE connectby_int(keyid int, parent_keyid int);
|
|
INSERT INTO connectby_int VALUES(11,NULL);
|
|
INSERT INTO connectby_int VALUES(10,11);
|
|
INSERT INTO connectby_int VALUES(111,11);
|
|
INSERT INTO connectby_int VALUES(1,111);
|
|
-- this should not fail due to recursion detection
|
|
SELECT * FROM connectby('connectby_int', 'keyid', 'parent_keyid', '11', 0, '-') AS t(keyid int, parent_keyid int, level int, branch text);
|