mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-12-27 08:39:28 +08:00
0ac5ad5134
This patch introduces two additional lock modes for tuples: "SELECT FOR KEY SHARE" and "SELECT FOR NO KEY UPDATE". These don't block each other, in contrast with already existing "SELECT FOR SHARE" and "SELECT FOR UPDATE". UPDATE commands that do not modify the values stored in the columns that are part of the key of the tuple now grab a SELECT FOR NO KEY UPDATE lock on the tuple, allowing them to proceed concurrently with tuple locks of the FOR KEY SHARE variety. Foreign key triggers now use FOR KEY SHARE instead of FOR SHARE; this means the concurrency improvement applies to them, which is the whole point of this patch. The added tuple lock semantics require some rejiggering of the multixact module, so that the locking level that each transaction is holding can be stored alongside its Xid. Also, multixacts now need to persist across server restarts and crashes, because they can now represent not only tuple locks, but also tuple updates. This means we need more careful tracking of lifetime of pg_multixact SLRU files; since they now persist longer, we require more infrastructure to figure out when they can be removed. pg_upgrade also needs to be careful to copy pg_multixact files over from the old server to the new, or at least part of multixact.c state, depending on the versions of the old and new servers. Tuple time qualification rules (HeapTupleSatisfies routines) need to be careful not to consider tuples with the "is multi" infomask bit set as being only locked; they might need to look up MultiXact values (i.e. possibly do pg_multixact I/O) to find out the Xid that updated a tuple, whereas they previously were assured to only use information readily available from the tuple header. This is considered acceptable, because the extra I/O would involve cases that would previously cause some commands to block waiting for concurrent transactions to finish. Another important change is the fact that locking tuples that have previously been updated causes the future versions to be marked as locked, too; this is essential for correctness of foreign key checks. This causes additional WAL-logging, also (there was previously a single WAL record for a locked tuple; now there are as many as updated copies of the tuple there exist.) With all this in place, contention related to tuples being checked by foreign key rules should be much reduced. As a bonus, the old behavior that a subtransaction grabbing a stronger tuple lock than the parent (sub)transaction held on a given tuple and later aborting caused the weaker lock to be lost, has been fixed. Many new spec files were added for isolation tester framework, to ensure overall behavior is sane. There's probably room for several more tests. There were several reviewers of this patch; in particular, Noah Misch and Andres Freund spent considerable time in it. Original idea for the patch came from Simon Riggs, after a problem report by Joel Jacobson. Most code is from me, with contributions from Marti Raudsepp, Alexander Shulgin, Noah Misch and Andres Freund. This patch was discussed in several pgsql-hackers threads; the most important start at the following message-ids: AANLkTimo9XVcEzfiBR-ut3KVNDkjm2Vxh+t8kAmWjPuv@mail.gmail.com 1290721684-sup-3951@alvh.no-ip.org 1294953201-sup-2099@alvh.no-ip.org 1320343602-sup-2290@alvh.no-ip.org 1339690386-sup-8927@alvh.no-ip.org 4FE5FF020200002500048A3D@gw.wicourts.gov 4FEAB90A0200002500048B7D@gw.wicourts.gov
260 lines
10 KiB
Plaintext
260 lines
10 KiB
Plaintext
--
|
|
-- Test foreign-data wrapper file_fdw.
|
|
--
|
|
-- Clean up in case a prior regression run failed
|
|
SET client_min_messages TO 'error';
|
|
DROP ROLE IF EXISTS file_fdw_superuser, file_fdw_user, no_priv_user;
|
|
RESET client_min_messages;
|
|
CREATE ROLE file_fdw_superuser LOGIN SUPERUSER; -- is a superuser
|
|
CREATE ROLE file_fdw_user LOGIN; -- has priv and user mapping
|
|
CREATE ROLE no_priv_user LOGIN; -- has priv but no user mapping
|
|
-- Install file_fdw
|
|
CREATE EXTENSION file_fdw;
|
|
-- file_fdw_superuser owns fdw-related objects
|
|
SET ROLE file_fdw_superuser;
|
|
CREATE SERVER file_server FOREIGN DATA WRAPPER file_fdw;
|
|
-- privilege tests
|
|
SET ROLE file_fdw_user;
|
|
CREATE FOREIGN DATA WRAPPER file_fdw2 HANDLER file_fdw_handler VALIDATOR file_fdw_validator; -- ERROR
|
|
ERROR: permission denied to create foreign-data wrapper "file_fdw2"
|
|
HINT: Must be superuser to create a foreign-data wrapper.
|
|
CREATE SERVER file_server2 FOREIGN DATA WRAPPER file_fdw; -- ERROR
|
|
ERROR: permission denied for foreign-data wrapper file_fdw
|
|
CREATE USER MAPPING FOR file_fdw_user SERVER file_server; -- ERROR
|
|
ERROR: permission denied for foreign server file_server
|
|
SET ROLE file_fdw_superuser;
|
|
GRANT USAGE ON FOREIGN SERVER file_server TO file_fdw_user;
|
|
SET ROLE file_fdw_user;
|
|
CREATE USER MAPPING FOR file_fdw_user SERVER file_server;
|
|
-- create user mappings and grant privilege to test users
|
|
SET ROLE file_fdw_superuser;
|
|
CREATE USER MAPPING FOR file_fdw_superuser SERVER file_server;
|
|
CREATE USER MAPPING FOR no_priv_user SERVER file_server;
|
|
-- validator tests
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'xml'); -- ERROR
|
|
ERROR: COPY format "xml" not recognized
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', header 'true'); -- ERROR
|
|
ERROR: COPY HEADER available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', quote ':'); -- ERROR
|
|
ERROR: COPY quote available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', escape ':'); -- ERROR
|
|
ERROR: COPY escape available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'binary', header 'true'); -- ERROR
|
|
ERROR: COPY HEADER available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'binary', quote ':'); -- ERROR
|
|
ERROR: COPY quote available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'binary', escape ':'); -- ERROR
|
|
ERROR: COPY escape available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', delimiter 'a'); -- ERROR
|
|
ERROR: COPY delimiter cannot be "a"
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', escape '-'); -- ERROR
|
|
ERROR: COPY escape available only in CSV mode
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', quote '-', null '=-='); -- ERROR
|
|
ERROR: CSV quote character must not appear in the NULL specification
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', delimiter '-', null '=-='); -- ERROR
|
|
ERROR: COPY delimiter must not appear in the NULL specification
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', delimiter '-', quote '-'); -- ERROR
|
|
ERROR: COPY delimiter and quote must be different
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', delimiter '---'); -- ERROR
|
|
ERROR: COPY delimiter must be a single one-byte character
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', quote '---'); -- ERROR
|
|
ERROR: COPY quote must be a single one-byte character
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', escape '---'); -- ERROR
|
|
ERROR: COPY escape must be a single one-byte character
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', delimiter '\'); -- ERROR
|
|
ERROR: COPY delimiter cannot be "\"
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', delimiter '.'); -- ERROR
|
|
ERROR: COPY delimiter cannot be "."
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', delimiter '1'); -- ERROR
|
|
ERROR: COPY delimiter cannot be "1"
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'text', delimiter 'a'); -- ERROR
|
|
ERROR: COPY delimiter cannot be "a"
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', delimiter '
|
|
'); -- ERROR
|
|
ERROR: COPY delimiter cannot be newline or carriage return
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (format 'csv', null '
|
|
'); -- ERROR
|
|
ERROR: COPY null representation cannot use newline or carriage return
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server; -- ERROR
|
|
ERROR: filename is required for file_fdw foreign tables
|
|
CREATE FOREIGN TABLE agg_text (
|
|
a int2,
|
|
b float4
|
|
) SERVER file_server
|
|
OPTIONS (format 'text', filename '@abs_srcdir@/data/agg.data', delimiter ' ', null '\N');
|
|
GRANT SELECT ON agg_text TO file_fdw_user;
|
|
CREATE FOREIGN TABLE agg_csv (
|
|
a int2,
|
|
b float4
|
|
) SERVER file_server
|
|
OPTIONS (format 'csv', filename '@abs_srcdir@/data/agg.csv', header 'true', delimiter ';', quote '@', escape '"', null '');
|
|
CREATE FOREIGN TABLE agg_bad (
|
|
a int2,
|
|
b float4
|
|
) SERVER file_server
|
|
OPTIONS (format 'csv', filename '@abs_srcdir@/data/agg.bad', header 'true', delimiter ';', quote '@', escape '"', null '');
|
|
-- per-column options tests
|
|
CREATE FOREIGN TABLE text_csv (
|
|
word1 text OPTIONS (force_not_null 'true'),
|
|
word2 text OPTIONS (force_not_null 'off')
|
|
) SERVER file_server
|
|
OPTIONS (format 'text', filename '@abs_srcdir@/data/text.csv', null 'NULL');
|
|
SELECT * FROM text_csv; -- ERROR
|
|
ERROR: COPY force not null available only in CSV mode
|
|
ALTER FOREIGN TABLE text_csv OPTIONS (SET format 'csv');
|
|
SELECT * FROM text_csv;
|
|
word1 | word2
|
|
-------+-------
|
|
AAA | aaa
|
|
XYZ | xyz
|
|
NULL |
|
|
ABC | abc
|
|
(4 rows)
|
|
|
|
-- force_not_null is not allowed to be specified at any foreign object level:
|
|
ALTER FOREIGN DATA WRAPPER file_fdw OPTIONS (ADD force_not_null '*'); -- ERROR
|
|
ERROR: invalid option "force_not_null"
|
|
HINT: There are no valid options in this context.
|
|
ALTER SERVER file_server OPTIONS (ADD force_not_null '*'); -- ERROR
|
|
ERROR: invalid option "force_not_null"
|
|
HINT: There are no valid options in this context.
|
|
CREATE USER MAPPING FOR public SERVER file_server OPTIONS (force_not_null '*'); -- ERROR
|
|
ERROR: invalid option "force_not_null"
|
|
HINT: There are no valid options in this context.
|
|
CREATE FOREIGN TABLE tbl () SERVER file_server OPTIONS (force_not_null '*'); -- ERROR
|
|
ERROR: invalid option "force_not_null"
|
|
HINT: Valid options in this context are: filename, format, header, delimiter, quote, escape, null, encoding
|
|
-- basic query tests
|
|
SELECT * FROM agg_text WHERE b > 10.0 ORDER BY a;
|
|
a | b
|
|
-----+--------
|
|
42 | 324.78
|
|
100 | 99.097
|
|
(2 rows)
|
|
|
|
SELECT * FROM agg_csv ORDER BY a;
|
|
a | b
|
|
-----+---------
|
|
0 | 0.09561
|
|
42 | 324.78
|
|
100 | 99.097
|
|
(3 rows)
|
|
|
|
SELECT * FROM agg_csv c JOIN agg_text t ON (t.a = c.a) ORDER BY c.a;
|
|
a | b | a | b
|
|
-----+---------+-----+---------
|
|
0 | 0.09561 | 0 | 0.09561
|
|
42 | 324.78 | 42 | 324.78
|
|
100 | 99.097 | 100 | 99.097
|
|
(3 rows)
|
|
|
|
-- error context report tests
|
|
SELECT * FROM agg_bad; -- ERROR
|
|
ERROR: invalid input syntax for type real: "aaa"
|
|
CONTEXT: COPY agg_bad, line 3, column b: "aaa"
|
|
-- misc query tests
|
|
\t on
|
|
EXPLAIN (VERBOSE, COSTS FALSE) SELECT * FROM agg_csv;
|
|
Foreign Scan on public.agg_csv
|
|
Output: a, b
|
|
Foreign File: @abs_srcdir@/data/agg.csv
|
|
|
|
\t off
|
|
PREPARE st(int) AS SELECT * FROM agg_csv WHERE a = $1;
|
|
EXECUTE st(100);
|
|
a | b
|
|
-----+--------
|
|
100 | 99.097
|
|
(1 row)
|
|
|
|
EXECUTE st(100);
|
|
a | b
|
|
-----+--------
|
|
100 | 99.097
|
|
(1 row)
|
|
|
|
DEALLOCATE st;
|
|
-- tableoid
|
|
SELECT tableoid::regclass, b FROM agg_csv;
|
|
tableoid | b
|
|
----------+---------
|
|
agg_csv | 99.097
|
|
agg_csv | 0.09561
|
|
agg_csv | 324.78
|
|
(3 rows)
|
|
|
|
-- updates aren't supported
|
|
INSERT INTO agg_csv VALUES(1,2.0);
|
|
ERROR: cannot change foreign table "agg_csv"
|
|
UPDATE agg_csv SET a = 1;
|
|
ERROR: cannot change foreign table "agg_csv"
|
|
DELETE FROM agg_csv WHERE a = 100;
|
|
ERROR: cannot change foreign table "agg_csv"
|
|
SELECT * FROM agg_csv FOR UPDATE OF agg_csv;
|
|
ERROR: SELECT FOR UPDATE/SHARE/KEY UPDATE/KEY SHARE cannot be used with foreign table "agg_csv"
|
|
LINE 1: SELECT * FROM agg_csv FOR UPDATE OF agg_csv;
|
|
^
|
|
-- but this should be ignored
|
|
SELECT * FROM agg_csv FOR UPDATE;
|
|
a | b
|
|
-----+---------
|
|
100 | 99.097
|
|
0 | 0.09561
|
|
42 | 324.78
|
|
(3 rows)
|
|
|
|
-- privilege tests
|
|
SET ROLE file_fdw_superuser;
|
|
SELECT * FROM agg_text ORDER BY a;
|
|
a | b
|
|
-----+---------
|
|
0 | 0.09561
|
|
42 | 324.78
|
|
56 | 7.8
|
|
100 | 99.097
|
|
(4 rows)
|
|
|
|
SET ROLE file_fdw_user;
|
|
SELECT * FROM agg_text ORDER BY a;
|
|
a | b
|
|
-----+---------
|
|
0 | 0.09561
|
|
42 | 324.78
|
|
56 | 7.8
|
|
100 | 99.097
|
|
(4 rows)
|
|
|
|
SET ROLE no_priv_user;
|
|
SELECT * FROM agg_text ORDER BY a; -- ERROR
|
|
ERROR: permission denied for relation agg_text
|
|
SET ROLE file_fdw_user;
|
|
\t on
|
|
EXPLAIN (VERBOSE, COSTS FALSE) SELECT * FROM agg_text WHERE a > 0;
|
|
Foreign Scan on public.agg_text
|
|
Output: a, b
|
|
Filter: (agg_text.a > 0)
|
|
Foreign File: @abs_srcdir@/data/agg.data
|
|
|
|
\t off
|
|
-- privilege tests for object
|
|
SET ROLE file_fdw_superuser;
|
|
ALTER FOREIGN TABLE agg_text OWNER TO file_fdw_user;
|
|
ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
|
|
SET ROLE file_fdw_user;
|
|
ALTER FOREIGN TABLE agg_text OPTIONS (SET format 'text');
|
|
ERROR: only superuser can change options of a file_fdw foreign table
|
|
SET ROLE file_fdw_superuser;
|
|
-- cleanup
|
|
RESET ROLE;
|
|
DROP EXTENSION file_fdw CASCADE;
|
|
NOTICE: drop cascades to 8 other objects
|
|
DETAIL: drop cascades to server file_server
|
|
drop cascades to user mapping for file_fdw_user
|
|
drop cascades to user mapping for file_fdw_superuser
|
|
drop cascades to user mapping for no_priv_user
|
|
drop cascades to foreign table agg_text
|
|
drop cascades to foreign table agg_csv
|
|
drop cascades to foreign table agg_bad
|
|
drop cascades to foreign table text_csv
|
|
DROP ROLE file_fdw_superuser, file_fdw_user, no_priv_user;
|