Tom Lane 218527d014 Don't bother checking the result of SPI_connect[_ext] anymore. ... SPI_connect/SPI_connect_ext have not returned any value other than SPI_OK_CONNECT since commit 1833f1a1c in v10; any errors are thrown via ereport. (The most likely failure is out-of-memory, which has always been thrown that way, so callers had better be prepared for such errors.) This makes it somewhat pointless to check these functions' result, and some callers within our code haven't been bothering; indeed, the only usage example within spi.sgml doesn't bother. So it's likely that the omission has propagated into extensions too. Hence, let's standardize on not checking, and document the return value as historical, while not actually changing these functions' behavior. (The original proposal was to change their return type to "void", but that would needlessly break extensions that are conforming to the old practice.) This saves a small amount of boilerplate code in a lot of places. Stepan Neretin Discussion: https://postgr.es/m/CAMaYL5Z9Uk8cD9qGz9QaZ2UBJFOu7jFx5Mwbznz-1tBbPDQZow@mail.gmail.com		2024-09-09 12:18:34 -04:00
..
autoinc--1.0.sql
autoinc.c
autoinc.control
autoinc.example
insert_username--1.0.sql
insert_username.c
insert_username.control
insert_username.example
Makefile
meson.build
moddatetime--1.0.sql
moddatetime.c
moddatetime.control
moddatetime.example
refint--1.0.sql
refint.c	Don't bother checking the result of SPI_connect[_ext] anymore.	2024-09-09 12:18:34 -04:00
refint.control
refint.example