mirror of
https://git.postgresql.org/git/postgresql.git
synced 2024-11-21 03:13:05 +08:00
823d4c7e25
If contrib/btree_gist is used to make a GIST index on a char(N) (bpchar) column, and that column is retrieved via an index-only scan, what came out had all trailing spaces removed. Since that doesn't happen in any other kind of table scan, this is clearly a bug. The cause is that gbt_bpchar_compress() strips trailing spaces (using rtrim1) before a new index entry is made. That was probably a good idea when this code was first written, but since we invented index-only scans, it's not so good. One answer could be to mark this opclass as incapable of index-only scans. But to do so, we'd need an extension module version bump, followed by manual action by DBAs to install the updated version of btree_gist. And it's not really a desirable place to end up, anyway. Instead, let's fix the code by removing the unwanted space-stripping action and adjusting the opclass's comparison logic to ignore trailing spaces as bpchar normally does. This will not hinder cases that work today, since index searches with this logic will act the same whether trailing spaces are stored or not. It will not by itself fix the problem of getting space-stripped results from index-only scans, of course. Users who care about that can REINDEX affected indexes after installing this update, to immediately replace all improperly-truncated index entries. Otherwise, it can be expected that the index's behavior will change incrementally as old entries are replaced by new ones. Per report from Alexander Lakhin. Back-patch to all supported branches. Discussion: https://postgr.es/m/696c995b-b37f-5526-f45d-04abe713179f@gmail.com |
||
|---|---|---|
| .. | ||
| data | ||
| expected | ||
| sql | ||
| .gitignore | ||
| btree_bit.c | ||
| btree_bytea.c | ||
| btree_cash.c | ||
| btree_date.c | ||
| btree_enum.c | ||
| btree_float4.c | ||
| btree_float8.c | ||
| btree_gist--1.0--1.1.sql | ||
| btree_gist--1.1--1.2.sql | ||
| btree_gist--1.2--1.3.sql | ||
| btree_gist--1.2.sql | ||
| btree_gist--1.3--1.4.sql | ||
| btree_gist--1.4--1.5.sql | ||
| btree_gist.c | ||
| btree_gist.control | ||
| btree_gist.h | ||
| btree_inet.c | ||
| btree_int2.c | ||
| btree_int4.c | ||
| btree_int8.c | ||
| btree_interval.c | ||
| btree_macaddr8.c | ||
| btree_macaddr.c | ||
| btree_numeric.c | ||
| btree_oid.c | ||
| btree_text.c | ||
| btree_time.c | ||
| btree_ts.c | ||
| btree_utils_num.c | ||
| btree_utils_num.h | ||
| btree_utils_var.c | ||
| btree_utils_var.h | ||
| btree_uuid.c | ||
| Makefile | ||