mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity
32,556 Commits 37 Branches 638 Tags 396 MiB
fa56a0c3e0
Commit Graph

203 Commits

Author SHA1 Message Date
Bruce Momjian
878b74e094 In pg_upgrade, remove unnecessary local variable. 2011-10-01 10:01:43 -04:00
Bruce Momjian
5e5958428b In pg_upgrade, because toast table names can be mismatched with the heap 
oid on 8.4, modify the toast name comparison test to only apply to old
9.0+ servers.  (The test was previously 8.4+.)

Backpatch to 9.1.X.
 2011-09-28 22:30:44 -04:00
Peter Eisentraut
52ce20589a Add missing format attributes 
Add __attribute__ decorations for printf format checking to the places that
were missing them.  Fix the resulting warnings.  Add
-Wmissing-format-attribute to the standard set of warnings for GCC, so these
don't happen again.

The warning fixes here are relatively harmless.  The one serious problem
discovered by this was already committed earlier in
cf15fb5cab.
 2011-09-10 23:12:46 +03:00
Bruce Momjian
3ced32d24e In pg_upgrade, disallow migration of 8.3 clusters using contrib/ltree 
because its internal format was changed in 8.4.

Backpatch to 9.0 and 9.1.

Report by depesz, diagnosis by Tom.
 2011-09-07 14:43:12 -04:00
Bruce Momjian
6416a82a62 Remove unnecessary #include references, per pgrminclude script. 2011-09-01 10:04:27 -04:00
Tom Lane
731ebb64b7 Fix not-backwards-compatible pg_upgrade test for prepared transactions. 
There's no reason for this test to use the undocumented pg_prepared_xact()
function, when it can use the stable API pg_prepared_xacts instead.
Fixes breakage against 8.3, as reported by Justin Arnold.
 2011-08-30 17:15:00 -04:00
Bruce Momjian
f1312b5ed3 Add postgres.h to *.c files for pg_upgrade, ltree, and btree_gist, and 
remove from local *.h files.

Per suggestion from Alvaro.
 2011-08-26 21:16:24 -04:00
Bruce Momjian
eb013ede59 In pg_upgrade, limit schema name filter to include toast tables. Bug 
introduced recently when trying to filter out temp tables.

Backpatch to 9.0 and 9.1.
 2011-08-26 00:12:32 -04:00
Bruce Momjian
00a7c9014a In pg_upgrade, don't copy visibility map files from clusters that did not 
have crash-safe visibility maps to clusters that expect crash-safety.

Request from Robert Haas.
 2011-08-19 11:20:30 -04:00
Bruce Momjian
2411fbdac4 In pg_upgrade, avoid dumping orphaned temporary tables. This makes the 
pg_upgrade schema matching pattern match pg_dump/pg_dumpall.

Fix for 9.0, 9.1, and 9.2.
 2011-08-15 22:40:14 -04:00
Bruce Momjian
a31dc392d6 Fix pg_update to properly test for the data directory's existence on 
Win32.

Backpatch to 9.1.
 2011-07-30 01:50:55 -04:00
Bruce Momjian
081a5518c0 In pg_upgrade on Windows, check if the directory is writable by actually 
creating and removing a file because access() doesn't work on that
platform.

Backpatch to 9.1 where this check was added.
 2011-07-24 01:43:57 -04:00
Bruce Momjian
43aa40e155 In pg_upgrade, add C comment about why we don't try to do shared file 
writes for logging.
 2011-07-21 17:13:17 -04:00
Bruce Momjian
17a16eeb7c In pg_upgrade, fix the -l/log option to work on Windows. 
Also, double-quote the log file name in all places, to allow (on all
platforms) log file names with spaces.

Back patch to 9.0 and 9.1.
 2011-07-20 18:31:03 -04:00
Bruce Momjian
6b43fddee4 In pg_upgrade, use pg_strudup(), for consistency. 2011-07-20 16:37:17 -04:00
Peter Eisentraut
912bc4f038 Make pg_upgrade output more consistent with project style 
Add errno-based output to error messages where appropriate, reformat
blocks to about 72 characters per line, use spaces instead of tabs for
indentation, and other style adjustments.
 2011-07-12 07:13:51 +03:00
Peter Eisentraut
d7fb49314d Fix use of unportable %m format 2011-07-07 22:48:59 +03:00
Peter Eisentraut
76dfcb942f Postgres -> PostgreSQL in error message 2011-07-05 22:41:14 +03:00
Bruce Momjian
a88f4496b7 Change pg_upgrade to use port 50432 by default to avoid unintended 
client connections during the upgrade.  Also rename data/bin/port
environment variables to being with 'PG'.  Also no longer honor PGPORT.
 2011-07-01 18:17:12 -04:00
Bruce Momjian
0b44818ead In pg_upgrade, check that the binary and data directories are the same 
major version.

Backpatch to 9.1.

Dan McGee
 2011-06-22 20:48:34 -04:00
Bruce Momjian
3b3c2cf180 In pg_upgrade, fix odd function parameter wrapping. 2011-06-22 19:30:46 -04:00
Bruce Momjian
effbe6ecb4 Rename pg_upgrade directory validation function, for clarity. 2011-06-22 17:50:40 -04:00
Bruce Momjian
559b114dd4 Adjust pg_upgrade check for pg_upgrade_support to happen after the 
binary directory has been validated.

Backpatch to 9.1.

Dan McGee
 2011-06-22 17:47:23 -04:00
Bruce Momjian
b06ad7def8 Fix pg_upgrade status message capitalization mistake. 
Backpatch to 9.1 and 9.0.

Dan McGee
 2011-06-22 14:49:54 -04:00
Bruce Momjian
e3df3572f6 In pg_upgrade, clean up code layout in validateDirectoryOption(). 2011-06-15 17:23:02 -04:00
Bruce Momjian
07d17a73ec In pg_upgrade, check there are no prepared transactions. 2011-06-14 14:53:35 -04:00
Bruce Momjian
6560407c7d Pgindent run before 9.1 beta2. 2011-06-09 14:32:50 -04:00
Bruce Momjian
11c08c3fd7 In pg_upgrade, do case-insensitive checks of locale, encoding, and ctype 
because these are often inconsistently capitalized.
 2011-05-24 15:59:34 -04:00
Bruce Momjian
1f35944607 In pg_upgrade, clean up handling of invalid directory specification by 
checking the stat() errno value more strictly.
 2011-05-18 22:22:40 -04:00
Bruce Momjian
772a5f1e5b Improve pg_upgrade error reporting if the bin or data directories do not 
exist or are not directories.
 2011-05-18 18:37:25 -04:00
Peter Eisentraut
0ee391b77a /contrib/foo -> contrib/foo 
Since contrib is a relative directory specification, a leading slash
is inappropriate.
 2011-05-19 00:30:31 +03:00
Bruce Momjian
92ff915018 Improve pg_upgrade X_OK comment. 2011-05-18 12:25:34 -04:00
Bruce Momjian
6fbf4e0e7c Fix pg_upgrade build problem on Windows when using X_OK access 
permission check on the current directory.
 2011-05-18 12:13:37 -04:00
Bruce Momjian
e728701fb4 Update pg_upgrade directory check error message. 2011-05-16 12:32:36 -04:00
Bruce Momjian
bda27e502f Add pg_upgrade check to make sure the user has full access permission in 
the current directory;  if not, throw an error.
 2011-05-16 11:01:29 -04:00
Bruce Momjian
6c19bd96bc Allow pg_upgrade to honor libpq environment variables. Add 'local' 
checks for PGHOST and PGHOSTADDR.
 2011-05-16 10:48:40 -04:00
Peter Eisentraut
00fad9f6fe Format pg_upgrade --version in line with conventions 2011-05-10 21:40:29 +03:00
Peter Eisentraut
4c78846cb3 Add bug report line to pg_upgrade --help output 2011-05-10 21:37:55 +03:00
Bruce Momjian
5059cf6ebf In pg_upgrade, remove suggestion of setting pg_hba.conf to 'trust', now 
that we report the libpq connection failure string.  Per suggestion from
Robert Haas.
 2011-05-10 10:42:43 -04:00
Bruce Momjian
78318d63d7 In pg_upgrade, add status message about superuser check. 2011-05-09 08:55:36 -04:00
Bruce Momjian
e6a7402842 Add C comment why client encoding can be set in pg_upgrade. 2011-05-07 22:30:35 -04:00
Bruce Momjian
1609ca5adb In pg_upgrade, report non-super-user username in error message. 2011-05-07 12:17:21 -04:00
Bruce Momjian
81301b8578 Check that the pg_upgrade user specified is a super-user. 
Also report the error message when the post-pg_ctl connection fails.

Per private bug report from EnterpriseDB.
 2011-05-07 08:55:45 -04:00
Bruce Momjian
5c5f83507c Adjust pg_upgrade FATAL error messages to have consistent newlines. 
Also adjust some error message capitalization for consistency.
 2011-05-06 21:47:42 -04:00
Peter Eisentraut
d6d823c8b0 Improve formatting of pg_upgrade --help output 2011-05-05 23:19:13 +03:00
Bruce Momjian
6c4d2bd914 Now that pg_upgrade uses -w in pg_ctl, remove loop that retried testing 
the connection;  also restructure the libpq connection code.

This patch also removes the unused variable postmasterPID and fixes a
libpq structure leak that was in the testing loop.
 2011-04-26 10:15:18 -04:00
Bruce Momjian
44091442db In pg_upgrade, avoid one start/stop of the postmaster; use the -w 
(wait) flag for pg_ctl start/stop;  remove the unused "quiet" flag in
the functions for starting/stopping the postmaster.
 2011-04-25 20:18:23 -04:00
Bruce Momjian
76dd09bbec Add postmaster/postgres undocumented -b option for binary upgrades. 
This option turns off autovacuum, prevents non-super-user connections,
and enables oid setting hooks in the backend.  The code continues to use
the old autoavacuum disable settings for servers with earlier catalog
versions.

This includes a catalog version bump to identify servers that support
the -b option.
 2011-04-25 12:00:21 -04:00
Bruce Momjian
f6322b3191 In pg_upgrade, only compile copy_file() on non-Win32 systems. 
Per report from Andrew Dunstan.
 2011-04-23 20:28:29 -04:00
Bruce Momjian
0262251c33 Pg_upgrade C comment addition. 
Document why we do the missing new database check during the check
phase.
 2011-04-20 05:45:31 -04:00