before calling RelationInvalidateHeapTuple(), which is bad because the
latter needs to look at the tuple data, which is in the shared disk
buffer. If another backend manages to recycle the buffer while this
is going on, we will compute the wrong hashindex for the tuple or
maybe even crash outright. Must hold buffer refcount until afterwards.
(This bug is not in 7.0.*; seems to be have introduced during WAL changes.)
and burn. Just for added luck, change reading of CONST nodes so that
we do not need to consult pg_type rows while reading them; this means
that no database access occurs during stringToNode. This requires
changing the order in which const-node fields are written, which means
an initdb is forced.
in per-entry sub-memory-context, where they were supposed to go, rather
than in CacheMemoryContext where the code was putting them. Must've
suffered a severe brain fade when I wrote this :-(
sequences. This is done by disabling multi-byte awareness when it's
not necessary. This is kind of a workaround, not a perfect solution.
However, there is no ideal way to parse broken multi-byte character
sequences. So I guess this is the best way what we could do right
now...
and revert documentation to describe the existing INHERITS clause
instead, per recent discussion in pghackers. Also fix implementation
of SQL_inheritance SET variable: it is not cool to look at this var
during the initial parsing phase, only during parse_analyze(). See
recent bug report concerning misinterpretation of date constants just
after a SET TIMEZONE command. gram.y really has to be an invariant
transformation of the query string to a raw parsetree; anything that
can vary with time must be done during parse analysis.
Previous result did not have correct month boundaries so anything near edge
cases was suspect (e.g. April was in Q1 and July, August were lumped into
Q2).
Thanks to Denis Osadchy <osadchy@turbo.nsk.su> for the report.
Index: TODO
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/TODO,v
retrieving revision 1.311
diff -r1.311 TODO
3c3
< Last updated: Tue Jan 2 21:23:11 EST 2001
---
> Last updated: Wed Jan 3 01:56:41 EST 2001
10c10
< A dash(-) marks changes that will appear in the upcoming 7.1 release.
---
> A dash (-) marks changes that will appear in the upcoming 7.1 release.
23c23
< * -Creating index of TIMESTAMP & RELTIME fails, or rename to DATETIME(Thomas)
---
> * -Creating index of TIMESTAMP & RELTIME fails, or rename to DATETIME (Thomas)
35c35
< * -Views containing aggregates sometimes fail(Jan)
---
> * -Views containing aggregates sometimes fail (Jan)
37,38c37,38
< duplicates(inherit)
< * -Disallow LOCK on view(Mark Hollomon)
---
> duplicates (inherit)
> * -Disallow LOCK on view (Mark Hollomon)
58,60c58,60
< * -Add OUTER joins, left and right[outer](Tom, Thomas)
< * -Allow long tuples by chaining or auto-storing outside db (TOAST)(Jan)
< * Fix memory leak for expressions[memory](Tom?)
---
> * -Add OUTER joins, left and right[outer] (Tom, Thomas)
> * -Allow long tuples by chaining or auto-storing outside db (TOAST) (Jan)
> * Fix memory leak for expressions[memory] (Tom?)
70c70
< * Allow row re-use without vacuum(Vadim)
---
> * Allow row re-use without vacuum (Vadim)
74c74
< * More access control over who can create tables and use locks(Karel)
---
> * More access control over who can create tables and use locks (Karel)
92c92
< o -Fix large object mapping scheme, own typeid or reltype(Peter)
---
> o -Fix large object mapping scheme, own typeid or reltype (Peter)
97c97
< * Fix improper masking of some inet/cidr types [cidr]
---
> * -Fix improper masking of some inet/cidr types [cidr]
113c113
< * Get BIT type working
---
> * -Get BIT type working
119c119
< * Update macaddr manufacturer numbers, or remove the function macaddr_manuf()
---
> * -Update macaddr manufacturer numbers, or remove the function macaddr_manuf()
147c147
< * -Add ALTER TABLE ALTER COLUMN feature(Peter E)
---
> * -Add ALTER TABLE ALTER COLUMN feature (Peter E)
157c157
< * Auto-destroy sequence on DROP of table with SERIAL(Ryan)
---
> * Auto-destroy sequence on DROP of table with SERIAL (Ryan)
166a167
> * Allow INSERT INTO tab (col1, ..) VALUES (val1, ..), (val2, ..)
172d172
< * Allow INSERT INTO tab (col1, ..) VALUES (val1, ..), (val2, ..)
176c176
< * Make NULL's come out at the beginning or end depending on the
---
> * Make NULL's come out at the beginning or end depending on the
220c220
< * Certain indexes will not shrink, i.e. oid indexes with many inserts(Vadim)
---
> * Certain indexes will not shrink, i.e. oid indexes with many inserts (Vadim)
226c226
< with after-row images(Vadim) [logging](Vadim)
---
> with after-row images (Vadim) [logging]
232c232
< * -Redesign the function call interface to handle NULLs better[function](Tom)
---
> * -Redesign the function call interface to handle NULLs better[function] (Tom)
239c239
< * Encrpyt passwords in pg_shadow table using MD5(Vince)
---
> * Encrpyt passwords in pg_shadow table using MD5 (Vince)
298a299,300
> * Create a transaction processor to aid in persistent connections and
> connection pooling
307c309
< * Remove SET KSQO option now that OR processing is improved(Tom)
---
> * Remove SET KSQO option now that OR processing is improved (Tom)
Index: TODO
===================================================================
RCS file: /home/projects/pgsql/cvsroot/pgsql/doc/TODO,v
retrieving revision 1.310
diff -r1.310 TODO
3c3
< Last updated: Wed Dec 27 00:44:44 EST 2000
---
> Last updated: Tue Jan 2 21:23:11 EST 2001
310a311
> * Allow libedit to be used in place of libreadline
The leak is caused by the memory allocation in
src/interfaces/ecpg/lib/execute.c in line 669 which is never freed.
Adding a "free(array_query);" after PQexec in line 671 seems to fix the
leak.
Thorsten Knabe
starting a new hashtable search no longer clobbers any other search
active anywhere in the system. Fix RelationCacheInvalidate() so that
it will not crash or go into an infinite loop if invoked recursively,
as for example by a second SI Reset message arriving while we are still
processing a prior one.
