mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity
528 Commits 37 Branches 638 Tags 396 MiB
d2aa40517a
Commit Graph

528 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Marc G. Fournier
e152661200 Fixes: 
It's bug in nodeAgg.c on lines 241, 242:

                null_array = malloc(nagg);
                for (i=0;i<nagg;i++)
                    null_array[i] = 'n';
                oneTuple = heap_formtuple(tupType, tupValue, null_array);

- your query has not only aggregates but also 'group by-ed' fields and so
null_array should contain tupType->natts elements (tupType->natts > nagg in
your case).

Patch follows and it's very simple.

VAdim
 1996-10-24 06:32:01 +00:00
Marc G. Fournier
c471d2bdeb Take out the PERFECT_MMGR #ifdefs: 
My guess is that the thing had bugs, and the pfree was commented out.
The thing is probabally free'ed anyway at the end, so it was not a bad
thing.

If it does cause a bug, it will generate an error when hit, so I say
unless someone else knows, let's remove it and run the regression test.

-Bruce
 1996-10-24 06:30:40 +00:00
Marc G. Fournier
7f76072d81 Bruce...does this fix it once and for all? *grin* 1996-10-24 06:25:34 +00:00
Marc G. Fournier
f36b2560a4 Major code cleanups from D'arcy (-Wall -Werror) 1996-10-23 07:42:13 +00:00
Marc G. Fournier
29a0fb84fc |I have moved things around so that things happen in the following order: 
|
|  1. Set default variables
|  2. Include Makefile.custom to override defaults
|  3. Set CFLAGS, etc. with variables
|
|This fixes the problem of Makefile.custom changes not taking effect.

Submitted by: D'Arcy Cain
 1996-10-23 07:33:04 +00:00
Bryan Henderson
2db54b8e4f Update "planner" directory to "optimizer" in include paths in this dead code. 1996-10-23 07:14:43 +00:00
Marc G. Fournier
82b83f6f71 Cosmetic changes to ordering of #include files 1996-10-21 11:49:41 +00:00
Marc G. Fournier
9a7fda57ee -Wall'd 1996-10-21 09:37:26 +00:00
Marc G. Fournier
aa907f7d0c -Wall'd 1996-10-21 08:31:23 +00:00
Marc G. Fournier
8385d557d1 -Wall'd ... I missed a subdir under access :( 1996-10-21 07:38:20 +00:00
Marc G. Fournier
f47ffc9a4e Make line 159:bp = NULL, to quiet compiler 
Suggested by: Randy Terbush <randy@zyzzyva.com>
 1996-10-21 07:18:08 +00:00
Marc G. Fournier
c9f8bad182 -Wall'd 
That finishes access/*
 1996-10-21 07:15:18 +00:00
Bryan Henderson
1363ca1d52 Force user to set PORTNAME. Remove NAMEDATALEN from CFLAGS (don't need it 
there because it's in config.h, which is cleaner).
 1996-10-21 06:56:57 +00:00
Marc G. Fournier
b446f38510 -Wall'd 1996-10-21 05:59:49 +00:00
Marc G. Fournier
ede7e6b045 -Wall'd 1996-10-21 05:45:21 +00:00
Marc G. Fournier
0452227989 -Wall Cleanup of gist subdirectory 1996-10-21 05:14:02 +00:00
Marc G. Fournier
95874fa034 -Wall cleanup of gist subdirectory: 
- cleaned out unused variables
	- added missing prototype headers

One outstanding -Werror failure:

/home/staff/scrappy/postgres/2.0/cvs/postgres95/src/backend/access/gist/giststra
t.c:117: warning: missing braces around initializer for `GISTEvaluationData.expr
ession'
 1996-10-21 05:11:00 +00:00
Marc G. Fournier
8325d9fc3b Define prototypes from giststrat.c required in gistscan.c 1996-10-21 05:05:42 +00:00
Marc G. Fournier
d458a1c747 Other then: 
indextuple.c:159: warning: `bp' might be used uninitialized in this function

this directory passes -Wall -Werror under FreeBSD
 1996-10-20 22:04:49 +00:00
Marc G. Fournier
597a1de903 remove an #ifdef/#else/#endif that doesn't actually have anything inside 
of it
 1996-10-20 21:51:45 +00:00
Marc G. Fournier
2217b1ccd8 Make default HAVE_MEMMOVE defined, undef inside of definitions for sparc 1996-10-20 20:58:14 +00:00
Marc G. Fournier
331bb53b0f change '#if defined(PORTNAME_sparc)' to '#if !defined(HAVE_MEMMOVE)' 1996-10-20 20:57:06 +00:00
Marc G. Fournier
925ea01ed6 Add #define HAVE_MEMMOVE for systems that do have it. 1996-10-20 20:40:17 +00:00
Marc G. Fournier
7b58bb0088 Clean up comments (-Wall -Werror) 1996-10-20 20:34:06 +00:00
Marc G. Fournier
13cd836d62 #include file cleanup 1996-10-20 10:53:18 +00:00
Marc G. Fournier
e1220b7c21 More #include cleanups 
Once access/* is cleaned out, will redo using -Wall on compile to
make sure that all prototyping is correct
 1996-10-20 09:27:24 +00:00
Marc G. Fournier
5a0b450c78 First pass at fixing my own mistakes 
Mainly...fix up the includes I removed, as well as prototypes

Pointed out by D'Arcy
 1996-10-20 08:32:11 +00:00
Marc G. Fournier
dd007d4c39 Another directory cleaned out 1996-10-20 06:56:04 +00:00
Marc G. Fournier
2b5a8bc38b More include files cleaned up 1996-10-20 06:35:27 +00:00
Marc G. Fournier
3cb7ff8db2 Okay...another directory cleaned out and compilable 1996-10-20 06:34:30 +00:00
Marc G. Fournier
5eee45ea05 Add HAVE_Cplusplus= true to BSD44_derived Makefile.inc, as I know that 
FreeBSD/NetBSD both ship with gcc 2.7.x
 1996-10-19 06:36:52 +00:00
Marc G. Fournier
2a23c4e724 Not quite the cleanest way to do it, but add an option to Makefile.global 
that allows one to compile libpq++

this should be set on a port-by-port basis
 1996-10-19 06:33:55 +00:00
Marc G. Fournier
0eac5b0ed5 Welp, another subdirectory cleaned out of redundant/unused #include 
files
 1996-10-19 06:27:33 +00:00
Marc G. Fournier
e77f64af62 There...that pretty much cleans up redundant/unused #includes in 
access/common...how many more directories to go? :)
 1996-10-19 04:51:44 +00:00
Marc G. Fournier
f4ba64a0ac Almost have access/common cleaned up... 1996-10-19 04:49:29 +00:00
Marc G. Fournier
23f444f64d A few more yet... 1996-10-19 04:48:30 +00:00
Marc G. Fournier
6592bbaf08 wish there was an easier way to clean this up... 1996-10-19 04:46:28 +00:00
Marc G. Fournier
4c9309a8d5 another small one 1996-10-19 04:36:08 +00:00
Marc G. Fournier
42dd813494 Hopefully that cleans up the cruft from rel.h 1996-10-19 04:31:45 +00:00
Marc G. Fournier
1d5c3ec010 another... 1996-10-19 04:25:53 +00:00
Marc G. Fournier
c6979925ea its coming... 1996-10-19 04:24:57 +00:00
Marc G. Fournier
7bb98fd618 step by step...file by file... 1996-10-19 04:16:04 +00:00
Marc G. Fournier
7260183685 ...same 1996-10-19 04:09:32 +00:00
Marc G. Fournier
d0bfb6b78d slow work... 1996-10-19 04:08:58 +00:00
Marc G. Fournier
f697bf3b85 and another 1996-10-19 04:06:48 +00:00
Marc G. Fournier
6fd191c899 another one cleaned up 1996-10-19 04:05:44 +00:00
Marc G. Fournier
9b6b82b91d and another one.. 1996-10-19 04:03:29 +00:00
Marc G. Fournier
f3671cc910 another another one 1996-10-19 04:02:39 +00:00
Marc G. Fournier
c2c618fada anothre one reduced to its component parts 1996-10-19 04:01:41 +00:00
Marc G. Fournier
d9ebe7711f clean out include files of including other includes files except those 
absolutely required
 1996-10-19 03:58:34 +00:00