Commit Graph

21300 Commits

Author SHA1 Message Date
Neil Conway
c10dba2fe3 Remove an antiquated comment. 2005-10-13 06:24:05 +00:00
Neil Conway
689c815b09 Add a comment describing the requirement that pointers into shared memory
that is protected by a spinlock must be volatile, per recent discussion.
2005-10-13 06:17:34 +00:00
Bruce Momjian
4a6dcf0322 Update trigger demo to reflect new trigger ordering. 2005-10-13 02:23:12 +00:00
Bruce Momjian
3d50e107ad Remove extra <para> 2005-10-13 02:00:09 +00:00
Bruce Momjian
249f07b8c6 Update:
> * Prevent PQfnumber() from lowercasing unquoted the column name
>
>   PQfnumber() should never have been doing lowercasing, but historically
>   it has so we need a way to prevent it
>
2005-10-13 01:23:49 +00:00
Tom Lane
1e9a6ba5e6 Don't try to remove duplicate OR-subclauses in create_bitmap_subplan and
make_restrictinfo_from_bitmapqual.  The likelihood of finding duplicates
seems much less than in the AND-subclause case, and the cost much higher,
because OR lists with hundreds or even thousands of subclauses are not
uncommon.  Per discussion with Ilia Kantor and andrew@supernews.
2005-10-13 00:06:46 +00:00
Tom Lane
23e2f9ebf7 Fix spelling error, per Michael Fuhr. 2005-10-12 23:19:22 +00:00
Bruce Momjian
adc58f145c Remove item:
< * Prevent libpq's PQfnumber() from lowercasing the column name
<
<   One idea is to lowercase all identifiers except those that are
<   surrounded by quotes.
<
2005-10-12 22:39:35 +00:00
Tom Lane
e952ae1268 Fix longstanding bug found by Atsushi Ogawa: _bt_check_unique would mark
the wrong buffer dirty when trying to kill a dead index entry that's on
a page after the one it started on.  No risk of data corruption, just
inefficiency, but still a bug.
2005-10-12 17:18:03 +00:00
Tom Lane
fa72121594 Fix another recently-changed place that was messing with spinlock-
protected data structures and not using a volatile pointer for same.
2005-10-12 16:55:59 +00:00
Tom Lane
07eeb9d109 Do all accesses to shared buffer headers through volatile-qualified
pointers, to ensure that compilers won't rearrange accesses to occur
while we're not holding the buffer header spinlock.  It's probably
not necessary to mark volatile in every single place in bufmgr.c,
but better safe than sorry.  Per trouble report from Kevin Grittner.
2005-10-12 16:45:14 +00:00
Bruce Momjian
6b97e437ca Add warning about plperl nested named subroutines
Andrew Dunstan
2005-10-12 14:28:33 +00:00
Bruce Momjian
0a28eb4622 No longer needed:
<
< * Add code to detect an SMP machine and handle spinlocks accordingly
<   from distributted.net, http://www1.distributed.net/source,
<   in client/common/cpucheck.cpp
<
<   On SMP machines, it is possible that locks might be released shortly,
<   while on non-SMP machines, the backend should sleep so the process
<   holding the lock can complete and release it.
2005-10-12 14:06:46 +00:00
Bruce Momjian
4aebb5ad55 Rearrange:
< 	o %Add dumping of comments on composite type columns
< 	o %Add dumping of comments on index columns
< 	o Stop dumping CASCADE on DROP TYPE commands in clean mode
> 	o %Add dumping of comments on index columns and composite type columns
604a603
> 	o Stop dumping CASCADE on DROP TYPE commands in clean mode
2005-10-12 13:41:08 +00:00
Bruce Momjian
d5310ca920 Done:
< 	o %Replace crude DELETE FROM method of pg_dumpall --clean for
<           cleaning of roles with separate DROP commands
608a607
>
2005-10-12 13:39:51 +00:00
Bruce Momjian
87a67d186b Add:
<
> 	o Allow pg_dump --clean to drop roles that own objects or have
> 	  privileges
2005-10-12 13:39:21 +00:00
Peter Eisentraut
4102640683 Update keywords table for 8.1. 2005-10-12 09:45:29 +00:00
Bruce Momjian
752290207d Add description:
< * Prevent libpq's PQfnumber() from lowercasing the column name?
> * Prevent libpq's PQfnumber() from lowercasing the column name
>
>   One idea is to lowercase all identifiers except those that are
>   surrounded by quotes.
>
2005-10-12 03:26:38 +00:00
Bruce Momjian
368f0b28f3 Add:
> 	o Add options like pg_restore -l and -L to pg_dump
2005-10-12 02:57:42 +00:00
Bruce Momjian
e4aa5be90c Add:
> 	o Allow selection of individual object(s) of all types, not just
> 	  tables
> 	o In a selective dump, allow dumping of an object and all its
> 	  dependencies
2005-10-11 23:55:10 +00:00
PostgreSQL Daemon
9fa7ba3041 must commit *after* autoconf, not before 2005-10-11 23:27:46 +00:00
PostgreSQL Daemon
5f470ad491 update to beta3 before tagging ... 2005-10-11 23:26:43 +00:00
Neil Conway
6f8236f1b5 Fix typo in sample pg_hba.conf; per IRC report from Bernhard Neuhauser. 2005-10-11 22:58:15 +00:00
Tom Lane
96a83d8807 Release notes up to date as of today. 2005-10-11 21:17:11 +00:00
Tom Lane
a72ee09090 Add infrastructure for making spins_per_delay variable depending on
whether we seem to be running in a uniprocessor or multiprocessor.
The adjustment rules could probably still use further tweaking, but
I'm convinced this should be a win overall.
2005-10-11 20:41:32 +00:00
Tom Lane
9907b9775b Don't use a non-locked pre-test of the spinlock on x86_64 machines.
The pre-test has been shown to be a big loss on Opterons and at best a
wash on EM64T.
2005-10-11 20:01:30 +00:00
Tom Lane
0cc0d0822d Document that get_attstatsslot/free_attstatsslot only need to be passed
valid type information if they are asked to fetch the values part of a
pg_statistic slot; these arguments are unneeded if fetching only the
numbers part.  Use this to save a catcache lookup in btcostestimate,
which is looking like a bit of a hotspot in recent profiling.  Not a
big savings, but since it's essentially free, might as well do it.
2005-10-11 17:27:14 +00:00
Tom Lane
07e6f93d6b Fix oversight in 8.0 modification of RestrictInfo data structures.
A RestrictInfo representing an OR clause now contains two versions of
the contained expression, one with sub-RestrictInfos and one without.
clause_selectivity() should descend to the version with sub-RestrictInfos
so that it has a chance of caching its results for the OR's sub-clauses.
Failing to do so resulted in redundant planner effort.
2005-10-11 16:44:40 +00:00
Tom Lane
c6b9924bec Remove the DELETEs from pg_shadow and pg_group that pg_dumpall used to
emit when given the --clean option, in favor of individual DROP ROLE
commands.  The old technique could not possibly work in 8.1, and was
never a very good idea anyway IMHO.  The DROP ROLE approach has the
defect that the DROPs will fail for roles that own objects or have
privileges, but perhaps we can improve that later.
2005-10-10 22:29:48 +00:00
Tom Lane
375e7d5579 Use a safer order of operations in dropdb(): rollbackable operations,
ie removing shared-dependency entries, should happen before non-rollbackable
ones.  That way a failure during the rollbackable part doesn't leave us
with inconsistent state.
2005-10-10 20:02:20 +00:00
Peter Eisentraut
15a110ed01 Document the process to update translations. 2005-10-10 19:41:27 +00:00
Peter Eisentraut
b473d7adc4 Translation update 2005-10-10 19:36:36 +00:00
Tom Lane
9178306151 Fix the problem of GRANTs creating "dangling" privileges not directly
traceable to grant options.  As per my earlier proposal, a GRANT made by
a role member has to be recorded as being granted by the role that actually
holds the grant option, and not the member.
2005-10-10 18:49:04 +00:00
Tom Lane
d7527540f2 <limits.h> is now needed here, for INT_MAX. Per Michael Fuhr. 2005-10-10 01:34:00 +00:00
Tom Lane
313ed1ed94 Fix (hopefully for the last time) problems with datetime values displaying
like '23:59:60' because of fractional-second roundoff problems.  Trying
to control this upstream of the actual display code was hopeless; the right
way is to explicitly round fractional seconds in the display code and then
refigure the results if the fraction rounds up to 1.  Per bug #1927.
2005-10-09 17:21:47 +00:00
Tom Lane
7754f7634c Fix a thinko in description of krb_server_hostname. 2005-10-08 20:27:25 +00:00
Tom Lane
76cb32d848 Fix up grammar in variable description string. 2005-10-08 20:08:19 +00:00
Tom Lane
18d0ca2d1b Fix Kerberos authentication in wake of virtual-hosts changes --- need
to call krb5_sname_to_principal() always.  Also, use krb_srvname rather
than the hardwired string 'postgres' as the appl_version string in the
krb5_sendauth/recvauth calls, to avoid breaking compatibility with PG
8.0.  Magnus Hagander
2005-10-08 19:32:58 +00:00
Bruce Momjian
4909357237 Remove unnecessary ABORT commands in dblink regression tests. 2005-10-08 16:10:38 +00:00
Bruce Momjian
768dfd0375 Cosmetic improvements to dblink. 2005-10-08 12:18:48 +00:00
Bruce Momjian
f3576c33f8 Cosmetic changes to dblink. 2005-10-08 12:12:29 +00:00
Bruce Momjian
7d937cd408 Cosmetic changes to dblink. 2005-10-08 11:33:45 +00:00
Bruce Momjian
adeca513f7 Add spacing around operators. 2005-10-08 02:39:27 +00:00
Tom Lane
82e861fbe1 Fix LWLockAssign() so that it can safely be executed after postmaster
initialization.  Add spinlocking, fix EXEC_BACKEND unsafeness.
2005-10-07 21:42:38 +00:00
Bruce Momjian
77d1de3c89 Minor parentheses cleanup. 2005-10-07 20:26:41 +00:00
Bruce Momjian
8e0c8a2463 Add spaces around operator. 2005-10-07 20:13:16 +00:00
Tom Lane
bb55e583f6 Allocate a few extra LWLocks for possible use by add-on modules.
Per request from Marc Munro.
2005-10-07 20:11:03 +00:00
Tom Lane
426d0158ca Marginal performance improvement in aclmask(): don't bother with
testing ownership if the caller isn't interested in any GOPTION bits
(which is the common case).  It did not matter in 8.0 where the ownership
test was just a trivial equality test, but it matters now.
2005-10-07 19:59:34 +00:00
Tom Lane
b888ab82da Recognize ERROR_SHARING_VIOLATION (translate to EACCES), increase log
level for unrecognized win32 error codes to LOG, and make messages
conform to style guide.  Per old suggestion from Qingqing Zhou, which
seems to have gotten lost in the shuffle.
2005-10-07 16:34:48 +00:00
Tom Lane
d156e1f850 (Apologies for fat-fingering cvs commit command...) Should have read:
Remove unportable use of tfind/tsearch in favor of bsearch.  Fix up
random number generator to use random() not rand() and to actually honor
its min/max arguments properly.  That wasn't so important before, but
with exposure of capability to ask for general ranges, it will be.
2005-10-07 15:34:17 +00:00