Commit Graph

19571 Commits

Author SHA1 Message Date
Tom Lane
a4500f3262 Previous "64-bit fix" for intagg didn't actually work. This is already
fixed properly in CVS tip, but we need a band-aid for back branches.
Per report from Ron Mayer.
2005-03-23 19:06:54 +00:00
Tom Lane
5869e883ee WAL must log CREATE and DROP DATABASE operations *without* using any
explicit paths, so that the log can be replayed in a data directory
with a different absolute path than the original had.  To avoid forcing
initdb in the 8.0 branch, continue to accept the old WAL log record
types; they will never again be generated however, and the code can be
dropped after the next forced initdb.  Per report from Oleg Bartunov.
We still need to think about what it really means to WAL-log CREATE
TABLESPACE commands: we more or less have to put the absolute path
into those, but how to replay in a different context??
2005-03-23 00:04:25 +00:00
Tom Lane
1cef5beeea Fix quote_ident to use quote_identifier rather than its own, not quite
up-to-speed logic; in particular this will cause it to quote names that
match keywords.  Remove unnecessary multibyte cruft from quote_literal
(all backend-internal encodings are 8-bit-safe).
2005-03-21 16:29:31 +00:00
Tom Lane
8ae13aac52 Put 'dump complete' message in the right place, so it comes out where
it's supposed to when --file option is used.
2005-03-18 17:33:03 +00:00
Tom Lane
817bc021b7 Need to reset local buffer pin counts, not only shared buffer pins,
before we attempt any file deletions in ShutdownPostgres.  Per Tatsuo.
2005-03-18 16:16:20 +00:00
Michael Meskes
fc80f5fe73 Added patch by Christof Petig <christof@petig-baender.de> to work around gcc bug on powerpc and amd64. 2005-03-18 10:01:14 +00:00
Tom Lane
b03072571e Need to release buffer pins before attempting to drop files during
backend exit.  Per report from Bruce.
2005-03-18 05:24:24 +00:00
Tom Lane
bcfe5088e5 Treat EPERM as a non-error case when checking to see if old postmaster
is still alive.  This improves our odds of not getting fooled by an
unrelated process when checking a stale lock file.  Other checks already
in place, plus one newly added in checkDataDir(), ensure that we cannot
attempt to usurp the place of a postmaster belonging to a different userid,
so there is no need to error out.  Add comments indicating the importance
of these other checks.
2005-03-18 03:49:19 +00:00
Bruce Momjian
7911e3a081 Backpatch to 8.0.X, already in HEAD:
Allow Win32 to support the O_SYNC open flag as an wal_sync_method
method.
2005-03-17 17:28:59 +00:00
Bruce Momjian
89ea098714 Add missing include for new lc_ctype_is_c() function.
Per Neil.
2005-03-16 01:49:20 +00:00
Bruce Momjian
fb2c2d83e0 Prevent locale-aware handling of upper, lower, and initcap when the
locale is C.

Backpatch to 8.0.X because some operating systems were throwing errors
for such operations, rather than ignoring the locale when it was C.
2005-03-16 00:03:02 +00:00
Bruce Momjian
f38cb720d9 Increment all major version numbers in 8.0.X to force recompile of
client aplications so 7.4.X releases can be installed on the same
machine as 8.0.X.
2005-03-13 22:04:45 +00:00
Tom Lane
b3dbaab1e9 Fix ALTER DATABASE RENAME to allow the operation if user is a superuser
who for some reason isn't marked usecreatedb.  Per report from Alexander
Pravking.  Also fix sloppy coding in have_createdb_privilege().
2005-03-12 21:12:05 +00:00
Neil Conway
8806b09b82 Some builds (depends on crypto engine support?) of OpenSSL
0.9.7x have EVP_DigestFinal function which which clears all of
EVP_MD_CTX.  This makes pgcrypto crash in functions which
re-use one digest context several times: hmac() and crypt()
with md5 algorithm.

Following patch fixes it by carring the digest info around
EVP_DigestFinal and re-initializing cipher.

Marko Kreen.
2005-03-12 06:54:31 +00:00
Tom Lane
bdcf632d62 Fix problem with infinite recursion between write_syslogger_file and
elog if the former has trouble writing its file.  Code review for
Magnus' patch to redirect stderr to syslog on Windows (Bruce's version
seems right, but did some minor prettification).

Backpatch both changes to 8.0 branch.
2005-03-12 01:55:15 +00:00
Bruce Momjian
2e964aee75 Here's the patch to fix a lot of markup errors in the HTML FAQs. Doesn't
change content (at least not supposed to).

Magnus Hagander
2005-03-11 21:47:44 +00:00
Bruce Momjian
30854a53fe Properly implement "Response files" for bcc. Add URL's to describe the
feature for Win32 and bcc.
2005-03-07 21:11:07 +00:00
Teodor Sigaev
10d3c07875 Prevent rank change in case of duplicate search terms 2005-03-05 16:17:47 +00:00
Tom Lane
4e8af8d273 Replace ARC cache management algorithm with the similar but slightly
simpler 2Q algorithm, to avoid possible problems with the pending patent
on ARC.  Testing so far suggests that there is little if any performance
loss from doing this.

Note that this patch is going into the 8.0 branch only; a much more
extensive revision is planned for HEAD.
2005-03-03 16:47:43 +00:00
Tom Lane
3f16b38a23 Release proclock immediately in RemoveFromWaitQueue() if it represents
no held locks.  This maintains the invariant that proclocks are present
only for procs that are holding or awaiting a lock; when this is not
true, LockRelease will fail.  Per report from Stephen Clouse.
2005-03-01 21:15:10 +00:00
Tom Lane
bfc2942321 Adjust OR indexscan logic to not generate redundant condition-free OR
indexscans involving partial indexes.  These would always be dominated
by a simple indexscan on such an index, so there's no point in considering
them.  Fixes overoptimism in a patch I applied last October.
2005-03-01 01:40:39 +00:00
Tom Lane
3da9fd8544 Revert the logic for expanding AND/OR conditions in pred_test() to what
it was in 7.4, and add some comments explaining why it has to be this way.
I broke it for OR'd index predicates in a fit of code cleanup last summer.
Per example from Sergey Koshcheyev.
2005-03-01 00:25:45 +00:00
Bruce Momjian
ba6b067ce8 Tab indent all actions in bcc32.mak, and do it on win32.mak too for
consistency.  Backpatch only bcc32.mak to 8.0.X.
2005-02-27 22:38:29 +00:00
Teodor Sigaev
2573029e52 Further fix int64/float8 time/timetz 2005-02-27 09:28:07 +00:00
Teodor Sigaev
1d5b814be9 Further fix time/timetz... 2005-02-27 00:11:35 +00:00
Bruce Momjian
9f312cde26 Backpatch clarification of PGPASSWORD to 8.0.X. 2005-02-26 18:50:44 +00:00
Bruce Momjian
a72fd004ba Add linking from /port to bcc makefile. 2005-02-25 15:57:41 +00:00
Teodor Sigaev
1c8fbd9b25 Fix float8->int64 transformation 2005-02-25 14:04:39 +00:00
Bruce Momjian
4a68e59418 Backpatch FAQ to 8.0.X. 2005-02-25 00:33:45 +00:00
Tom Lane
777745435c Document that only a table's owner may TRUNCATE it. Per Keith Worthington. 2005-02-22 19:06:35 +00:00
Bruce Momjian
7f6754bdb4 Update initdb locale/encoding documentation description. Backpatch to
8.0.X.
2005-02-22 02:56:37 +00:00
Bruce Momjian
bb7f5a7393 Try to get Borland CC to compile.
Backpatch to 8.0.X which doesn't work right now.
2005-02-21 21:22:46 +00:00
Bruce Momjian
6da3aee893 Update Russian FAQ.
Viktor Vislobokov
2005-02-21 17:34:10 +00:00
Teodor Sigaev
1c423be404 Simplify defines 2005-02-21 14:10:44 +00:00
Teodor Sigaev
f49d69b813 Fix memory leak for timestamp(with and w/o tz) and time indexes 2005-02-21 10:47:52 +00:00
Neil Conway
14fd629aea Fix two typos, per report from Hashem Masoud. 2005-02-21 06:12:41 +00:00
Neil Conway
abd7168524 Document the "register" and "unregister" pg_ctl subcommands, for use on
Windows. Patch from Magnus Hagander.
2005-02-21 02:14:34 +00:00
Tom Lane
0845ee3958 New arrangement to always let the bgwriter do checkpoints broke
CHECKPOINT and some other commands in the context of a standalone
backend.  Allow a standalone backend to do its own checkpoints.
2005-02-19 23:16:27 +00:00
Tom Lane
254eef2f28 Ensure that the resolved datatype of any unknown Param is propagated
into the sub-SELECT targetlist when it appears in the context
INSERT INTO foo SELECT $1 ...  Per report from Abhijit Menon-Sen.
2005-02-19 19:33:23 +00:00
Tom Lane
c35c944b87 ALTER LANGUAGE RENAME has never worked. Per Sergey Yatskevich. 2005-02-14 06:17:59 +00:00
Bruce Momjian
92597d1386 Print file name and errno string on rmtree failure.
Backpatch to 8.0.X.
2005-02-13 16:50:54 +00:00
Peter Eisentraut
66b568ca96 Translation updates 2005-02-11 11:53:32 +00:00
Bruce Momjian
8814ee8497 Update to Russian FAQ, HEAD and 8.0.X. 2005-02-11 04:54:05 +00:00
Bruce Momjian
538e960939 Mention that some psql environment variables come from libpq and note
more variables can be found in the libpq manual section.

Mention .pgpass in the psql manual page section dealing with connection
parameters and point to the libpq section for more details.

Backpatch to 8.0.X.
2005-02-11 04:19:18 +00:00
Tom Lane
9843862b50 Fix SPI cursor support to allow scanning the results of utility commands
that return tuples (such as EXPLAIN).  Per gripe from Michael Fuhr.
Side effect: fix an old bug that unintentionally disabled backward scans
for all SPI-created cursors.
2005-02-10 20:36:49 +00:00
Michael Meskes
95b40b7f77 Fixed more parsing bugs in other CREATE statements. 2005-02-10 08:07:46 +00:00
Bruce Momjian
7dfc700b96 Update pginstaller URL to http://www.postgresql.org/ftp/win32/.
Backpatch to 8.0.X.
2005-02-10 04:53:11 +00:00
Neil Conway
789aafebd5 ALTER TABLE ADD COLUMN exhibits a significant memory leak when adding a
column with a default expression. In that situation, we need to rewrite
the heap relation. To evaluate the new default expression, we use
ExecEvalExpr(); however, this can allocate memory in the current memory
context, and ATRewriteTable() does not switch out of the active portal's
heap memory context. The end result is a rather large memory leak (on
the order of gigabytes for a reasonably sized table).

This patch changes ATRewriteTable() to switch to the per-tuple memory
context before beginning the per-tuple loop. It also removes an explicit
heap_freetuple() in the loop, since that is no longer needed.

In an unrelated change, I noticed the code was scanning through the
attributes of the new tuple descriptor for each tuple of the old table.
I changed this to use precomputation, which should slightly speed up
the loop.

Thanks to steve@deefs.net for reporting the leak.
2005-02-09 23:27:24 +00:00
Michael Meskes
ef006ded8e Fixed bug in parsing of CREATE AS statement. 2005-02-09 11:28:21 +00:00
Tom Lane
ae50aa7ee8 If we're gonna check for array overrun, we really should do so before
overrunning the array, not after.
2005-02-08 18:21:59 +00:00