Commit Graph

23961 Commits

Author SHA1 Message Date
Teodor Sigaev
5ceb508422 Fix memory reallocation condition 2006-12-26 14:55:00 +00:00
Tom Lane
3b1645d119 Make HISTCONTROL=ignoredups work again (broken by misordering of
operations during recent code refactoring).  Per bug #2840 from Ned Crigler.
2006-12-24 19:14:41 +00:00
Teodor Sigaev
593d020ff6 Fix convertion for 'PFX flag N num' 2006-12-21 17:35:44 +00:00
Bruce Momjian
d686dccdb8 Remove completed TODO item about xid wrap-around from 8.2.X. 2006-12-19 21:58:43 +00:00
Tom Lane
14bdb023cc Fix some planner bugs exposed by reports from Arjen van der Meijden. These
are all in new-in-8.2 logic associated with indexability of ScalarArrayOpExpr
(IN-clauses) or amortization of indexscan costs across repeated indexscans
on the inside of a nestloop.  In particular:

Fix some logic errors in the estimation for multiple scans induced by a
ScalarArrayOpExpr indexqual.

Include a small cost component in bitmap index scans to reflect the costs of
manipulating the bitmap itself; this is mainly to prevent a bitmap scan from
appearing to have the same cost as a plain indexscan for fetching a single
tuple.

Also add a per-index-scan-startup CPU cost component; while prior releases
were clearly too pessimistic about the cost of repeated indexscans, the
original 8.2 coding allowed the cost of an indexscan to effectively go to zero
if repeated often enough, which is overly optimistic.

Pay some attention to index correlation when estimating costs for a nestloop
inner indexscan: this is significant when the plan fetches multiple heap
tuples per iteration, since high correlation means those tuples are probably
on the same or adjacent heap pages.
2006-12-15 18:42:35 +00:00
Tom Lane
4f554024a8 Put JST back into the default set of timezone abbreviations;
was removed in an unexplainable moment of brain fade.
2006-12-15 16:54:56 +00:00
Bruce Momjian
880dae5f2b Back out double-run of PDF/PS output. Requires building bookindex.sgml
properly.

Remove SGML docs about openjade performance patch, and instead add
comment in style sheet where indenting code is commented out.

Backpatch to 8.2.X.
2006-12-15 16:50:10 +00:00
Peter Eisentraut
6d3985b46e Drop indentation of verbatim environments in print output. This increased
the build time by what seemed like infinity.
2006-12-15 14:54:48 +00:00
Bruce Momjian
169f9f4cb6 Document patch needed to get PDF and PS output in a reasonable amount of
time.
2006-12-15 02:44:33 +00:00
Bruce Momjian
87047e4ca5 Run Jade twice when outputting Postscript and PDF so the index is
correct, add comments about other multiple runs in the Makefile.

Backpatch to 8.2.X.
2006-12-15 01:21:08 +00:00
Tom Lane
8867ffc519 Make --with-ldap build on Unixware, per Olivier Prenant. 2006-12-14 21:50:07 +00:00
Tom Lane
bef92dadb0 Fix planner to do the right thing when a degenerate outer join (one whose
joinclause doesn't use any outer-side vars) requires a "bushy" plan to be
created.  The normal heuristic to avoid joins with no joinclause has to be
overridden in that case.  Problem is new in 8.2; before that we forced the
outer join order anyway.  Per example from Teodor.
2006-12-12 21:31:09 +00:00
Bruce Momjian
e1b09b59de Document that log_line_prefix %t does not print timezone on Win32. 2006-12-12 21:30:41 +00:00
Peter Eisentraut
9178874f34 Collect the bits of wisdom about dtrace installation in the installation
chapter rather than scattering them across several incomplete fragments.

(This makes the documentation consistent with the backported FAQ_Solaris.)
2006-12-12 16:07:42 +00:00
Bruce Momjian
d94fa4183f Backpatch FAQ entry for null concatenation. 2006-12-11 22:48:08 +00:00
Tom Lane
3647ff3b3a Avoid double free of _SPI_current->tuptable. AtEOSubXact_SPI() now tries to
release it in a subtransaction abort, but this neglects possibility that
someone outside SPI already did.  Fix is for spi.c to forget about a tuptable
as soon as it's handed it back to the caller.
Per bug #2817 from Michael Andreen.
2006-12-08 00:40:33 +00:00
Tom Lane
373bd34e73 Repair incorrect placement of WHERE clauses when there are multiple,
rearrangeable outer joins and the WHERE clause is non-strict and mentions
only nullable-side relations.  New bug in 8.2, caused by new logic to allow
rearranging outer joins.  Per bug #2807 from Ross Cohen; thanks to Jeff
Davis for producing a usable test case.
2006-12-07 19:33:48 +00:00
Tom Lane
f07f11efde Fix planning of SubLinks to ensure that Vars generated from transformation of
a sublink's test expression have the correct vartypmod, rather than defaulting
to -1.  There's at least one place where this is important because we're
expecting these Vars to be exactly equal() to those appearing in the subplan
itself.  This is a pretty klugy solution --- it would likely be cleaner to
change Param nodes to include a typmod field --- but we can't do that in the
already-released 8.2 branch.
Per bug report from Hubert Fongarnand.
2006-12-06 19:40:08 +00:00
Bruce Momjian
a7fb173fa4 Clean up psql -c documentation that uses \\. 2006-12-06 15:40:32 +00:00
Bruce Momjian
1acc2e23f4 Fix documentation example of using psql \x with a SELECT command, per
Simon Riggs.  Backpatch to 8.2.X.
2006-12-05 17:41:02 +00:00
Bruce Momjian
dfd4259e94 Fix pg_dump linking on Win32 with MSVS win32.mak:
The module link is insufficient.:-(

---- Sorry, japanese message change to xxx ---
link.exe @C:\DOCUME~1\hi-saito\LOCALS~1\Temp\nmk03360.
common.obj : error LNK2001: xxxxxx "_pg_qsort" xxxxxx
pg_dump_sort.obj : error LNK2001: xxxxx "_pg_qsort" xxxxx
.\Release\pg_dump.exe : fatal error LNK1120: xxxxxxx
NMAKE : fatal error U1077: 'link.exe' : xxxxx '0x460'
Stop.

Hiroshi Saito
2006-12-04 22:26:46 +00:00
Bruce Momjian
e1bfa1869f Patch of Win32 Encoding problem for server messages using
FormatMessage() (This should have been in 8.2.0, patched to 8.2.X and
HEAD):

I think this problem to be complex....
http://archives.postgresql.org/pgsql-hackers/2006-11/msg00042.php

FormatMessage of windows cannot consider the encoding of the database.
However, I should try the solution now. It is necessary to clear the
problem.

Multi character-code exists together in message and log. It doesn't
consider
the data base encoding that the user intended....

The user in multi-byte country can try this.
http://inet.winpg.jp/~saito/pg_bug/MessageCheck.c

That is, it is likely to become it in this manner.(Japanese)
http://inet.winpg.jp/~saito/pg_bug/FormatMessage998.png

Hiroshi Saito
2006-12-04 22:24:04 +00:00
Teodor Sigaev
e72ef41d72 Fix core dump of ispell for case of non-successfull initialization.
Previous versions aren't affected.

Fix synonym dictionary init: string should be malloc'ed, not palloc'ed. Bug
introduced recently while fixing lowerstr().
2006-12-04 09:27:45 +00:00
Tom Lane
7f676624f6 Fix LIMIT/OFFSET for null limit values. This worked before 8.2 but was broken
by the change to make limit values int8 instead of int4.  (Specifically, you
can do DatumGetInt32 safely on a null value, but not DatumGetInt64.)  Per
bug #2803 from Greg Johnson.
2006-12-03 21:40:13 +00:00
Bruce Momjian
dca4d77798 Update 8.2.X release to say 8.2.0 instead of just 8.2. 2006-12-03 16:43:05 +00:00
PostgreSQL Daemon
2f52d7260c v8.2.0 is now released ... 2006-12-02 08:36:41 +00:00
Bruce Momjian
f8660e309d Stamp 8.2, except configure.in. 2006-12-02 04:12:39 +00:00
Bruce Momjian
73500fd8b5 Update for release 8.2. 2006-12-02 04:12:11 +00:00
Peter Eisentraut
579c58761c Wording refinement for external references in man pages. 2006-12-02 01:26:19 +00:00
Peter Eisentraut
b9dbb63e48 Don't ship spi_* man pages. (We don't do that anyway, but now it's automatic.) 2006-12-02 01:25:50 +00:00
Peter Eisentraut
339483928d Translation updates 2006-12-02 01:16:16 +00:00
Tom Lane
ceb1cc90e3 Put release date in release notes. 2006-12-02 00:46:46 +00:00
Tom Lane
606b10f959 Add some documentation for DTrace support. Simon Riggs 2006-12-02 00:42:54 +00:00
Peter Eisentraut
d92b939a0a Make Options for Windows a second-level heading instead of first-level. 2006-12-02 00:34:52 +00:00
Tom Lane
08fa6a6851 Editorial improvements for GIN documentation. 2006-12-01 23:46:46 +00:00
Tom Lane
a88ec7b4bb Some more supported-platforms updates: buildfarm hare is alive again,
and penguin reported in recently enough to justify the assumption that
we haven't broken ARM support in 8.2.
2006-12-01 21:17:51 +00:00
Tom Lane
c184470be3 Document the recently-understood hazard that a rollback can release row-level
locks that logically should not be released, because when a subtransaction
overwrites XMAX all knowledge of the previous lock state is lost.  It seems
unlikely that we will be able to fix this before 8.3...
2006-12-01 20:49:53 +00:00
Tom Lane
3049fe7cfa Make the bgwriter's error recovery path do smgrcloseall(). On Windows this
should allow delete-pending files to actually go away, and thereby work
around the various complaints we've seen about 'permission denied'
errors in such cases.  Should be reasonably harmless in any case...
2006-12-01 19:55:28 +00:00
Tom Lane
b02414bb82 Editorial improvements to backup and warm-standby documentation. 2006-12-01 03:29:15 +00:00
Tom Lane
f378ccc261 Minor wording improvements. 2006-12-01 03:19:48 +00:00
Tom Lane
da6daee216 Adjust the description of locking to clarify that locks held by a
subtransaction are released if the subtransaction aborts --- in user-level
terminology, this means either rolling back to a savepoint or escaping from
a plpgsql exception block.  Per recent suggestion from Simon.
2006-12-01 01:04:36 +00:00
Tom Lane
746330e2d0 Better solution to the tr problem: use sed instead. Per Martijn and Andrew. 2006-11-30 22:21:24 +00:00
Tom Lane
7ac9d45f49 Improve portability of 'tr' invocation in PGAC_ARG_CHECK. Reported by
Olivier Prenant, fixed by Peter.
2006-11-30 21:44:12 +00:00
Tom Lane
cd99debb3d Update supported-platforms list based on recent buildfarm results. 2006-11-30 21:30:22 +00:00
Peter Eisentraut
f1e3e3238d Fix typos 2006-11-30 20:50:44 +00:00
Tom Lane
5f60086e10 Minor adjustments to make failures in startup/shutdown behave more cleanly.
StartupXLOG and ShutdownXLOG no longer need to be critical sections, because
in all contexts where they are invoked, elog(ERROR) would be translated to
elog(FATAL) anyway.  (One change in bgwriter.c is needed to make this true:
set ExitOnAnyError before trying to exit.  This is a good fix anyway since
the existing code would have gone into an infinite loop on elog(ERROR) during
shutdown.)  That avoids a misleading report of PANIC during semi-orderly
failures.  Modify the postmaster to include the startup process in the set of
processes that get SIGTERM when a fast shutdown is requested, and also fix it
to not try to restart the bgwriter if the bgwriter fails while trying to write
the shutdown checkpoint.  Net result is that "pg_ctl stop -m fast" does
something reasonable for a system in warm standby mode, and so should Unix
system shutdown (ie, universal SIGTERM).  Per gripe from Stephen Harris and
some corner-case testing of my own.
2006-11-30 18:29:12 +00:00
Teodor Sigaev
ef148d6b85 Fix bug with page deletion. If inner page is removed and it tries to
remove page on next level linked from next inner page, ginScanToDelete()
wrongly sets parent page. Bug reveals when many item pointers from index
was deleted ( several hundred thousands).

Bug is discovered by hubert depesz lubaczewski <depesz@gmail.com>

Suppose, we need rc2 before release...
2006-11-30 16:22:32 +00:00
Alvaro Herrera
cf06c2e5d4 Fix Makefile problem which prevented installation on VPATH builds. 2006-11-29 21:21:03 +00:00
Tom Lane
59cf88da91 Ignore libedit/libreadline while probing for strlcpy and some other
standard functions.  Per report from Stefan Kaltenbrunner.
2006-11-29 20:12:31 +00:00
Tom Lane
ae8c1bea02 More MSVC build support from Magnus. 2006-11-29 19:49:31 +00:00