Commit Graph

24182 Commits

Author SHA1 Message Date
Bruce Momjian
99be3fa3ee Add URL for:
o Fix RENAME to work on variables other than OLD/NEW
> 		  http://archives.postgresql.org/pgsql-hackers/2007-01/msg01587.php
2007-02-02 21:34:39 +00:00
Neil Conway
b587bafef1 This patch changes the installscript for vcbuild to actually parse the
generated solution files for what to install, instead of blindly copying
everything as it previously did. With the previous quick-n-dirty
version, it would copy old DLLs if you reconfigured in a way that didn't
include subprojects like a PL for example.

Magnus Hagander.
2007-02-02 16:25:34 +00:00
Neil Conway
ee84009cb0 Reword suggestion that libpq.dll be installed in WINNT\SYSTEM32 under
Windows. Per Magnus Hagander, this is not recommended.
2007-02-02 16:10:08 +00:00
Michael Meskes
685523c420 Applied Magnus Hagander's patch to take away some compiler warnings. 2007-02-02 09:31:10 +00:00
Michael Meskes
fc8115d42f Cleaned up va_list handling. Hopefully this now works on all archs. 2007-02-02 08:58:23 +00:00
Bruce Momjian
98df90013f Add:
> 	o Allow column display reordering by recording a display,
> 	  storage, and permanent id for every column?
>
> 	  http://archives.postgresql.org/pgsql-hackers/2006-12/msg00782.php
>
2007-02-02 05:42:56 +00:00
Tom Lane
bd01a4e3b7 Update release notes for security-related releases in all active branches.
Security: CVE-2007-0555, CVE-2007-0556
2007-02-02 00:10:23 +00:00
Tom Lane
5413eef8dc Repair failure to check that a table is still compatible with a previously
made query plan.  Use of ALTER COLUMN TYPE creates a hazard for cached
query plans: they could contain Vars that claim a column has a different
type than it now has.  Fix this by checking during plan startup that Vars
at relation scan level match the current relation tuple descriptor.  Since
at that point we already have at least AccessShareLock, we can be sure the
column type will not change underneath us later in the query.  However,
since a backend's locks do not conflict against itself, there is still a
hole for an attacker to exploit: he could try to execute ALTER COLUMN TYPE
while a query is in progress in the current backend.  Seal that hole by
rejecting ALTER TABLE whenever the target relation is already open in
the current backend.

This is a significant security hole: not only can one trivially crash the
backend, but with appropriate misuse of pass-by-reference datatypes it is
possible to read out arbitrary locations in the server process's memory,
which could allow retrieving database content the user should not be able
to see.  Our thanks to Jeff Trout for the initial report.

Security: CVE-2007-0556
2007-02-02 00:07:03 +00:00
Tom Lane
f8eb75b673 Repair insufficiently careful type checking for SQL-language functions:
we should check that the function code returns the claimed result datatype
every time we parse the function for execution.  Formerly, for simple
scalar result types we assumed the creation-time check was sufficient, but
this fails if the function selects from a table that's been redefined since
then, and even more obviously fails if check_function_bodies had been OFF.

This is a significant security hole: not only can one trivially crash the
backend, but with appropriate misuse of pass-by-reference datatypes it is
possible to read out arbitrary locations in the server process's memory,
which could allow retrieving database content the user should not be able
to see.  Our thanks to Jeff Trout for the initial report.

Security: CVE-2007-0555
2007-02-02 00:02:55 +00:00
Tom Lane
dc4c26c37e Fix broken markup. 2007-02-01 22:06:14 +00:00
Bruce Momjian
f7e5ecb026 Add "May/Can/Might" section to error message style guidlines, and
"can't" -> "cannot" section.
2007-02-01 21:28:34 +00:00
Neil Conway
2576dd4dee Fix two more regression tests whose expected outputs were not updated
for the recent may/might cleanup.
2007-02-01 21:05:29 +00:00
Bruce Momjian
52096ae119 Mention file system replication as a high availability solution in the
shared hardware section, and mention DRBD as a popular solution.
2007-02-01 21:02:48 +00:00
Tom Lane
a9d5fb5a02 Typo fix. 2007-02-01 20:28:08 +00:00
Neil Conway
d596efac56 Update some of the "expected" regression test results for Bruce's
recent may/might cleanup, in the hopes that this will unbreak the
buildfarm. Per report from Stefan Kaltenbrunner.
2007-02-01 20:11:18 +00:00
Tom Lane
6994d0b891 Fix plpgsql so that when a local variable has no initial-value expression,
an error will be thrown correctly if the variable is of a NOT NULL domain.
Report and almost-correct fix from Sergiy Vyshnevetskiy (bug #2948).
2007-02-01 19:22:07 +00:00
Bruce Momjian
db047e571d Add URL for:
o Add long file support for binary pg_dump output
>
> 	  http://archives.postgresql.org/pgsql-hackers/2006-12/msg00551.php
2007-02-01 19:13:56 +00:00
Bruce Momjian
8b4ff8b6a1 Wording cleanup for error messages. Also change can't -> cannot.
Standard English uses "may", "can", and "might" in different ways:

        may - permission, "You may borrow my rake."

        can - ability, "I can lift that log."

        might - possibility, "It might rain today."

Unfortunately, in conversational English, their use is often mixed, as
in, "You may use this variable to do X", when in fact, "can" is a better
choice.  Similarly, "It may crash" is better stated, "It might crash".
2007-02-01 19:10:30 +00:00
Neil Conway
baaec74c5a Fix broken markup. 2007-02-01 07:00:32 +00:00
Bruce Momjian
f1b68860bc Add 8.2.0 "Incomatibilities" documentation that pg_dump's -n and -t
behavior has changed.
2007-02-01 05:12:24 +00:00
Bruce Momjian
969320c8b8 Chinese FAQ update
Daojing.Zhou
2007-02-01 04:55:53 +00:00
Bruce Momjian
a867c5aa2f Update URL for function permission checks
<   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00564.php
>   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00568.php
>
2007-02-01 04:51:31 +00:00
Bruce Momjian
2ccb40b532 Add:
>
> * Tighten function permission checks
>
>   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00564.php
>
2007-02-01 04:50:58 +00:00
Bruce Momjian
fa3f06dc6b Add:
>
> * Tighten trigger permission checks
>
>   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00564.php
>
2007-02-01 04:49:43 +00:00
Neil Conway
bd2c171414 This patch adds documentation for the long-version parameters --username
and --password for pg_dump, pg_dumpall and pg_restore, per complaint by
Michael Schmidt. Patch from Magnus Hagander.
2007-02-01 04:39:33 +00:00
Bruce Momjian
e665137250 Add:
>
> * Fix problem when multiple subtransactions of the same outer transaction
>   hold different types of locks, and one subtransaction aborts
>
>   http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
>   http://archives.postgresql.org/pgsql-hackers/2006-12/msg00001.php
2007-02-01 04:35:52 +00:00
Neil Conway
dbcaee49b5 Fix a few typos in comments in GiN. 2007-02-01 04:16:08 +00:00
Bruce Momjian
b3687889c4 Update CREATE SEQUENCE documentation to show the same sequence being
created and increments.  The old docs created the sequence, then showed
a nextval() of 114.
2007-02-01 00:34:03 +00:00
Bruce Momjian
40bf8717cf Add URL for:
o Fix RENAME to work on variables other than OLD/NEW
>       http://archives.postgresql.org/pgsql-hackers/2007-01/msg01615.php
2007-02-01 00:32:45 +00:00
Bruce Momjian
09a9f10e7f Consistenly use colons before '<programlisting>' blocks, where
appropriate.
2007-02-01 00:28:19 +00:00
Bruce Momjian
e81c138e18 Update reference documentation on may/can/might:
Standard English uses "may", "can", and "might" in different ways:

        may - permission, "You may borrow my rake."

        can - ability, "I can lift that log."

        might - possibility, "It might rain today."

Unfortunately, in conversational English, their use is often mixed, as
in, "You may use this variable to do X", when in fact, "can" is a better
choice.  Similarly, "It may crash" is better stated, "It might crash".
2007-01-31 23:26:05 +00:00
Bruce Momjian
bc799fab2b Update comment. 2007-01-31 22:17:03 +00:00
Bruce Momjian
482e6936fa Revert error message change for may/can/might --- needs discussion. 2007-01-31 21:03:37 +00:00
Bruce Momjian
a134ee3379 Update documentation on may/can/might:
Standard English uses "may", "can", and "might" in different ways:

        may - permission, "You may borrow my rake."

        can - ability, "I can lift that log."

        might - possibility, "It might rain today."

Unfortunately, in conversational English, their use is often mixed, as
in, "You may use this variable to do X", when in fact, "can" is a better
choice.  Similarly, "It may crash" is better stated, "It might crash".

Also update two error messages mentioned in the documenation to match.
2007-01-31 20:56:20 +00:00
Neil Conway
67a1ae9f05 Add missing Makefile dependencies for the "bigtest" and "bigcheck"
targets, and refactor the tablespace setup code into a separate
Makefile target.
2007-01-31 19:38:50 +00:00
Neil Conway
05ce7d6a41 Rewrite uuid input and output routines to avoid dependency on the
nonportable "hh" sprintf(3) length modifier. Instead, do the parsing
and output by hand. The code to do this isn't ideal, but this is
an interim measure anyway: the uuid type should probably use the
in-memory struct layout specified by RFC 4122. For now, this patch
should hopefully rectify the buildfarm failures for the uuid test.

Along the way, re-add pg_cast entries for uuid <-> varchar, which
I mistakenly removed earlier, and bump the catversion.
2007-01-31 19:33:54 +00:00
Tom Lane
068bf6534f Fix initdb to not generate misleading error messages when postgres.bki
or other share-directory files are inaccessible for some reason other
than not existing.  Inspired by trouble report from Simon Kinsella.
2007-01-31 18:52:49 +00:00
Teodor Sigaev
61f621b506 Revert gincostestimate changes. 2007-01-31 16:54:51 +00:00
Teodor Sigaev
b62f85691e Update FreeBSD DocBook installation notices 2007-01-31 15:23:28 +00:00
Teodor Sigaev
d4c6da1527 Allow GIN's extractQuery method to signal that nothing can satisfy the query.
In this case extractQuery should returns -1 as nentries. This changes
prototype of extractQuery method to use int32* instead of uint32* for
nentries argument.
Based on that gincostestimate may see two corner cases: nothing will be found
or seqscan should be used.

Per proposal at http://archives.postgresql.org/pgsql-hackers/2007-01/msg01581.php

PS tsearch_core patch should be sightly modified to support changes, but I'm
waiting a verdict about reviewing of tsearch_core patch.
2007-01-31 15:09:45 +00:00
Bruce Momjian
147a3ce149 Add URL:
o Fix RENAME to work on variables other than OLD/NEW
>
> 		  http://archives.postgresql.org/pgsql-hackers/2002-03/msg00591.php
>
2007-01-31 04:23:47 +00:00
Bruce Momjian
0867493510 Document need for periodic REINDEX in VACUUM FULL cases. 2007-01-31 04:13:22 +00:00
Bruce Momjian
1a62813464 Add missing colon. 2007-01-31 04:12:01 +00:00
Bruce Momjian
99507b9a92 Add:
>
> * Add REINDEX CONCURRENTLY, like CREATE INDEX CONCURRENTLY
>
>   This is difficult because you must upgrade to an exclusive table lock
>   to replace the existing index file.  CREATE INDEX CONCURRENTLY does not
>   have this complication.  This would allow index compaction without
>   downtime.
2007-01-31 03:17:49 +00:00
Bruce Momjian
62b2786b82 Update for VACUUM FULL:
<   reindex rather than update the index.
>   reindex rather than update the index.  Also, index updates can
>   bloat the index.
2007-01-31 03:07:36 +00:00
Bruce Momjian
aca00a8b98 Add:
> 	o ARRAY[[1,2],[3,4]])[1] should return the same values as
> 	  ARRAY[[1,2],[3,4]])[1:1];
>
2007-01-30 22:55:12 +00:00
Bruce Momjian
91a753f68b Add FAQ item about timezones and daylight savings time. 2007-01-30 22:37:15 +00:00
Bruce Momjian
4ed9f1d9b7 Update documentation for backslashes to mention escape string syntax
more, and standard_conforming_strings less, because in the future non-E
strings will not treat backslashes specially.

Also use E'' strings where backslashes are used in examples. (The
existing examples would have drawn warnings.)

Backpatch to 8.2.X.
2007-01-30 22:29:23 +00:00
Tom Lane
35b039a26c Repair oversights in the mechanism used to store compiled plpgsql functions.
The original coding failed (tried to access deallocated memory) if there were
two active call sites (fn_extra pointers) for the same function and the
function definition was updated.  Also, if an update of a recursive function
was detected upon nested entry to the function, the existing compiled version
was summarily deallocated, resulting in crash upon return to the outer
instance.  Problem observed while studying a bug report from Sergiy
Vyshnevetskiy.

Bug does not exist before 8.1 since older versions just leaked the memory of
obsoleted compiled functions, rather than trying to reclaim it.
2007-01-30 22:05:13 +00:00
Tom Lane
33d78c9e48 Add SPI_push/SPI_pop calls so that datatype input and output functions called
by plpgsql can themselves use SPI --- possibly indirectly, as in the case
of domain_in() invoking plpgsql functions in a domain check constraint.
Per bug #2945 from Sergiy Vyshnevetskiy.

Somewhat arbitrarily, I've chosen to back-patch this as far as 8.0.  Given
the lack of prior complaints, it doesn't seem critical for 7.x.
2007-01-30 18:02:22 +00:00