Commit Graph

23585 Commits

Author SHA1 Message Date
Tom Lane
7feedda098 Marginal code cleanups in pg_logdir_ls: use ReadDir not readdir,
and avoid scribbling on its result (might be safe but why risk it)
2006-10-20 00:59:03 +00:00
Tom Lane
33af087695 Try to fix the AIX getaddrinfo mess in a way that works on all versions.
Going to wait for buildfarm results before backpatching, this time.
2006-10-19 23:17:39 +00:00
Tom Lane
0549ba82e3 Clarify note about interaction of log_statement logging with errors.
Remove obsolete note about logging of statements generated by plpgsql
function execution ... that doesn't happen anymore.
2006-10-19 22:55:25 +00:00
Tom Lane
1b84441a49 Marginal improvement in logging: include the function name when logging
a fastpath function call.
2006-10-19 22:44:11 +00:00
Tom Lane
4887f5f979 Rename our substitute qsort to pg_qsort at the link-symbol level (but
provide a macro so code can still just say qsort).  Avoids linker warnings
on pickier platforms such as Darwin, and outright failure on MSVC.
2006-10-19 20:56:22 +00:00
Tom Lane
443abd83e5 Add externs for optarg/optind where apparently needed. Per Magnus. 2006-10-19 20:38:48 +00:00
Tom Lane
28997903a1 Handle missing M_PI the same way we've been doing in the core code,
instead of inserting an MSVC dependency.
2006-10-19 20:08:03 +00:00
Tom Lane
f6e00ae128 Further MSVC portability fixes from Magnus. 2006-10-19 20:03:08 +00:00
Bruce Momjian
6bc1f9b334 Remove qsort TODO.detail. All items completed. 2006-10-19 19:59:06 +00:00
Bruce Momjian
a60af96a00 Done:
< * Improve port/qsort() to handle sorts with 50% unique and 50% duplicate
<   value [qsort]
<
<   This involves choosing better pivot points for the quicksort.
<
2006-10-19 19:58:45 +00:00
Tom Lane
2315df21f8 Fix a couple of places that were assuming debug_query_string couldn't
be NULL ... seems an unsafe assumption.
2006-10-19 19:53:03 +00:00
Tom Lane
681892208f Make sure that debug_query_string contains the original query text,
if available (which it usually should be), during processing of Bind
and Execute protocol messages.  This improves usefulness of
log_min_error_statement logging for extended query protocol.
2006-10-19 19:52:22 +00:00
Tom Lane
def651f48f Clean up local redeclarations of variables with DLLIMPORT, per report
from Magnus that MSVC complains about this.
2006-10-19 18:32:48 +00:00
Neil Conway
fd38d726a9 Fix typo. 2006-10-19 17:48:04 +00:00
Tom Lane
72ec567a9a Simplify contrib Makefiles by removing unnecessary SRCS macro,
per Magnus.
2006-10-19 17:40:03 +00:00
Tom Lane
dbb397f30f Work around reported problem that AIX's getaddrinfo() doesn't seem to zero
sin_port in the returned IP address struct when servname is NULL.  This has
been observed to cause failure to bind the stats collection socket, and
could perhaps cause other issues too.  Per reports from Brad Nicholson
and Chris Browne.
2006-10-19 17:26:32 +00:00
Tom Lane
1e758d5263 Add some code to CREATE DATABASE to check for pre-existing subdirectories
that conflict with the OID that we want to use for the new database.
This avoids the risk of trying to remove files that maybe we shouldn't
remove.  Per gripe from Jon Lapham and subsequent discussion of 27-Sep.
2006-10-18 22:44:12 +00:00
Tom Lane
877f08da14 Fix up timetz input so that a date is required only when the specified
timezone actually has a daylight-savings rule.  This avoids breaking
cases that used to work because they went through the DecodePosixTimezone
code path.  Per contrib regression failures (mea culpa for not running
those yesterday...).  Also document the already-applied change to allow
GMT offsets up to 14 hours.
2006-10-18 16:43:14 +00:00
Bruce Momjian
723f716be0 Fix array operator refererence in release notes, per David Wheeler. 2006-10-18 03:53:50 +00:00
Tom Lane
022fd99668 Fix up some problems in handling of zic-style time zone names in datetime
input routines.  Remove the former "DecodePosixTimezone" function in favor of
letting the zic code handle POSIX-style zone specs (see tzparse()).  In
particular this means that "PST+3" now means the same as "-03", whereas it
used to mean "-11" --- the zone abbreviation is effectively just a noise word
in this syntax.  Make sure that all named and POSIX-style zone names will be
parsed as a single token.  Fix long-standing bogosities in printing and input
of fractional-hour timezone offsets (since the tzparse() code will accept
these, we'd better make 'em work).  Also correct an error in the original
coding of the zic-zone-name patch: in "timestamp without time zone" input,
zone names are supposed to be allowed but ignored, but the coding was such
that the zone changed the interpretation anyway.
2006-10-17 21:03:21 +00:00
Bruce Momjian
d58f09e6b3 Mark 8.2 release as 2006-??, not 2005-??, per observation by David
Wheeler.
2006-10-17 20:17:08 +00:00
Bruce Momjian
47fecaf504 Attached files fix the link problem in FAQ_DEV.html, remove some parts
related to website development and change the link to the FAQ_DEV.html.

Devrim GUNDUZ
2006-10-17 12:54:45 +00:00
Bruce Momjian
10d9bbaf01 Fixes for CREATE CONSTRAINT manual page.
Michael Paesold
2006-10-17 12:53:03 +00:00
Tom Lane
14914e0d33 Fix unexpected side-effect of changes for case insensitivity of timezone names. 2006-10-17 02:21:46 +00:00
Peter Eisentraut
3e584e071b Remove use of whrandom module, which was removed in Python 2.5. 2006-10-16 21:13:57 +00:00
Tom Lane
0b35b01e7a Arrange for timezone names to be recognized case-insensitively; for
example SET TIME ZONE 'america/new_york' works now.  This seems a good
idea on general user-friendliness grounds, and is part of the solution
to the timestamp-input parsing problems I noted recently.
2006-10-16 19:58:27 +00:00
Bruce Momjian
a2ebf81913 CREATE CONSTRAINT manual page wording improvements.
Michael Paesold
2006-10-16 19:33:12 +00:00
Bruce Momjian
52831f7911 Update to CREATE CONSTRAINT manual page.
Michael Glaesemann
2006-10-16 19:30:09 +00:00
Bruce Momjian
c2e7da1f62 I updated RPM related parts in FAQ_DEV against HEAD to be more current.
Devrim GUNDUZ
2006-10-16 19:03:43 +00:00
Bruce Momjian
389fad1e6b Remove use of '<' and '>' in SGML, use '&' escapes.
Update find_gt_lt to allow grep parameters to be passed into it.
2006-10-16 17:28:03 +00:00
Peter Eisentraut
6ab23dabf5 Punt when trying to build with threaded Python on FreeBSD.
Also cut back on excessive use of *** to decorate configure error messages.
If it's an error message, you are sure to see it without any decoration.
2006-10-16 17:24:54 +00:00
Tom Lane
e0dece127d Redesign the patch for allocation of shmem space and LWLocks for add-on
modules; the first try was not usable in EXEC_BACKEND builds (e.g.,
Windows).  Instead, just provide some entry points to increase the
allocation requests during postmaster start, and provide a dedicated
LWLock that can be used to synchronize allocation operations performed
by backends.  Per discussion with Marc Munro.
2006-10-15 22:04:08 +00:00
Tom Lane
a3dff39c53 Adjust plperl to ensure that all strings and hash keys passed to Perl
are marked as UTF8 when the database encoding is UTF8.  This should
avoid inconsistencies like that exhibited in bug #2683 from Vitali Stupin.
2006-10-15 18:56:39 +00:00
Bruce Momjian
87eed2e3e1 Update Japanese FAQ.
Jun Kuwamura
2006-10-15 03:10:20 +00:00
Bruce Momjian
fdbe9facdc FAQ updates --- This is a small cosmetic patch that adds pt_BR IRC
channel to the lists of IRC channels, fixes a typo in the OID's
question, and corrects the PGCluster's project name.

Euler Taveira de Oliveira
2006-10-14 23:08:48 +00:00
Tom Lane
1314983fd3 Code review for --no-data-for-failed-tables patch. Instead of trashing
one of the program's core data structures, make use of the existing
ability to selectively exclude TOC items by ID.  Slightly more code but
much less likely to create future maintenance problems.
2006-10-14 23:07:22 +00:00
Tom Lane
f58eac82ee Code and docs review for ALTER TABLE INHERIT/NO INHERIT patch. 2006-10-13 21:43:19 +00:00
Peter Eisentraut
e1fdd2263f Make unknown-option-warning code more portable. echo -n is not portable,
and neither is "|" or "\|" in basic regular expressions.
2006-10-13 20:23:07 +00:00
Bruce Momjian
d63ddfb872 Update Japanese FAQ.
Jun Kuwamura
2006-10-13 17:29:43 +00:00
Tom Lane
7de6cf2743 Fix typo in version number. 2006-10-13 15:24:56 +00:00
Bruce Momjian
5777dca4f8 Fix test_fsync compile on MinGW(win32)
Hiroshi Saito
2006-10-13 14:19:29 +00:00
Teodor Sigaev
47df6e7e2d Fix infinite sleep and failes of send in Win32.
1) pgwin32_waitforsinglesocket(): WaitForMultipleObjectsEx now called with
finite timeout (100ms) in case of FP_WRITE and UDP socket. If timeout occurs
then pgwin32_waitforsinglesocket() tries to write empty packet goes to
WaitForMultipleObjectsEx again.

2) pgwin32_send(): add loop around WSASend and pgwin32_waitforsinglesocket().
The reason is: for overlapped socket, 'ok' result from
pgwin32_waitforsinglesocket() isn't guarantee that socket is still free,
it can become busy again and following WSASend call will fail with
WSAEWOULDBLOCK error.

See http://archives.postgresql.org/pgsql-hackers/2006-10/msg00561.php
2006-10-13 13:59:47 +00:00
Bruce Momjian
efa0e8639f Remove:
< 	o Issue a notice if CREATE TABLE ... ON COMMIT { DELETE ROWS |
< 	  DROP } is issued outside a multi-statement transaction
2006-10-12 22:33:04 +00:00
Bruce Momjian
ab1cec93c5 Add url's for hints:
>   http://archives.postgresql.org/pgsql-hackers/2006-10/msg00517.php
>   http://archives.postgresql.org/pgsql-hackers/2006-10/msg00663.php
2006-10-12 21:40:15 +00:00
Bruce Momjian
5ee7c794c7 Add:
> 	o Issue a notice if CREATE TABLE ... ON COMMIT { DELETE ROWS |
> 	  DROP } is issued outside a multi-statement transaction
2006-10-12 21:29:24 +00:00
Neil Conway
bfc6e9c970 Make some incremental improvements and fixes to the documentation on
Continuous Archiving. Plenty of editorial work remains...
2006-10-12 19:38:08 +00:00
Tom Lane
0c9983889a Update release notes for SQL functions vs triggers fix. 2006-10-12 19:25:12 +00:00
Neil Conway
7055867a01 In the installation docs, add some links to the documentation on LDAP
to the discussion of the "--with-ldap" configure option. Patch from
Albe Laurenz.
2006-10-12 18:49:32 +00:00
Tom Lane
d2e17e1ddc Fix mishandling of after-trigger state when a SQL function returns multiple
rows --- if the surrounding query queued any trigger events between the rows,
the events would be fired at the wrong time, leading to bizarre behavior.
Per report from Merlin Moncure.

This is a simple patch that should solve the problem fully in the back
branches, but in HEAD we also need to consider the possibility of queries
with RETURNING clauses.  Will look into a fix for that separately.
2006-10-12 17:02:24 +00:00
Tom Lane
b38900c767 Use Min() instead of min() in qsort, for consistency and to avoid
redefined-macro warnings on some platforms.  Per gripe from Hiroshi Saito.
2006-10-12 15:04:55 +00:00