Commit Graph

25142 Commits

Author SHA1 Message Date
Andrew Dunstan
63872601e8 Move session_start out of MyProcPort stucture and make it a global called MyStartTime,
so that we will be able to create a cookie for all processes for CSVlogs.
It is set wherever MyProcPid is set. Take the opportunity to remove the now
unnecessary session-only restriction on the %s and %c escapes in log_line_prefix.
2007-08-02 23:39:45 +00:00
Andrew Dunstan
b34903453f Make sure syslogPipe runs in binary mode on Windows to avoid corrupting the pipe chunking protocol. Backport to 8.0 2007-08-02 23:15:27 +00:00
Neil Conway
494d6f809e Fix a memory leak in tuplestore_end(). Unlikely to be significant during
normal operation, but tuplestore_end() ought to do what it claims to do.
2007-08-02 17:48:52 +00:00
Bruce Momjian
c441e26ee8 Done:
< * Allow buffered WAL writes and fsync
2007-08-01 23:13:31 +00:00
Tom Lane
4a78cdeb6b Support an optional asynchronous commit mode, in which we don't flush WAL
before reporting a transaction committed.  Data consistency is still
guaranteed (unlike setting fsync = off), but a crash may lose the effects
of the last few transactions.  Patch by Simon, some editorialization by Tom.
2007-08-01 22:45:09 +00:00
Bruce Momjian
c722628a43 Fix strange quoting. 2007-08-01 22:24:32 +00:00
Bruce Momjian
4f49621aef Fix script quoting problem. 2007-08-01 22:23:01 +00:00
Bruce Momjian
3bc619342f Remove links to old Win32 source code ports. 2007-08-01 00:24:55 +00:00
Tom Lane
ed5d55dafe Fix a bug in the original implementation of redundant-join-clause removal:
clauses in which one side or the other references both sides of the join
cannot be removed as redundant, because that expression won't have been
constrained below the join.  Per report from Sergey Burladyan.

CVS HEAD does not contain this bug due to EquivalenceClass rewrite, but it
seems wise to include the regression test for it anyway.
2007-07-31 19:53:37 +00:00
Tom Lane
bc421c35b1 If we're gonna use ExecRelationIsTargetRelation here, might as well
simplify a bit further.
2007-07-31 16:36:07 +00:00
Tom Lane
310578efee Fix security definer functions with polymorphic arguments. This case has
never worked because fmgr_security_definer() neglected to pass the fn_expr
information through.  Per report from Viatcheslav Kalinin.
2007-07-31 15:49:49 +00:00
Neil Conway
dffad02856 Slight refactor for ExecOpenScanRelation(): we can use
ExecRelationIsTargetRelation() to check if the relation is a target
rel, rather than scanning through the result relation array ourselves.
2007-07-27 19:09:04 +00:00
Peter Eisentraut
dc6dc0f63a Update conformance information about bigint type
found by Michael Glaesemann
2007-07-27 10:37:52 +00:00
Tom Lane
e4f4a7f5a4 Remove FileUnlink(), which wasn't being used anywhere and interacted poorly
with the recent patch to log temp file sizes at removal time.  Doesn't seem
worth fixing since it's unused.
In passing, make a few elog messages conform to the message style guide.
2007-07-26 15:15:18 +00:00
Tom Lane
82eed4dba2 Arrange to put TOAST tables belonging to temporary tables into special schemas
named pg_toast_temp_nnn, alongside the pg_temp_nnn schemas used for the temp
tables themselves.  This allows low-level code such as the relcache to
recognize that these tables are indeed temporary, which enables various
optimizations such as not WAL-logging changes and using local rather than
shared buffers for access.  Aside from obvious performance benefits, this
provides a solution to bug #3483, in which other backends unexpectedly held
open file references to temporary tables.  The scheme preserves the property
that TOAST tables are not in any schema that's normally in the search path,
so they don't conflict with user table names.

initdb forced because of changes in system view definitions.
2007-07-25 22:16:18 +00:00
Tom Lane
fdb5b69e9c Suppress warning when compiling with -DPROFILE_PID_DIR: sys/stat.h is
supposed to be included when using mkdir().
2007-07-25 19:58:56 +00:00
Tom Lane
3eb98fd165 Adjust horology test to avoid join-plan-dependent result ordering in
a few queries.  Should fix buildfarm failures arising from new,
more aggressive autovac settings.
2007-07-25 17:22:37 +00:00
Michael Meskes
a1b336679c Synced parser 2007-07-25 16:10:41 +00:00
Magnus Hagander
906b2e1b37 Rename DLLIMPORT macro to PGDLLIMPORT to avoid conflict with
third party includes (like tcl) that define DLLIMPORT.
2007-07-25 12:22:54 +00:00
Magnus Hagander
5cbb11928e Fix standalone win32 makefile (MSVC6) for SSPI and GSSAPI.
Hiroshi Saito
2007-07-25 11:37:25 +00:00
Magnus Hagander
dff6797ce5 Disable warning 4090 = different const qualifiers on msvc since it
warns about things that aren't wrong.
2007-07-25 10:51:03 +00:00
Magnus Hagander
430d0829ae Silence compiler warnings on mingw 2007-07-25 10:17:46 +00:00
Neil Conway
b2b9b4d59c Implement RETURN QUERY for PL/PgSQL. This provides some convenient syntax
sugar for PL/PgSQL set-returning functions that want to return the result
of evaluating a query; it should also be more efficient than repeated
RETURN NEXT statements. Based on an earlier patch from Pavel Stehule.
2007-07-25 04:19:09 +00:00
Tom Lane
507b53c833 Fix predicate-proving logic to cope with binary-compatibility cases when
checking whether an IS NULL/IS NOT NULL clause is implied or refuted by
a strict function.  Per example from Dawid Kuroczko.
Backpatch to 8.2 since this is arguably a performance bug.
2007-07-24 17:22:07 +00:00
Magnus Hagander
f903278e2d Silence compiler warning on mingw 2007-07-24 11:16:36 +00:00
Magnus Hagander
d602592494 Make it possible, and default, for MingW to build with SSPI support
by dynamically loading the function that's missing from the MingW
headers and library.
2007-07-24 09:00:27 +00:00
Tom Lane
ad4295728e Create a new dedicated Postgres process, "wal writer", which exists to write
and fsync WAL at convenient intervals.  For the moment it just tries to
offload this work from backends, but soon it will be responsible for
guaranteeing a maximum delay before asynchronously-committed transactions
will be flushed to disk.

This is a portion of Simon Riggs' async-commit patch, committed to CVS
separately because a background WAL writer seems like it might be a good idea
independently of the async-commit feature.  I rebased walwriter.c on
bgwriter.c because it seemed like a more appropriate way of handling signals;
while the startup/shutdown logic in postmaster.c is more like autovac because
we want walwriter to quit before we start the shutdown checkpoint.
2007-07-24 04:54:09 +00:00
Alvaro Herrera
53d2951be7 Set a default autovacuum vacuum_cost_delay value of 20ms, to avoid excessive
I/O utilization, per discussion.

While at it, lower the autovacuum vacuum and analyze threshold values to 50
tuples.  It is a bit higher (i.e. more conservative) than what I originally
proposed but much better than the old values for small tables.
2007-07-24 01:53:56 +00:00
Tom Lane
ab7d2b6a73 Just noticed that libpq thinks the maximum command tag length is 40,
whereas in the backend it's been 64 for some time.  Hasn't mattered
because no actual tags exceed 40 bytes, but for consistency they should
be alike.
2007-07-23 18:59:50 +00:00
Magnus Hagander
29ac718f47 Use PQExpBuffer for error message in fe-auth.c.
In passing, change functions that passedin both PGconn and
parts of it to just pass in the PGconn.
2007-07-23 17:52:06 +00:00
Alvaro Herrera
aa81c558ee Reword paragraph about the autovacuum_max_workers setting. Patch from
Jim Nasby.
2007-07-23 17:22:00 +00:00
Magnus Hagander
b9ab88243e Stupid typo. 2007-07-23 10:57:36 +00:00
Magnus Hagander
f70866fb23 SSPI authentication on Windows. GSSAPI compatible client when doing Kerberos
against a Unix server, and Windows-specific server-side authentication
using SSPI "negotiate" method (Kerberos or NTLM).

Only builds properly with MSVC for now.
2007-07-23 10:16:54 +00:00
Tom Lane
a0dab332a2 Fix elog.c to avoid infinite recursion (leading to backend crash) when
log_min_error_statement is active and there is some problem in logging the
current query string; for example, that it's too long to include in the log
message without running out of memory.  This problem has existed since the
log_min_error_statement feature was introduced.  No doubt the reason it
wasn't detected long ago is that 8.2 is the first release that defaults
log_min_error_statement to less than PANIC level.
Per report from Bill Moran.
2007-07-21 22:12:04 +00:00
Tom Lane
ddb93cac24 Provide a bit more high-level documentation for the GEQO planner.
Per request from Luca Ferrari.
2007-07-21 04:02:41 +00:00
Peter Eisentraut
7abe764f17 Fix regression tests for PL/pgSQL error message changes 2007-07-20 16:38:38 +00:00
Tom Lane
04fbe29a83 Fix WAL replay of truncate operations to cope with the possibility that the
truncated relation was deleted later in the WAL sequence.  Since replay
normally auto-creates a relation upon its first reference by a WAL log entry,
failure is seen only if the truncate entry happens to be the first reference
after the checkpoint we're restarting from; which is a pretty unusual case but
of course not impossible.  Fix by making truncate entries auto-create like
the other ones do.  Per report and test case from Dharmendra Goyal.
2007-07-20 16:29:53 +00:00
Peter Eisentraut
ebb5436d70 Capitalize language key words in error messages 2007-07-20 16:23:34 +00:00
Tom Lane
f812dd91fe On second thought, the tests for what to do with stderr output are a
lot more sensible if we check the chunk-output case first.  Not
back-patched since it's just a cosmetic improvement.
2007-07-19 21:58:12 +00:00
Tom Lane
4ca7a2dacb Make replace(), split_part(), and string_to_array() behave somewhat sanely
when handed an invalidly-encoded pattern.  The previous coding could get
into an infinite loop if pg_mb2wchar_with_len() returned a zero-length
string after we'd tested for nonempty pattern; which is exactly what it
will do if the string consists only of an incomplete multibyte character.
This led to either an out-of-memory error or a backend crash depending
on platform.  Per report from Wiktor Wodecki.
2007-07-19 20:34:20 +00:00
Andrew Dunstan
0e5b4f0e23 Only use the pipe chunking protocol if we know the syslogger should
be catching stderr output, and we are not ourselves the
syslogger. Otherwise, go directly to stderr.
Bug noticed by Tom Lane.
Backpatch as far as 8.0.
2007-07-19 19:13:43 +00:00
Tom Lane
177be3f9bb Adjust configure script to print the bison and flex versions in use.
Minor rearrangements to make a few tests in a more logical order.
2007-07-19 17:15:30 +00:00
Tom Lane
d514ea3fda Fix an old thinko in SS_make_initplan_from_plan, which is used when optimizing
a MIN or MAX aggregate call into an indexscan: the initplan is being made at
the current query nesting level and so we shouldn't increment query_level.
Though usually harmless, this mistake could lead to bogus "plan should not
reference subplan's variable" failures on complex queries.  Per bug report
from David Sanchez i Gregori.
2007-07-18 21:40:57 +00:00
Alvaro Herrera
cdedfe6af1 Cast NULL to a pointer type in the execl() call, to avoid a compiler warning on
some platforms and possibly a bug.  Per report from Stefan and subsequent
discussion.
2007-07-18 21:19:17 +00:00
Magnus Hagander
dc32d2cefa GSSAPI documentation 2007-07-18 12:00:47 +00:00
Bruce Momjian
9e19063abc Document that 'deleted' is also tracked by autovacuum. 2007-07-18 03:39:01 +00:00
Bruce Momjian
b6ed78b2bd Properly adjust age() seconds to match the sign of the larger units.
Patch from Tom.
2007-07-18 03:13:13 +00:00
Bruce Momjian
df7128bd34 Document that age() adds days, then full months. 2007-07-18 03:12:42 +00:00
Bruce Momjian
27d074923d Add:
>
> 	o Allow GLOBAL temporary tables to exist as empty by default in
> 	  all sessions
>
> 	  http://archives.postgresql.org/pgsql-hackers/2007-07/msg00006.php
>
2007-07-18 00:16:21 +00:00
Tom Lane
2c535bfe81 Fix incorrect optimization of foreign-key checks. When an UPDATE on the
referencing table does not change the tuple's FK column(s), we don't bother
to check the PK table since the constraint was presumably already valid.
However, the check is still necessary if the tuple was inserted by our own
transaction, since in that case the INSERT trigger will conclude it need not
make the check (since its version of the tuple has been deleted).  We got this
right for simple cases, but not when the insert and update are in different
subtransactions of the current top-level transaction; in such cases the FK
check would never be made at all.  (Hence, problem dates back to 8.0 when
subtransactions were added --- it's actually the subtransaction version of a
bug fixed in 7.3.5.)  Fix, and add regression test cases.  Report and fix by
Affan Salman.
2007-07-17 17:45:28 +00:00