mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity
31,734 Commits 37 Branches 638 Tags 395 MiB
001cbb145f
Commit Graph

151 Commits

Author SHA1 Message Date
Bruce Momjian
6e6bee987f In pg_upgrade, remove use of whichCluster, and just pass old/new cluster 
pointers, which simplifies the code.  This was not possible in 9.0 because
everything was in a single nested struct, but is possible now.

Per suggestion from Tom.
 2011-01-01 12:06:36 -05:00
Bruce Momjian
f82b3e58f8 In pg_upgrade, rename "CLUSTERNAME" to "CLUSTER_NAME". 2010-12-31 20:42:29 -05:00
Tom Lane
88c803457a Improve pg_upgrade's checks for required executables. 
Don't insist on pg_dumpall and psql being present in the old cluster,
since they are not needed.  Do insist on pg_resetxlog being present
(in both old and new), since we need it.  Also check for pg_config,
but only in the new cluster.  Remove the useless attempt to call
pg_config in the old cluster; we don't need to know the old value of
--pkglibdir.  (In the case of a stripped-down migration installation
there might be nothing there to look at anyway, so any future change
that might reintroduce that need would have to be considered carefully.)

Per my attempts to build a minimal previous-version installation to support
pg_upgrade.
 2010-12-29 13:43:53 -05:00
Bruce Momjian
16b5e08dec Use "upgrade" in preference over "migrate" in pg_upgrade messages and 
documentation.  (Many were left over from the old pg_migrator naming.)
 2010-12-15 07:11:31 -05:00
Tom Lane
3864afa1d1 Clean up some copied-and-pasted code in pg_upgrade. 
1. Don't reimplement S_ISDIR() and S_ISREG() badly.
2. Don't reimplement access() badly.

This code appears to have been copied from ancient versions of the
corresponding backend routines, and not patched to incorporate subsequent
fixes (see my commits of 2008-03-31 and 2010-01-14 respectively).
It might be a good idea to change it to just *call* those routines,
but for now I'll just transpose these fixes over.
 2010-12-11 14:17:46 -05:00
Peter Eisentraut
fc946c39ae Remove useless whitespace at end of lines 2010-11-23 22:34:55 +02:00
Robert Haas
5aa446c961 Cleanup various comparisons with the constant "true". 
Itagaki Takahiro, with slight modifications.
 2010-11-14 21:03:48 -05:00
Robert Haas
11e482c350 Move copydir() prototype into its own header file. 
Having this in src/include/port.h makes no sense, now that copydir.c lives
in src/backend/strorage rather than src/port.  Along the way, remove an
obsolete comment from contrib/pg_upgrade that makes reference to the old
location.
 2010-11-12 16:39:53 -05:00
Tom Lane
71baff1786 Fix buffer overrun in pg_upgrade. 
Problem reported, and cause identified, by Hernan Gonzalez.
 2010-11-02 17:31:41 -04:00
Tom Lane
84c123be1d Allow new values to be added to an existing enum type. 
After much expenditure of effort, we've got this to the point where the
performance penalty is pretty minimal in typical cases.

Andrew Dunstan, reviewed by Brendan Jurd, Dean Rasheed, and Tom Lane
 2010-10-24 23:05:41 -04:00
Bruce Momjian
a52aa6c6db Clean up pg_upgrade cache lookup code; remove useless NULL pointer tests. 2010-10-20 20:02:37 +00:00
Bruce Momjian
691a67b922 Rename pg_upgrade 'log' to 'log_opts', to avoid platform naming conflict. 2010-10-20 02:31:17 +00:00
Bruce Momjian
3325c9bddb Further speed up pg_upgrade lookups. 2010-10-20 02:06:06 +00:00
Bruce Momjian
1c72614be7 Fix for new pg_upgrade cache code. 2010-10-20 01:24:31 +00:00
Bruce Momjian
333b4a45f1 Cache most recent relfilenode lookups, for speed, after report of 
pg_upgrade slowness for 150k tables.
 2010-10-20 00:55:16 +00:00
Bruce Momjian
ad06db2610 In pg_upgrade, use cached copy of directory listing, rather than calling 
scandir() with a pattern for every table.

Optimization after report of pg_upgrade slowness with 150k tables.
 2010-10-20 00:33:19 +00:00
Bruce Momjian
07456b45e6 Pgindent run on pg_upgrade source after restructuring. 2010-10-19 22:37:04 +00:00
Bruce Momjian
e13f7e9a71 Restructure the pg_upgrade code to use several global structures rather 
than packing everything into 'ctx' and passing that to every function.
 2010-10-19 21:38:34 +00:00
Bruce Momjian
722d5beeb2 In pg_upgrade, rename SHELL_EXT to SCRIPT_EXT, for clarity. 2010-10-19 15:57:55 +00:00
Bruce Momjian
51eeccd6cc Add removal of PG_VERSION to optional old cluster deletion script. 
Backpatch to 9.0.X.
 2010-10-19 15:52:43 +00:00
Bruce Momjian
9df96f9bb1 In pg_upgrade, rename macro EXEC_EXT to SHELL_EXT for clarity. 
Backpatch to 9.0.X.
 2010-10-19 02:56:16 +00:00
Bruce Momjian
fe61db6f0c Have pg_upgrade use strtoul(), not strtol(). 2010-09-29 02:40:25 +00:00
Bruce Momjian
807005c024 Use macro atooid() for conversion of strings to oids, per suggestion 
from Tom.
 2010-09-28 22:11:39 +00:00
Bruce Momjian
9340fb80b1 In pg_upgrade, properly handle oids > 2^31 by using strtoul() internally 
rather than atol().

Per report from Brian Hirt
 2010-09-28 21:41:03 +00:00
Bruce Momjian
a1bb570de9 Fix leak patch that was using fclose() instead of close(). 2010-09-28 21:27:32 +00:00
Bruce Momjian
f175884520 Properly close files after read file failure to prevent potential 
resource leak.  Of course, any such failure aborts pg_upgrade, but might
as well be clean about it.

Per patch from Grzegorz Ja?kiewicz.
 2010-09-28 19:28:34 +00:00
Magnus Hagander
fe9b36fd59 Convert cvsignore to gitignore, and add .gitignore for build targets. 2010-09-22 12:57:04 +02:00
Magnus Hagander
9f2e211386 Remove cvs keywords from all files. 2010-09-20 22:08:53 +02:00
Bruce Momjian
c5d94a34fb Modify pg_upgrade to set/restore all environment variables related to 
collation/encoding to match English when reading controldata.  This now
matches the English variable setting used by pg_regress.c.

Backpatch to 9.0.X.
 2010-09-07 14:10:30 +00:00
Peter Eisentraut
3f11971916 Remove extra newlines at end and beginning of files, add missing newlines 
at end of files.
 2010-08-19 05:57:36 +00:00
Bruce Momjian
8af787ea24 Adjust check_for_isn_and_int8_passing_mismatch() so it is called for all 
migrations.

Backpatch to 9.0.
 2010-07-25 03:47:29 +00:00
Bruce Momjian
f31b1fd7c1 Prevent pg_upgrade from migrating databases that use reg* data types 
where the oid is not preserved by pg_upgrade (everything but pg_type).
Update documentation.

Per bug report from depstein@alliedtesting.com.
 2010-07-25 03:28:32 +00:00
Bruce Momjian
4504a1bc01 On Win32, pg_upgrade cannot sent any server log output to the log file 
because of file access limitations on that platform.
 2010-07-13 20:03:32 +00:00
Bruce Momjian
477c01b00d Remove incorrect email address for pg_upgrade bug reports. 2010-07-13 18:14:14 +00:00
Bruce Momjian
f87bd25f00 In pg_upgrade, report /bin directory checks independent of /data checks. 2010-07-13 18:09:55 +00:00
Bruce Momjian
804f96accb In pg_upgrade, prevent psql AUTOCOMMIT=off by not loading .psqlrc. 2010-07-13 15:56:53 +00:00
Bruce Momjian
a0d7c5f689 Properly report errno/out-of-disk-space error from pg_upgrade when in 
copy mode, per report from depstein@alliedtesting.com.

Patch suggestion from Magnus.

Backpatch to 9.0.X.
 2010-07-09 16:51:23 +00:00
Bruce Momjian
239d769e7e pgindent run for 9.0, second run 2010-07-06 19:19:02 +00:00
Bruce Momjian
da254e3d16 Make pg_upgrade copyrights just 2010, not 2010-2010. 2010-07-03 16:33:15 +00:00
Bruce Momjian
de255a6eb1 Add copyrights to pg_upgrade and pg_upgrade_tools files, per Tom. 2010-07-03 16:25:01 +00:00
Bruce Momjian
ccbe0c14e6 Add CVS tags to pg_upgrade and pg_upgrade_support files, per request 
from Tom.
 2010-07-03 14:23:14 +00:00
Tom Lane
600fc1dc9d Get rid of some more stuff that duplicates c.h or port.h. 2010-07-01 15:52:52 +00:00
Bruce Momjian
14bd1c3d9e Remove port.h prototypes from pg_upgrade.h, per report from Robert Haas. 2010-07-01 14:37:53 +00:00
Bruce Momjian
c1b617987d Add username designations to all pg_upgrade utility calls that support it. 2010-06-23 20:04:50 +00:00
Bruce Momjian
601d1eeddc Fix pg_upgrade's use of pg_ctl on Win32 to not send command and sever 
output to the same file, because it is impossible.

Also set user name for pg_dumpall in pg_upgrade.
 2010-06-22 16:45:10 +00:00
Bruce Momjian
1aa117506d Fix pg_upgrade to remove malloc(0) call. 2010-06-16 19:43:11 +00:00
Bruce Momjian
24cb6ab9af Fix storage of getopt() return, should be 'int', for pg_upgrade. 
Steve Singer
 2010-06-15 23:25:01 +00:00
Bruce Momjian
8141523e35 Properly define pg_upgrade global variable, per bug report from Chris 
Ruprecht on Mac (64 bit).
 2010-06-15 02:08:01 +00:00
Bruce Momjian
785c2acc12 Update pg_upgrade C comment about cwd. 2010-06-12 17:45:28 +00:00
Bruce Momjian
1dc7c796c9 Have pg_upgrade create its output files in the current directory, rather 
than in a subdirectory of the $HOME directory, or $TMP in Windows.
 2010-06-12 17:05:29 +00:00
Bruce Momjian
9b6dba1193 Remove IMPLEMENTATION.jp file from pg_upgrade docs; still in pgFoundry 
for pg_migrator, per suggestion from Magnus.
 2010-05-25 16:53:24 +00:00
Bruce Momjian
02265f06b7 Update pg_upgrade IMPLEMENTATION doc file to match current 9.0 behavior. 2010-05-25 16:09:29 +00:00
Bruce Momjian
238d21d7d2 Modify pg_standby, pgbench, and pg_upgrade manual pages to be consistent 
in their display of command-line options with other client applications.
 2010-05-25 15:55:28 +00:00
Bruce Momjian
f4e9436026 Add Japanese Implementation file to CVS. 2010-05-25 02:56:36 +00:00
Bruce Momjian
7a74d70e71 Re-order pg_upgrade 'help' options to be alphabetical. 2010-05-25 02:55:58 +00:00
Bruce Momjian
6368682788 In pg_upgrade, test for datallowconn instead of hardcoding template0. 2010-05-24 19:52:33 +00:00
Bruce Momjian
00be75415c Split apart pg_upgrade user lookup and root check so '--help' shows 
proper default username.
 2010-05-24 16:34:35 +00:00
Tom Lane
add8044778 issue_warnings() has no business freeing its parameter, especially not when 
its sole caller does that too.  Jan Matousek, via Pavel Stehule
 2010-05-23 16:54:13 +00:00
Bruce Momjian
3245bd5240 Simplify pg_upgrade queries by using IN instead of multiple OR clauses 
comparing the same column to multiple values.
 2010-05-19 18:56:47 +00:00
Bruce Momjian
573e446f6f For pg_upgrade, update template0's datfrozenxid and its relfrozenxids to 
match the behavior of autovacuum, which does this as the xid advances
even if autovacuum is turned off.
 2010-05-19 18:27:43 +00:00
Bruce Momjian
64719a18db Use a 'datallowconn' check for avoiding 'template0', rather than 
hardcoding a 'template0' check, per suggestion from Alvaro.

This might fix a problem where someone has allowed 'template0'
connections, but it is a cleaner approach even if doesn't fix the
bug.
 2010-05-18 18:40:51 +00:00
Bruce Momjian
37953b2d20 Add pg_upgrade TESTING files explaining a testing method. 2010-05-18 03:26:12 +00:00
Bruce Momjian
5c337fb45c Adjust pg_upgrade BSD defines for scandir(), per report from Giles Lean 2010-05-15 10:21:54 +00:00
Bruce Momjian
5781d96dc3 Change bsdi define to __bsdi__ 2010-05-15 10:08:28 +00:00
Tom Lane
88fba7089e Fix another obvious bug pointed out by a compiler warning. 2010-05-14 00:43:42 +00:00
Tom Lane
0546906064 Remove another unsafe use of random data as a format string. 2010-05-14 00:39:51 +00:00
Tom Lane
8eac39780d Get rid of unsafe sprintf and snprintf usages. Per compiler warnings. 2010-05-14 00:32:21 +00:00
Tom Lane
adf6b8edfb Spell __darwin__ correctly, to suppress compiler warning on OSX. 2010-05-14 00:19:46 +00:00
Bruce Momjian
e9ad14f9f4 Use NAMEDATALEN instead of local define. 
Modify path separators for Win32.

Per ideas from Takahiro Itagaki
 2010-05-14 00:13:38 +00:00
Bruce Momjian
36d3afd2d4 Remove all mentions of EnterpriseDB Advanced Server from pg_upgrade; 
EDB must maintain their own patch set for this.
 2010-05-13 22:51:00 +00:00
Tom Lane
382ff21203 Fix up lame idea of not using autoconf to determine if platform has scandir(). 
Should fix buildfarm failures.
 2010-05-13 22:07:43 +00:00
Magnus Hagander
2b61b3e507 Assorted fixes to make pg_upgrade build on MSVC. 
* There is no chmod() on Windows.
* Must always use the 3-parameter version of open()
* There is no dynloader.h - but it also appears unnecessary on all platforms
* Don't include shlobj.h because it causes compile errors, and from what I can
  see it's not actually used. This may need to be added back for mingw
  and/or cygwin in the worst case.
 2010-05-13 15:58:15 +00:00
Bruce Momjian
9885206cab Move pg_upgrade shared library out into its own /contrib directory 
(pg_upgrade_support).
 2010-05-13 01:03:01 +00:00
Tom Lane
c9c25a982c Clean up unnecessary unportability and compiler warnings by removing the 
cmp parameter for pg_scandir().  The code failed to support this anyway
for Sun/Windows, so pretending we could accept a parameter other than
NULL was just asking for trouble.
 2010-05-12 16:50:00 +00:00
Bruce Momjian
b460b5cd11 Move pg_upgrade TODO to TODO wiki. 2010-05-12 13:59:21 +00:00
Bruce Momjian
395d1259ad Add PGFILEDESC description to Makefiles for all /contrib executables. 
Add PGAPPICON to all executable makefiles.
 2010-05-12 11:33:10 +00:00
Bruce Momjian
561afa534d Small formatting adjustment. 2010-05-12 11:07:24 +00:00
Bruce Momjian
a898199df5 Add pg_upgrade IMPLEMENTATION file to CVS. 2010-05-12 02:24:43 +00:00
Bruce Momjian
6c4a98d99c Add TODO file to CVS. 2010-05-12 02:23:56 +00:00
Bruce Momjian
c2e9b2f288 Add pg_upgrade to /contrib; will be in 9.0 beta2. 
Add documentation.

Supports migration from PG 8.3 and 8.4.
 2010-05-12 02:19:11 +00:00
Tom Lane
d20763dbee Remove contrib modules that have been agreed to be obsolete. 
(There are more that will be removed once they've been copied to
pgfoundry.org.)
 2005-06-22 22:56:29 +00:00
PostgreSQL Daemon
969685ad44 $Header: -> $PostgreSQL Changes ... 2003-11-29 19:52:15 +00:00
Peter Eisentraut
6d27cfdd89 Make pg_resetxlog options parsing more standard and prepare messages for 
translation.
 2002-08-29 22:19:03 +00:00
Bruce Momjian
c3c54a21b6 Disable pg_upgrade for 7.3. 2002-07-03 14:38:19 +00:00
Bruce Momjian
c419c22414 Update pg_upgrade for 7.3. 2002-04-09 18:07:24 +00:00
Bruce Momjian
966e6478b5 Fix flag handling of pg_upgrade. 2002-02-11 15:19:33 +00:00
Bruce Momjian
a7ff4a7393 Add mention of recovery using pg_upgrade. 2002-01-31 19:13:53 +00:00
Bruce Momjian
c69c25ba4d Update HISTORY/release.sgml for Monday release. 2002-01-31 18:31:44 +00:00
Bruce Momjian
85bc36158d Enable /contrib/pg_upgrade, mention little testing. 2002-01-18 04:38:46 +00:00
Bruce Momjian
eb410b6bde Manual page improvements. 2002-01-15 05:41:55 +00:00
Bruce Momjian
08147fa7da More cleanups. 2002-01-15 05:10:57 +00:00
Bruce Momjian
a73517cb8c Keep pg_upgrade as disabled. 2002-01-15 05:03:53 +00:00
Bruce Momjian
19cba1a775 More wording improvements. 2002-01-15 05:03:25 +00:00
Bruce Momjian
fff981652e More updates. 2002-01-15 04:55:26 +00:00
Bruce Momjian
8e76187790 More cleanups with ideas from Peter. 2002-01-15 04:50:37 +00:00
Bruce Momjian
86beaf4fa0 Add Peter's portability and option suggestions. 2002-01-15 04:05:24 +00:00
Bruce Momjian
ebf57dd082 Update permissions? 2002-01-14 22:54:44 +00:00
Bruce Momjian
309cbe494c Add README file. 2002-01-14 17:45:43 +00:00
Bruce Momjian
0451c09fd6 Doc improvements. 2002-01-14 17:42:42 +00:00
Bruce Momjian
15ca0a502c Add manual page to /contrib. SGML from docs. 2002-01-14 17:32:36 +00:00