From f7e089b3fac5af49815e5cda2e0c3a05625eea19 Mon Sep 17 00:00:00 2001 From: Bruce Momjian Date: Fri, 30 Aug 2002 16:00:41 +0000 Subject: [PATCH] Back out password packet length check. Improve wording of pre-7.3 syntax mention. --- doc/src/sgml/ref/copy.sgml | 4 ++-- doc/src/sgml/ref/select.sgml | 4 ++-- src/backend/libpq/auth.c | 16 +--------------- 3 files changed, 5 insertions(+), 19 deletions(-) diff --git a/doc/src/sgml/ref/copy.sgml b/doc/src/sgml/ref/copy.sgml index c5c8fcbb94..677ec5792a 100644 --- a/doc/src/sgml/ref/copy.sgml +++ b/doc/src/sgml/ref/copy.sgml @@ -1,5 +1,5 @@ @@ -700,7 +700,7 @@ ZW ZIMBABWE There is no COPY statement in SQL92. - The following syntax was used by pre-7.3 servers and is still supported: + The following syntax was used by pre-7.3 applications and is still supported: COPY [ BINARY ] table [ WITH OIDS ] FROM { 'filename' | stdin } diff --git a/doc/src/sgml/ref/select.sgml b/doc/src/sgml/ref/select.sgml index 1feaa6f7b4..7192de53e0 100644 --- a/doc/src/sgml/ref/select.sgml +++ b/doc/src/sgml/ref/select.sgml @@ -1,5 +1,5 @@ @@ -869,7 +869,7 @@ SELECT name FROM distributors ORDER BY code; FOR UPDATE cannot be used in contexts where returned rows can't be clearly identified with individual table rows; for example it can't be used with aggregation. FOR UPDATE may also appear before LIMIT for portability with - pre-7.3 servers. + pre-7.3 applications. diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c index fb43f8e4af..216343f36c 100644 --- a/src/backend/libpq/auth.c +++ b/src/backend/libpq/auth.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.87 2002/08/29 21:50:36 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/libpq/auth.c,v 1.88 2002/08/30 16:00:41 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -709,20 +709,6 @@ recv_and_check_password_packet(Port *port) if (pq_eof() == EOF || pq_getint(&len, 4) == EOF) return STATUS_EOF; /* client didn't want to send password */ - /* - * Since the remote client has not yet been authenticated, we need - * to be careful when using the data they send us. The 8K limit is - * arbitrary, and somewhat bogus: the intent is to ensure we don't - * allocate an enormous chunk of memory. - */ - - if (len < 1 || len > 8192) - { - elog(LOG, "Invalid password packet length: %d; " - "must satisfy 1 <= length <= 8192", len); - return STATUS_EOF; - } - initStringInfo(&buf); if (pq_getstr(&buf) == EOF) /* receive password */ {