mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Prevent show_session_authorization from crashing when session_authorization

Browse Source 
hasn't been set.

The only known case where this can happen is when show_session_authorization
is invoked in an autovacuum process, which is possible if an index function
calls it, as for example in bug #5669 from Andrew Geery.  We could perhaps
try to return a sensible value, such as the name of the cluster-owning
superuser; but that seems like much more trouble than the case is worth,
and in any case it could create new possible failure modes.  Simply
returning an empty string seems like the most appropriate fix.

Back-patch to all supported versions, even those before autovacuum, just
in case there's another way to provoke this crash.
This commit is contained in:
Tom Lane 2010-09-23 16:53:22 -04:00
parent b74ecb9194
commit f73ccedcf8
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/commands/variable.c
View File

@ -771,6 +771,10 @@ show_session_authorization(void)
Oid savedoid;
char *endptr;
/* If session_authorization hasn't been set in this process, return "" */
if (value == NULL || value[0] == '\0')
return "";
Assert(strspn(value, "x") == NAMEDATALEN &&
(value[NAMEDATALEN] == 'T' || value[NAMEDATALEN] == 'F'));