From eeb4eeea2c525c51767ffeafda0070b946f26ae8 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 7 Aug 2023 09:06:52 +0200 Subject: [PATCH] Remove configure check for z_streamp This is surely obsolete. zlib version 1.0.4, which includes z_streamp, was released 1996-07-24. When this check was put in in 2001 (19c97b8579), the commit was already labeling that release as ancient. Reviewed-by: Tristan Partin Discussion: https://www.postgresql.org/message-id/flat/33462926-bb1e-7cc9-8d92-d86318e8ed1d%40eisentraut.org --- configure | 15 --------------- configure.ac | 9 --------- meson.build | 8 -------- 3 files changed, 32 deletions(-) diff --git a/configure b/configure index 2e518c8007..963fbbcf1e 100755 --- a/configure +++ b/configure @@ -15162,21 +15162,6 @@ _ACEOF fi -if test "$with_zlib" = yes; then - # Check that defines z_streamp (versions before about 1.0.4 - # did not). While we could work around the lack of z_streamp, it - # seems unwise to encourage people to use such old zlib versions... - ac_fn_c_check_type "$LINENO" "z_streamp" "ac_cv_type_z_streamp" "#include -" -if test "x$ac_cv_type_z_streamp" = xyes; then : - -else - as_fn_error $? "zlib version is too old -Use --without-zlib to disable zlib support." "$LINENO" 5 -fi - -fi - case $host_cpu in x86_64) # On x86_64, check if we can compile a popcntq instruction diff --git a/configure.ac b/configure.ac index 3ebe1a796d..5153b8b3fd 100644 --- a/configure.ac +++ b/configure.ac @@ -1678,15 +1678,6 @@ AC_CHECK_TYPES([struct option], [], [], #include #endif]) -if test "$with_zlib" = yes; then - # Check that defines z_streamp (versions before about 1.0.4 - # did not). While we could work around the lack of z_streamp, it - # seems unwise to encourage people to use such old zlib versions... - AC_CHECK_TYPE(z_streamp, [], [AC_MSG_ERROR([zlib version is too old -Use --without-zlib to disable zlib support.])], - [#include ]) -fi - case $host_cpu in x86_64) # On x86_64, check if we can compile a popcntq instruction diff --git a/meson.build b/meson.build index 04ea348852..0a11efc97a 100644 --- a/meson.build +++ b/meson.build @@ -1384,14 +1384,6 @@ if not zlibopt.disabled() args: test_c_args, include_directories: postgres_inc, dependencies: [zlib_t], required: zlibopt) warning('zlib header not found') - elif not cc.has_type('z_streamp', - dependencies: [zlib_t], prefix: '#include ', - args: test_c_args, include_directories: postgres_inc) - if zlibopt.enabled() - error('zlib version is too old') - else - warning('zlib version is too old') - endif else zlib = zlib_t endif