mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-01-18 18:44:06 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove less-portable-than-believed test case.

Browse Source 
In commit 331b2369c I added a test to see what jsonb_plperl would do
with a qr{} result.  Turns out the answer is Perl version dependent.
That fact doesn't bother me particularly, but coping with multiple
result possibilities is way more work than this test seems worth.
So remove it again.

Discussion: https://postgr.es/m/E1f3MMJ-0006bf-B0@gemulon.postgresql.org
This commit is contained in:
Tom Lane 2018-04-04 11:51:36 -04:00
parent 331b2369c0
commit eac93e20af
4 changed files with 2 additions and 48 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
contrib/jsonb_plperl/expected/jsonb_plperl.out
View File

@ -39,17 +39,6 @@ SELECT testSVToJsonb();
1 1
(1 row) (1 row)
-- unsupported (for now)
CREATE FUNCTION testRegexpToJsonb() RETURNS jsonb
LANGUAGE plperl
TRANSFORM FOR TYPE jsonb
AS $$
my $a = qr/foo/;
return ($a);
$$;
SELECT testRegexpToJsonb();
ERROR: cannot transform this Perl type to jsonb
CONTEXT: PL/Perl function "testregexptojsonb"
-- this revealed a bug in the original implementation -- this revealed a bug in the original implementation
CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb
LANGUAGE plperl LANGUAGE plperl
@ -218,4 +207,4 @@ SELECT roundtrip('{"1": {"2": [3, 4, 5]}, "2": 3}');
\set VERBOSITY terse \\ -- suppress cascade details \set VERBOSITY terse \\ -- suppress cascade details
DROP EXTENSION plperl CASCADE; DROP EXTENSION plperl CASCADE;
NOTICE: drop cascades to 7 other objects NOTICE: drop cascades to 6 other objects

13
contrib/jsonb_plperl/expected/jsonb_plperlu.out
View File

@ -39,17 +39,6 @@ SELECT testSVToJsonb();
1 1
(1 row) (1 row)
-- unsupported (for now)
CREATE FUNCTION testRegexpToJsonb() RETURNS jsonb
LANGUAGE plperlu
TRANSFORM FOR TYPE jsonb
AS $$
my $a = qr/foo/;
return ($a);
$$;
SELECT testRegexpToJsonb();
ERROR: cannot transform this Perl type to jsonb
CONTEXT: PL/Perl function "testregexptojsonb"
-- this revealed a bug in the original implementation -- this revealed a bug in the original implementation
CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb
LANGUAGE plperlu LANGUAGE plperlu
@ -218,4 +207,4 @@ SELECT roundtrip('{"1": {"2": [3, 4, 5]}, "2": 3}');
\set VERBOSITY terse \\ -- suppress cascade details \set VERBOSITY terse \\ -- suppress cascade details
DROP EXTENSION plperlu CASCADE; DROP EXTENSION plperlu CASCADE;
NOTICE: drop cascades to 7 other objects NOTICE: drop cascades to 6 other objects

12
contrib/jsonb_plperl/sql/jsonb_plperl.sql
View File

@ -34,18 +34,6 @@ $$;
SELECT testSVToJsonb(); SELECT testSVToJsonb();
-- unsupported (for now)
CREATE FUNCTION testRegexpToJsonb() RETURNS jsonb
LANGUAGE plperl
TRANSFORM FOR TYPE jsonb
AS $$
my $a = qr/foo/;
return ($a);
$$;
SELECT testRegexpToJsonb();
-- this revealed a bug in the original implementation -- this revealed a bug in the original implementation
CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb
LANGUAGE plperl LANGUAGE plperl

12
contrib/jsonb_plperl/sql/jsonb_plperlu.sql
View File

@ -34,18 +34,6 @@ $$;
SELECT testSVToJsonb(); SELECT testSVToJsonb();
-- unsupported (for now)
CREATE FUNCTION testRegexpToJsonb() RETURNS jsonb
LANGUAGE plperlu
TRANSFORM FOR TYPE jsonb
AS $$
my $a = qr/foo/;
return ($a);
$$;
SELECT testRegexpToJsonb();
-- this revealed a bug in the original implementation -- this revealed a bug in the original implementation
CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb CREATE FUNCTION testRegexpResultToJsonb() RETURNS jsonb
LANGUAGE plperlu LANGUAGE plperlu