From e37824136f060aefcb9e95ee3968446434c783c7 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Wed, 18 Mar 2020 09:33:01 +0530 Subject: [PATCH] Add missing errcode() in a few ereport calls. This will allow to specifying SQLSTATE error code for the errors in the missing places. Reported-by: Sawada Masahiko Author: Sawada Masahiko Backpatch-through: 9.5 Discussion: https://postgr.es/m/CA+fd4k6N8EjNvZpM8nme+y+05mz-SM8Z_BgkixzkA34R+ej0Kw@mail.gmail.com --- contrib/adminpack/adminpack.c | 6 +++--- src/backend/storage/page/bufpage.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/adminpack/adminpack.c b/contrib/adminpack/adminpack.c index 22070d262b..923c90c068 100644 --- a/contrib/adminpack/adminpack.c +++ b/contrib/adminpack/adminpack.c @@ -187,7 +187,7 @@ pg_file_write_internal(text *file, text *data, bool replace) if (stat(filename, &fst) >= 0) ereport(ERROR, - (ERRCODE_DUPLICATE_FILE, + (errcode(ERRCODE_DUPLICATE_FILE), errmsg("file \"%s\" exists", filename))); f = AllocateFile(filename, "wb"); @@ -319,7 +319,7 @@ pg_file_rename_internal(text *file1, text *file2, text *file3) if (rc >= 0 || errno != ENOENT) { ereport(ERROR, - (ERRCODE_DUPLICATE_FILE, + (errcode(ERRCODE_DUPLICATE_FILE), errmsg("cannot rename to target file \"%s\"", fn3 ? fn3 : fn2))); } @@ -350,7 +350,7 @@ pg_file_rename_internal(text *file1, text *file2, text *file3) else { ereport(ERROR, - (ERRCODE_UNDEFINED_FILE, + (errcode(ERRCODE_UNDEFINED_FILE), errmsg("renaming \"%s\" to \"%s\" was reverted", fn2, fn3))); } diff --git a/src/backend/storage/page/bufpage.c b/src/backend/storage/page/bufpage.c index 6b49810e37..169430835c 100644 --- a/src/backend/storage/page/bufpage.c +++ b/src/backend/storage/page/bufpage.c @@ -148,7 +148,7 @@ PageIsVerified(Page page, BlockNumber blkno) if (checksum_failure) { ereport(WARNING, - (ERRCODE_DATA_CORRUPTED, + (errcode(ERRCODE_DATA_CORRUPTED), errmsg("page verification failed, calculated checksum %u but expected %u", checksum, p->pd_checksum)));