mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-03-01 19:45:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

The current implementation of BlobInputStream does

Browse Source 
not properly handle 8-bit unsigned data as it blindly
casts the byte to an int, which java most helpfully
promotes to a signed type.  This causes problems when
you can only return -1 to indicated EOF.

The following patch fixes the bug and has been tested
locally on image data.

Chad David
This commit is contained in:
Bruce Momjian 2001-05-16 03:29:01 +00:00
parent dbb219b896
commit e046e1dfab
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/interfaces/jdbc/org/postgresql/largeobject/BlobInputStream.java
View File

@ -58,16 +58,24 @@ public class BlobInputStream extends InputStream {
*/
public int read() throws java.io.IOException {
try {
if(buffer==null || bpos>=buffer.length) {
if (buffer == null || bpos >= buffer.length) {
buffer=lo.read(bsize);
bpos=0;
}
// Handle EOF
if(bpos>=buffer.length)
if(bpos >= buffer.length) {
return -1;
}
return (int) buffer[bpos++];
int ret = (buffer[bpos] & 0x7F);
if ((buffer[bpos] &0x80) == 0x80) {
ret |= 0x80;
}
bpos++;
return ret;
} catch(SQLException se) {
throw new IOException(se.toString());
}
@ -152,5 +160,4 @@ public class BlobInputStream extends InputStream {
public boolean markSupported() {
return true;
}
}
}