mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-03-07 19:47:50 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix bug introduced into indexable_outerrelids() by an ill-considered

Browse Source 
"optimization".  When we find a potentially useful joinclause, we
have to add all its other required_relids to the result, not only the
other clause_relids.  They are different in the case of a joinclause
whose applicability has to be postponed due to outer join.  We have
to include the extra rels because otherwise, after best_inner_indexscan
masks the join rels with index_outer_relids, it will always fail to
find the joinclause as applicable.  Per report from Husam Tomeh.
This commit is contained in:
Tom Lane 2005-09-22 23:25:07 +00:00
parent 8a64ec6285
commit d7e4fd99e5
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/optimizer/path/indxpath.c
View File

@ -9,7 +9,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.188 2005/08/28 22:47:20 tgl Exp $ * $PostgreSQL: pgsql/src/backend/optimizer/path/indxpath.c,v 1.189 2005/09/22 23:25:07 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -955,15 +955,13 @@ indexable_outerrelids(RelOptInfo *rel)
/* /*
* Examine each joinclause in the joininfo list to see if it matches any * Examine each joinclause in the joininfo list to see if it matches any
* key of any index. If so, add the clause's other rels to the result. * key of any index. If so, add the clause's other rels to the result.
* (Note: we consider only actual participants, not extraneous rels
* possibly mentioned in required_relids.)
*/ */
foreach(l, rel->joininfo) foreach(l, rel->joininfo)
{ {
RestrictInfo *joininfo = (RestrictInfo *) lfirst(l); RestrictInfo *joininfo = (RestrictInfo *) lfirst(l);
Relids other_rels; Relids other_rels;
other_rels = bms_difference(joininfo->clause_relids, rel->relids); other_rels = bms_difference(joininfo->required_relids, rel->relids);
if (matches_any_index(joininfo, rel, other_rels)) if (matches_any_index(joininfo, rel, other_rels))
outer_relids = bms_join(outer_relids, other_rels); outer_relids = bms_join(outer_relids, other_rels);
else else