mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-15 08:20:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Improve error message wording in unary_op_error() --- suggest that

Browse Source 
problem could be lack of parentheses.  This addresses cases like
X UserOp UserOp Y, which will be parsed as (X UserOp) UserOp Y,
whereas what likely was wanted was X UserOp (UserOp Y).
This commit is contained in:
Tom Lane 2000-03-18 19:53:54 +00:00
parent f91dd7880f
commit d63e05a638
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/parser/parse_oper.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.37 2000/03/11 23:17:47 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/parser/parse_oper.c,v 1.38 2000/03/18 19:53:54 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -703,18 +703,14 @@ op_error(char *op, Oid arg1, Oid arg2)
if (typeidIsValid(arg1)) if (typeidIsValid(arg1))
tp1 = typeidType(arg1); tp1 = typeidType(arg1);
else else
{
elog(ERROR, "Left hand side of operator '%s' has an unknown type" elog(ERROR, "Left hand side of operator '%s' has an unknown type"
"\n\tProbably a bad attribute name", op); "\n\tProbably a bad attribute name", op);
}
if (typeidIsValid(arg2)) if (typeidIsValid(arg2))
tp2 = typeidType(arg2); tp2 = typeidType(arg2);
else else
{
elog(ERROR, "Right hand side of operator %s has an unknown type" elog(ERROR, "Right hand side of operator %s has an unknown type"
"\n\tProbably a bad attribute name", op); "\n\tProbably a bad attribute name", op);
}
elog(ERROR, "Unable to identify an operator '%s' for types '%s' and '%s'" elog(ERROR, "Unable to identify an operator '%s' for types '%s' and '%s'"
"\n\tYou will have to retype this query using an explicit cast", "\n\tYou will have to retype this query using an explicit cast",
@ -741,7 +737,7 @@ unary_op_error(char *op, Oid arg, bool is_left_op)
} }
elog(ERROR, "Unable to identify a %s operator '%s' for type '%s'" elog(ERROR, "Unable to identify a %s operator '%s' for type '%s'"
"\n\tYou will have to retype this query using an explicit cast", "\n\tYou may need to add parentheses or an explicit cast",
(is_left_op ? "left" : "right"), (is_left_op ? "left" : "right"),
op, typeTypeName(tp1)); op, typeTypeName(tp1));
} }