From c1907f0cc49e38df9853b7547c9afce5204e4784 Mon Sep 17 00:00:00 2001
From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Sat, 17 May 2014 17:57:53 -0400
Subject: [PATCH] Fix a bunch of functions that were declared static then
 defined not-static.

Per testing with a compiler that whines about this.
---
 src/backend/access/transam/xlog.c               | 2 +-
 src/backend/replication/logical/reorderbuffer.c | 2 +-
 src/backend/utils/cache/relcache.c              | 2 +-
 src/backend/utils/misc/guc.c                    | 2 +-
 src/bin/pg_ctl/pg_ctl.c                         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 3d752c6418..d675560894 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -8318,7 +8318,7 @@ CreateCheckPoint(int flags)
  * CreateRestartPoint() allows for the case where recovery may end before
  * the restartpoint completes so there is no concern of concurrent behaviour.
  */
-void
+static void
 CreateEndOfRecoveryRecord(void)
 {
 	xl_end_of_recovery xlrec;
diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c
index f96e3e1d93..12960f4997 100644
--- a/src/backend/replication/logical/reorderbuffer.c
+++ b/src/backend/replication/logical/reorderbuffer.c
@@ -322,7 +322,7 @@ ReorderBufferGetTXN(ReorderBuffer *rb)
  * Deallocation might be delayed for efficiency purposes, for details check
  * the comments above max_cached_changes's definition.
  */
-void
+static void
 ReorderBufferReturnTXN(ReorderBuffer *rb, ReorderBufferTXN *txn)
 {
 	/* clean the lookup cache if we were cached (quite likely) */
diff --git a/src/backend/utils/cache/relcache.c b/src/backend/utils/cache/relcache.c
index 1ffa24356b..0d3ef20c06 100644
--- a/src/backend/utils/cache/relcache.c
+++ b/src/backend/utils/cache/relcache.c
@@ -2381,7 +2381,7 @@ RelationCloseSmgrByOid(Oid relationId)
 	RelationCloseSmgr(relation);
 }
 
-void
+static void
 RememberToFreeTupleDescAtEOX(TupleDesc td)
 {
 	if (EOXactTupleDescArray == NULL)
diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c
index fdd5b638cd..1d094f00c6 100644
--- a/src/backend/utils/misc/guc.c
+++ b/src/backend/utils/misc/guc.c
@@ -5340,7 +5340,7 @@ config_enum_get_options(struct config_enum * record, const char *prefix,
  *	1: the value is valid
  *	0: the name or value is invalid
  */
-bool
+static bool
 validate_conf_option(struct config_generic * record, const char *name,
 					 const char *value, GucSource source, int elevel,
 					 bool freemem, void *newval, void **newextra)
diff --git a/src/bin/pg_ctl/pg_ctl.c b/src/bin/pg_ctl/pg_ctl.c
index 899f4323b2..9a6ade935f 100644
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -399,7 +399,7 @@ readfile(const char *path)
 /*
  * Free memory allocated for optlines through readfile()
  */
-void
+static void
 free_readfile(char **optlines)
 {
 	char	   *curr_line = NULL;