mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-15 08:20:16 +08:00
Code Issues Packages Projects Releases Wiki Activity

Remove special cases for ETXTBSY from new fsync'ing logic.

Browse Source 
The argument that this is a sufficiently-expected case to be silently
ignored seems pretty thin.  Andres had brought it up back when we were
still considering that most fsync failures should be hard errors, and it
probably would be legit not to fail hard for ETXTBSY --- but the same is
true for EROFS and other cases, which is why we gave up on hard failures.
ETXTBSY is surely not a normal case, so logging the failure seems fine
from here.
This commit is contained in:
Tom Lane 2015-05-29 15:11:36 -04:00
parent e4a04e5a4e
commit bf2f20c086
1 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/storage/file/fd.c
View File

@ -2216,18 +2216,15 @@ pre_sync_fname(const char *fname, bool isdir, int elevel)
{
if (errno == EACCES || (isdir && errno == EISDIR))
return;
#ifdef ETXTBSY
if (errno == ETXTBSY)
return;
#endif
ereport(elevel,
(errcode_for_file_access(),
errmsg("could not open file \"%s\": %m", fname)));
return;
}
/*
* We ignore errors from pg_flush_data() because this is only a hint.
*/
(void) pg_flush_data(fd, 0, 0);
(void) close(fd);
@ -2271,12 +2268,6 @@ fsync_fname_ext(const char *fname, bool isdir, int elevel)
{
if (errno == EACCES || (isdir && errno == EISDIR))
return;
#ifdef ETXTBSY
if (errno == ETXTBSY)
return;
#endif
ereport(elevel,
(errcode_for_file_access(),
errmsg("could not open file \"%s\": %m", fname)));