mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2025-03-01 19:45:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

Error out in pg_rewind if lstat() fails.

Browse Source 
A "file not found" is expected if the source server is running, so don't
complain about that. But any other error is definitely not expected.
This commit is contained in:
Heikki Linnakangas 2015-04-15 23:13:32 +03:00
parent 41457fcf97
commit b5e560c246
1 changed files with 14 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/bin/pg_rewind/copy_fetch.c
View File

@ -75,17 +75,20 @@ recurse_dir(const char *datadir, const char *parentpath,
if (lstat(fullpath, &fst) < 0)
{
pg_log(PG_WARNING, "could not stat file \"%s\": %s",
fullpath, strerror(errno));
/*
* This is ok, if the new master is running and the file was just
* removed. If it was a data file, there should be a WAL record of
* the removal. If it was something else, it couldn't have been
* critical anyway.
*
* TODO: But complain if we're processing the target dir!
*/
if (errno == ENOENT)
{
/*
* File doesn't exist anymore. This is ok, if the new master
* is running and the file was just removed. If it was a data
* file, there should be a WAL record of the removal. If it
* was something else, it couldn't have been anyway.
*
* TODO: But complain if we're processing the target dir!
*/
}
else
pg_fatal("could not stat file \"%s\": %s",
fullpath, strerror(errno));
}
if (parentpath)