mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Document why we copy reloptions into CacheMemoryContext after-the-fact.

Browse Source
This commit is contained in:
Robert Haas 2010-01-07 20:39:45 +00:00
parent 50626efe0a
commit b1ee6daf2f
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/backend/utils/cache/relcache.c vendored
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.296 2010/01/05 01:06:56 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/cache/relcache.c,v 1.297 2010/01/07 20:39:45 rhaas Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -404,7 +404,12 @@ RelationParseRelOptions(Relation relation, HeapTuple tuple)
relation->rd_rel->relkind == RELKIND_INDEX ? relation->rd_rel->relkind == RELKIND_INDEX ?
relation->rd_am->amoptions : InvalidOid); relation->rd_am->amoptions : InvalidOid);
/* Copy parsed data into CacheMemoryContext */ /*
* Copy parsed data into CacheMemoryContext. To guard against the
* possibility of leaks in the reloptions code, we want to do the actual
* parsing in the caller's memory context and copy the results into
* CacheMemoryContext after the fact.
*/
if (options) if (options)
{ {
relation->rd_options = MemoryContextAlloc(CacheMemoryContext, relation->rd_options = MemoryContextAlloc(CacheMemoryContext,