mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-27 08:39:28 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix thinko in multi-autovac-workers code: validity checks made by

Browse Source 
GUC assign hooks are supposed to be made whether doit is true or not.
This commit is contained in:
Tom Lane 2007-08-08 16:00:46 +00:00
parent 849ec99753
commit af1022d2cd
1 changed files with 7 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/backend/utils/misc/guc.c
View File

@ -10,7 +10,7 @@
* Written by Peter Eisentraut <peter_e@gmx.net>. * Written by Peter Eisentraut <peter_e@gmx.net>.
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.410 2007/08/04 19:29:25 tgl Exp $ * $PostgreSQL: pgsql/src/backend/utils/misc/guc.c,v 1.411 2007/08/08 16:00:46 tgl Exp $
* *
*-------------------------------------------------------------------- *--------------------------------------------------------------------
*/ */
@ -6956,13 +6956,11 @@ show_tcp_keepalives_count(void)
static bool static bool
assign_maxconnections(int newval, bool doit, GucSource source) assign_maxconnections(int newval, bool doit, GucSource source)
{ {
if (doit) if (newval + autovacuum_max_workers > INT_MAX / 4)
{ return false;
if (newval + autovacuum_max_workers > INT_MAX / 4)
return false;
if (doit)
MaxBackends = newval + autovacuum_max_workers; MaxBackends = newval + autovacuum_max_workers;
}
return true; return true;
} }
@ -6970,13 +6968,11 @@ assign_maxconnections(int newval, bool doit, GucSource source)
static bool static bool
assign_autovacuum_max_workers(int newval, bool doit, GucSource source) assign_autovacuum_max_workers(int newval, bool doit, GucSource source)
{ {
if (doit) if (newval + MaxConnections > INT_MAX / 4)
{ return false;
if (newval + MaxConnections > INT_MAX / 4)
return false;
if (doit)
MaxBackends = newval + MaxConnections; MaxBackends = newval + MaxConnections;
}
return true; return true;
} }