From ade89ba5f408e6034db7cc8a2c9b7858f5a214c4 Mon Sep 17 00:00:00 2001 From: Amit Kapila Date: Tue, 23 Feb 2021 09:47:41 +0530 Subject: [PATCH] Fix an oversight in ReorderBufferFinishPrepared. We don't have anything to decode in a transaction if ReorderBufferTXN doesn't exist by the time we decode the commit prepared. So don't create a new ReorderBufferTXN here. This is an oversight in commit a271a1b5. Reported-by: Markus Wanner Discussion: https://postgr.es/m/dbec82e2-dbd7-95a2-c6b6-e488cbbdf853@bluegap.ch --- src/backend/replication/logical/reorderbuffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/backend/replication/logical/reorderbuffer.c b/src/backend/replication/logical/reorderbuffer.c index 5a62ab8bbc..66554ca2d9 100644 --- a/src/backend/replication/logical/reorderbuffer.c +++ b/src/backend/replication/logical/reorderbuffer.c @@ -2679,7 +2679,7 @@ ReorderBufferFinishPrepared(ReorderBuffer *rb, TransactionId xid, XLogRecPtr prepare_end_lsn; TimestampTz prepare_time; - txn = ReorderBufferTXNByXid(rb, xid, true, NULL, commit_lsn, false); + txn = ReorderBufferTXNByXid(rb, xid, false, NULL, commit_lsn, false); /* unknown transaction, nothing to do */ if (txn == NULL)