mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-12-21 08:29:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

Expose the "*VALUES*" alias that we generate for a stand-alone VALUES list.

Browse Source 
We were trying to make that strictly an internal implementation detail,
but it turns out that it's exposed anyway when dumping a view defined
like
	CREATE VIEW test_view AS VALUES (1), (2), (3) ORDER BY 1;
This comes out as
	CREATE VIEW ... ORDER BY "*VALUES*".column1;
which fails to parse when reloading the dump.

Hacking ruleutils.c to suppress the column qualification looks like it'd
be a risky business, so instead promote the RTE alias to full-fledged
usability.

Per bug #6049 from Dylan Adams.  Back-patch to all supported branches.
This commit is contained in:
Tom Lane 2011-06-04 15:48:17 -04:00
parent 048417511a
commit a914377495
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/parser/analyze.c
View File

@ -999,7 +999,7 @@ transformSelectStmt(ParseState *pstate, SelectStmt *stmt)
* transforms a VALUES clause that's being used as a standalone SELECT * transforms a VALUES clause that's being used as a standalone SELECT
* *
* We build a Query containing a VALUES RTE, rather as if one had written * We build a Query containing a VALUES RTE, rather as if one had written
* SELECT * FROM (VALUES ...) * SELECT * FROM (VALUES ...) AS "*VALUES*"
*/ */
static Query * static Query *
transformValuesClause(ParseState *pstate, SelectStmt *stmt) transformValuesClause(ParseState *pstate, SelectStmt *stmt)
@ -1162,6 +1162,7 @@ transformValuesClause(ParseState *pstate, SelectStmt *stmt)
rtr->rtindex = list_length(pstate->p_rtable); rtr->rtindex = list_length(pstate->p_rtable);
Assert(rte == rt_fetch(rtr->rtindex, pstate->p_rtable)); Assert(rte == rt_fetch(rtr->rtindex, pstate->p_rtable));
pstate->p_joinlist = lappend(pstate->p_joinlist, rtr); pstate->p_joinlist = lappend(pstate->p_joinlist, rtr);
pstate->p_relnamespace = lappend(pstate->p_relnamespace, rte);
pstate->p_varnamespace = lappend(pstate->p_varnamespace, rte); pstate->p_varnamespace = lappend(pstate->p_varnamespace, rte);
/* /*