mirror/postgresql
2
0
Fork 0
mirror of https://git.postgresql.org/git/postgresql.git synced 2024-11-27 07:21:09 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fixes:

Browse Source 
Select queries with an isnull or notnull clause, like "select * where
somefield isnull", crash the backend if the table has at least one index.
If the indices are deleted the queries work again. Also the explain
command fail in the same way.
The is caused by a bug in subroutine of the optimizer which doesn't check
null values in the clauses.

Submitted by: Massimo Dal Zotto <dz@cs.unitn.it>
This commit is contained in:
Marc G. Fournier 1996-07-19 07:14:14 +00:00
parent 3704b99522
commit a7cfd65532
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/path/indxpath.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.1.1.1 1996/07/09 06:21:35 scrappy Exp $
* $Header: /cvsroot/pgsql/src/backend/optimizer/path/indxpath.c,v 1.2 1996/07/19 07:13:26 scrappy Exp $
*
*-------------------------------------------------------------------------
*/
@ -493,7 +493,7 @@ match_clause_to_indexkey(Rel *rel,
/*
* Check for standard s-argable clause
*/
if (IsA(rightop,Const))
if (rightop && IsA(rightop,Const))
{
restrict_op = ((Oper*)((Expr*)clause)->oper)->opno;
isIndexable =
@ -507,7 +507,7 @@ match_clause_to_indexkey(Rel *rel,
/*
* Must try to commute the clause to standard s-arg format.
*/
else if (IsA(leftop,Const))
else if (leftop && IsA(leftop,Const))
{
restrict_op =
get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
@ -535,11 +535,13 @@ match_clause_to_indexkey(Rel *rel,
*/
else
{
if (match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
if (rightop
&& match_index_to_operand(indexkey,(Expr*)rightop,rel,index)) {
join_op = get_commutator(((Oper*)((Expr*)clause)->oper)->opno);
} else if (match_index_to_operand(indexkey,
} else if (leftop
&& match_index_to_operand(indexkey,
(Expr*)leftop,rel,index)) {
join_op = ((Oper*)((Expr*)clause)->oper)->opno;
}

4
src/backend/utils/adt/varlena.c
View File

@ -7,7 +7,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.2 1996/07/19 06:08:21 scrappy Exp $
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.3 1996/07/19 07:14:14 scrappy Exp $
*
*-------------------------------------------------------------------------
*/
@ -198,8 +198,6 @@ textout(struct varlena *vlena)
/* ========== PUBLIC ROUTINES ========== */
/*
/*
* textlen -
* returns the actual length of a text* (which may be less than