Print more information about getObjectIdentityParts() failures.

This might help us debug what's happening on some buildfarm members.

In passing, reduce the message from ereport to elog --- it doesn't seem
like this should be a user-facing case, so not worth translating.
This commit is contained in:
Tom Lane 2014-12-31 14:44:43 -05:00
parent 28551797a4
commit a486841eb1

View File

@ -4035,13 +4035,12 @@ getObjectIdentityParts(const ObjectAddress *object,
/* /*
* If a get_object_address representation was requested, make sure we are * If a get_object_address representation was requested, make sure we are
* providing one. We don't check for objargs, because many of the cases * providing one. We don't check objargs, because many of the cases above
* above leave it as NIL. * leave it as NIL.
*/ */
if (objname && *objname == NIL) if (objname && *objname == NIL)
ereport(ERROR, elog(ERROR, "requested object address for unsupported object class %d: text result \"%s\"",
(errcode(ERRCODE_INVALID_PARAMETER_VALUE), (int) getObjectClass(object), buffer.data);
errmsg("requested object address for object type that cannot support it")));
return buffer.data; return buffer.data;
} }